From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: DPS font backend uses the wrong font Date: Sun, 17 Oct 2021 18:35:29 +0100 Message-ID: References: <875ytvbxec.fsf.ref@yahoo.com> <875ytvbxec.fsf@yahoo.com> <87zgr7ai5i.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29705"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 17 19:46:36 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcAF0-0007UM-ID for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Oct 2021 19:46:34 +0200 Original-Received: from localhost ([::1]:45982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcAEy-00069B-Np for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Oct 2021 13:46:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcA4P-0004er-4Q for emacs-devel@gnu.org; Sun, 17 Oct 2021 13:35:37 -0400 Original-Received: from outbound.soverin.net ([2a01:4f8:fff0:65::8:228]:48311) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcA4N-0000mG-GU for emacs-devel@gnu.org; Sun, 17 Oct 2021 13:35:36 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id CD36A224; Sun, 17 Oct 2021 17:35:32 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1634492132; bh=0KJBSD+kcr3KoUor5tOhXkp2gR72OzK8hqhDAz2xKXQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g0V+wcMfX2Qk9RExbOGEfZIxHbR1q2Xjaik7NvTe8CCWTZ0TRfk/GMoYUD+gvHkWG AZkeX8OGp8y1htHNZ5E3aRZBq6egGvPDbEXxR3e7zsarr90i9MBFpHYXUkC5FZeFgR SRrVZ/b5dHwkdHZoInevNbwsbYXMH3QJYu0trNjpaciJWCjvboqZZcL0xfR9DBL/q6 TWTEi3+tYG8zbViI8HZn/y/Jhr5d+2vN6sCqtSn+egMGXKvMqXRa0d6/I9tklft2gE ICC0nVKQRrhcugBiu67daf6MMoCpnpV86fHo3mRzk8gzznMBIOSFylszZOxpX2VRUN Myxs+IXDLjRSA== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.95-RC2) (envelope-from ) id 1mcA4H-000M7E-Ad; Sun, 17 Oct 2021 18:35:29 +0100 Mail-Followup-To: Alan Third , Po Lu , emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: <87zgr7ai5i.fsf@yahoo.com> Received-SPF: pass client-ip=2a01:4f8:fff0:65::8:228; envelope-from=alan@idiocy.org; helo=outbound.soverin.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277223 Archived-At: On Sun, Oct 17, 2021 at 09:35:21PM +0800, Po Lu wrote: > Po Lu writes: > > > As of 2028df78, font backends are required to use s->font instead of > > s->face->font, even in the NS port, because s->face is now set to mouse > > face by redisplay independently of terminal specific code. > > BTW, this also means a great deal of code in the NS port that looks > like: > > if (s->hl == DRAW_MOUSE_FACE) > { > face = FACE_FROM_ID_OR_NULL (s->f, > MOUSE_HL_INFO (s->f)->mouse_face_face_id); > if (!face) > face = FACE_FROM_ID (s->f, MOUSE_FACE_ID); > } > else > face = FACE_FROM_ID (s->f, s->first_glyph->face_id); > > Can be removed now, because it's no longer necessary for > terminal-specific code to worry about the mouse face like this. Hmm, I wonder if this means mouse face will be honoured in SVG images now...? That would be nice because I couldn't work out how to find the mouse face where we construct the image struct. -- Alan Third