From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Please stop making extra unnecessary work for us all. Date: Tue, 12 Oct 2021 12:39:03 +0000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10538"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 12 14:40:18 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1maH4r-0002Vg-86 for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Oct 2021 14:40:17 +0200 Original-Received: from localhost ([::1]:52208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maH4q-0001m1-8k for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Oct 2021 08:40:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56254) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maH40-0000QM-Lj for emacs-devel@gnu.org; Tue, 12 Oct 2021 08:39:26 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:14735 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1maH3v-0008Fo-Bz for emacs-devel@gnu.org; Tue, 12 Oct 2021 08:39:23 -0400 Original-Received: (qmail 44707 invoked by uid 3782); 12 Oct 2021 12:39:06 -0000 Original-Received: from acm.muc.de (p4fe15ae7.dip0.t-ipconnect.de [79.225.90.231]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 12 Oct 2021 14:39:05 +0200 Original-Received: (qmail 9138 invoked by uid 1000); 12 Oct 2021 12:39:03 -0000 Content-Disposition: inline X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276787 Archived-At: Hello, Emacs and Stefan K. I'm referring to commit 0a7bab689c4a113dd295c9db55d8e76a34d5f9e1 Author: Stefan Kangas Date: Mon Sep 27 23:56:55 2021 +0200 ; Minor stylistic fixes found by checkdoc , and several other similar changes. Yes, that was the entire commit message for an assemblage of patches many hundreds of lines long, not even mentioning the files changed, never mind the defuns. Sadly, git has no features for amending inadequate commit messages. But the point of this post is that these changes are surely unnecessary with a miniscule benefit, much like pure whitespace changes. And like pure WS changes, they mess up git blame, they make searches in history more difficult. In some instances they introduce solecisms in English usage. Many non-functional changes have been made in CC Mode. That additionally means that patches from standalone CC Mode are even less likely to apply cleanly in the Emacs branches than they were already. That means extra unwanted tedious work for me. And what are these changes? In at least two instances the case of a letter in warning messages following a colon was changed from lower to upper. Or was it the other way around? Come on, please, this is madness. Who would even notice the case of a letter after a colon in a warning message, much less care about it? I protest at these changes. As far as I can remember, there was no discussion on emacs-devel preceding them. They are disruptive changes. Can we please not have any more such. Thanks. -- Alan Mackenzie (Nuremberg, Germany).