From: Alan Mackenzie <acm@muc.de>
To: emacs-devel@gnu.org
Cc: Stefan Kangas <stefan@marxist.se>
Subject: Please stop making extra unnecessary work for us all.
Date: Tue, 12 Oct 2021 12:39:03 +0000 [thread overview]
Message-ID: <YWWB5/qaVcJTPFoP@ACM> (raw)
Hello, Emacs and Stefan K.
I'm referring to
commit 0a7bab689c4a113dd295c9db55d8e76a34d5f9e1
Author: Stefan Kangas <stefan@marxist.se>
Date: Mon Sep 27 23:56:55 2021 +0200
; Minor stylistic fixes found by checkdoc
, and several other similar changes. Yes, that was the entire commit
message for an assemblage of patches many hundreds of lines long, not
even mentioning the files changed, never mind the defuns. Sadly, git
has no features for amending inadequate commit messages.
But the point of this post is that these changes are surely unnecessary
with a miniscule benefit, much like pure whitespace changes.
And like pure WS changes, they mess up git blame, they make searches in
history more difficult. In some instances they introduce solecisms in
English usage.
Many non-functional changes have been made in CC Mode. That
additionally means that patches from standalone CC Mode are even less
likely to apply cleanly in the Emacs branches than they were already.
That means extra unwanted tedious work for me.
And what are these changes? In at least two instances the case of a
letter in warning messages following a colon was changed from lower to
upper. Or was it the other way around? Come on, please, this is
madness. Who would even notice the case of a letter after a colon in a
warning message, much less care about it?
I protest at these changes. As far as I can remember, there was no
discussion on emacs-devel preceding them. They are disruptive changes.
Can we please not have any more such.
Thanks.
--
Alan Mackenzie (Nuremberg, Germany).
next reply other threads:[~2021-10-12 12:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 12:39 Alan Mackenzie [this message]
2021-10-12 12:44 ` Please stop making extra unnecessary work for us all Lars Ingebrigtsen
2021-10-12 12:55 ` Campbell Barton
2021-10-12 16:16 ` Finding the culprit (was: Please stop making extra unnecessary work for us all) Stefan Monnier
2021-10-12 16:40 ` Please stop making extra unnecessary work for us all Stefan Kangas
2021-10-12 13:36 ` dick
2021-10-12 15:00 ` Stefan Kangas
2021-10-12 23:20 ` Jean-Christophe Helary
2021-10-12 16:09 ` CC-mode fork (was: Please stop making extra unnecessary work for us all) Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWWB5/qaVcJTPFoP@ACM \
--to=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).