From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: input-pending-p after make-frame-visible Date: Mon, 4 Oct 2021 21:37:53 +0100 Message-ID: References: <83wnmwd3wo.fsf@gnu.org> <6c69780538e1957d1002@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13947"; mail-complaints-to="usenet@ciao.gmane.io" Cc: martin rudalics , Gregory Heytings , Eli Zaretskii , emacs-devel@gnu.org To: Aaron Jensen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 04 22:39:12 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXUjv-0003L3-6i for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Oct 2021 22:39:11 +0200 Original-Received: from localhost ([::1]:40646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXUjt-0004un-35 for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Oct 2021 16:39:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXUj0-0003Zt-OH for emacs-devel@gnu.org; Mon, 04 Oct 2021 16:38:14 -0400 Original-Received: from outbound.soverin.net ([116.202.126.228]:36561) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXUiy-0002uW-CG; Mon, 04 Oct 2021 16:38:14 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id D3C4A92; Mon, 4 Oct 2021 20:37:59 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.142]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1633379878; bh=HC83jPOXH6IIdFz/9w/H/Rp9VHNCpBsDC0Ee6areouk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FNoo8rleDvMitCoTbfoOtm3Z0LFX14WLfuvW6tD5NzIklaZQkY2hnRFtBaocYGrNG WQ4OxzEJYDEdG4smNmE/a2hXIoD+rNS2G3aEW4sX+vKo7hpmG8jZUmBwSNUVQYALpt orN4CEl6lQTUXwxr+7mgRYJq5JIgcfAq9Wu0AhyA+uSLq06B6UGttyd5am4nBswPmC YoSYKNy6IEd5ZdQLAJEJcgtHgNEW/49a3/EjkoBB/PiW5KzoFUE3jNOstFbF1MEUGk qplD4gXITvcvrHQ/g3eNaX/6I82XrOTl8mM/hnzcwBH/7p7+HS1DbN9BVTDoKrL4c0 eysfC8t802mHg== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.95-RC2) (envelope-from ) id 1mXUif-000Wqd-No; Mon, 04 Oct 2021 21:37:53 +0100 Mail-Followup-To: Alan Third , Aaron Jensen , Gregory Heytings , martin rudalics , Eli Zaretskii , emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=116.202.126.228; envelope-from=alan@idiocy.org; helo=outbound.soverin.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276269 Archived-At: On Mon, Oct 04, 2021 at 11:00:57AM -0400, Aaron Jensen wrote: > On Mon, Oct 4, 2021 at 8:20 AM Gregory Heytings wrote: > > FTR, I can reproduce this on macOS, with Emacs 27.2. A more detailed > > recipe is: > > Thank you for checking and the additional details. > > I added Alan to the thread in case this is a macOS specific issue. > Alan, any sense of what might cause the help-echo event to get added > back to the queue any time a child frame is shown? (I don't know if I > properly described what is happening, but hopefully that's close > enough along with the repro) Does this do anything: modified src/nsterm.m @@ -7048,6 +7048,7 @@ - (void)windowDidResignKey: (NSNotification *)notification XSETFRAME (frame, emacsframe); help_echo_string = Qnil; gen_help_event (Qnil, frame, Qnil, Qnil, 0); + any_help_event_p = NO; } if (emacs_event && is_focus_frame) ? -- Alan Third