unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jean Louis <bugs@gnu.support>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: Eli Zaretskii <eliz@gnu.org>,
	monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: master b72f885: Make dlet work like let, not let*
Date: Mon, 20 Sep 2021 20:02:15 +0300	[thread overview]
Message-ID: <YUi+l8Tw5giGdeOw@protected.localdomain> (raw)
In-Reply-To: <74C5058D-AF5C-4F1A-8D08-251935A69693@acm.org>

* Mattias Engdegård <mattiase@acm.org> [2021-08-03 18:22]:
> The change itself is also low-risk: it's an esoteric function and
> I've found no use of it anywhere outside the Emacs tree -- I did
> search. Furthermore, even inside Emacs all uses were found to be
> insensitive to the let/let* binding semantics.

If you don't use it, I do and it is one important function to my work,
I use it few times in few files related to variables interpolation in
templates and dynamic code fetching and re-use. And I have not ever
considered it `esoteric'.

grep --color=auto -nH -e dlet *.el
rcd-cf.el:6870:  (dlet ((wrs-text text))
rcd-cf.el:6889:  (dlet ((wrs::page (rcd-db-table-id-hash "pages" page-id cf-db))
rcd-cf.el:6919:    (dlet ((wrs::text (rcd-template-eval (gethash "pages_content" wrs::page "") '("⟦" "⟧") wrs::variables))
rcd-cf.el:6922:      (dlet ((wrs::template (gethash "templates_content" wrs::template))
rcd-utilities.el:1480:  (dlet ((wrs-processor "asciidoctor"))

> Well sort of: if someones finds out about a construct named `dlet`,
> it's just natural to assume that it binds like `let`, not like
> `let*`. (Supporting evidence: two local macros on the pattern
> `something-dlet*` were in use. One of the has now been renamed.)

For me it is not natural. `dlet' is supposed to bind variables
dynamically and with this change it doesn't. Basically the function is
ruined how I see it.

Your proposal is not logical and that you just changed it without
deeper analysis is very suprising.


-- 
Jean

Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns

In support of Richard M. Stallman
https://stallmansupport.org/



  parent reply	other threads:[~2021-09-20 17:02 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-01 16:10 master b72f885: Make dlet work like let, not let* Eli Zaretskii
2021-08-03 13:03 ` Mattias Engdegård
2021-08-03 13:33   ` Eli Zaretskii
2021-08-03 15:21     ` Mattias Engdegård
2021-08-03 15:58       ` Eli Zaretskii
2021-08-03 17:19         ` Stefan Monnier
2021-08-03 17:50           ` Eli Zaretskii
2021-08-03 18:50             ` Stefan Monnier
2021-08-04 11:27               ` Eli Zaretskii
2021-08-04 11:35                 ` Lars Ingebrigtsen
2021-08-04 11:46                   ` Mattias Engdegård
2021-08-04 12:16                     ` Eli Zaretskii
2021-08-04 12:48                       ` Mattias Engdegård
2021-08-04 12:15                   ` Eli Zaretskii
2021-08-04  3:09             ` Michael Heerdegen
2021-08-04 11:40               ` Eli Zaretskii
2021-09-20 17:08                 ` Jean Louis
2021-09-20 17:02       ` Jean Louis [this message]
2021-09-20 16:56 ` Jean Louis
2021-09-20 19:16   ` Tassilo Horn
2021-09-21  4:19     ` Jean Louis
2021-09-21  6:31       ` Tassilo Horn
2021-09-21  7:17         ` Jean Louis
2021-09-21  7:50           ` Tassilo Horn
2021-09-21  9:31             ` Jean Louis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUi+l8Tw5giGdeOw@protected.localdomain \
    --to=bugs@gnu.support \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=mattiase@acm.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).