From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: bug-reference-prog-mode slows down CC Mode's scrolling by ~7% Date: Thu, 2 Sep 2021 19:24:51 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18683"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 02 21:26:03 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLsLY-0004an-Rr for ged-emacs-devel@m.gmane-mx.org; Thu, 02 Sep 2021 21:26:00 +0200 Original-Received: from localhost ([::1]:41758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLsLW-0000ae-QS for ged-emacs-devel@m.gmane-mx.org; Thu, 02 Sep 2021 15:25:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLsKW-0008G0-VK for emacs-devel@gnu.org; Thu, 02 Sep 2021 15:24:56 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:64746 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1mLsKU-0005Ad-Tq for emacs-devel@gnu.org; Thu, 02 Sep 2021 15:24:56 -0400 Original-Received: (qmail 40734 invoked by uid 3782); 2 Sep 2021 19:24:51 -0000 Original-Received: from acm.muc.de (p4fe15b97.dip0.t-ipconnect.de [79.225.91.151]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 02 Sep 2021 21:24:51 +0200 Original-Received: (qmail 8052 invoked by uid 1000); 2 Sep 2021 19:24:51 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:273727 Archived-At: Hello, Stefan. On Thu, Sep 02, 2021 at 14:46:51 -0400, Stefan Monnier wrote: > >> > However, this mechanism is rendered ineffective if a second function > >> > is add-hook'd onto jit-lock-functions. Maybe this could be fixed, > >> > though it looks difficult. > >> I think we can "easily" handle this specific case if the > >> `bug-reference-prog-mode` function is added to the end of the hook > >> rather than to its beginning and use a patch along the lines of the > >> one below. > > Yes. How about an optional parameter to jit-lock-register meaning "put > > this function at the beginning of jit-lock-functions", with the default > > meaning put the function at the end? > Sure. Basically, the idea is that the function which is most likely to > grow the bounds (or to grow them most) should come first. OK, thanks. > > I haven't tried it, but I don't think the patch below is quite enough. > I'd be surprised if it is, indeed, I just thought it was a better > description of the intention than whatever I could come up in words. Sorry, I didn't pick that up. But I think I've worked out how to do it. In words (;-), only the first function on jit-lock-functions should be able to expand the region which gets `fontified' text properties. This expanded region will then be supplied to the subsequent functions. Given how little used the `jit-lock-bounds' mechanism is (there is one function in Emacs, font-lock-default-fontify-region, which uses it, and a web search revealed only a single other instance, in lsp-mode on git-hub), this shouldn't cause problems. In fact, I'm not sure the lsp-mode use of it is even correct. > Stefan -- Alan Mackenzie (Nuremberg, Germany).