From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: What's the best (i.e. least bad) way to re-redisplay? Date: Thu, 26 Aug 2021 17:02:16 +0000 Message-ID: References: <83r1egu2xx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25535"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 26 19:05:37 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJIor-0006U6-0T for ged-emacs-devel@m.gmane-mx.org; Thu, 26 Aug 2021 19:05:37 +0200 Original-Received: from localhost ([::1]:43262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJIop-00081v-CY for ged-emacs-devel@m.gmane-mx.org; Thu, 26 Aug 2021 13:05:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44416) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJIlj-0004As-3M for emacs-devel@gnu.org; Thu, 26 Aug 2021 13:02:23 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:28570 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1mJIlg-0007ej-S5 for emacs-devel@gnu.org; Thu, 26 Aug 2021 13:02:22 -0400 Original-Received: (qmail 46919 invoked by uid 3782); 26 Aug 2021 17:02:16 -0000 Original-Received: from acm.muc.de (p4fe157d3.dip0.t-ipconnect.de [79.225.87.211]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 26 Aug 2021 19:02:16 +0200 Original-Received: (qmail 7357 invoked by uid 1000); 26 Aug 2021 17:02:16 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:273052 Archived-At: Hello, Stefan. On Thu, Aug 26, 2021 at 09:49:33 -0400, Stefan Monnier wrote: > >> > I think something along the lines of > >> > (run-with-timer 0 nil > >> > (lambda (buf) > >> > (with-current-buffer buf (font-lock-flush))) > >> > (current-buffer)) > >> > is the cleanest that comes to mind. > >> Thanks. That's probably cleaner than a direct use of > >> jit-lock-force-redisplay. > > Why is it cleaner? jit-lock and font-lock include provision for the > > fontification function to tell jit-lock what was the region actually > > fontified, and that will trigger a call to jit-lock-force-redisplay in > > a timer. Why not use an existing mechanism? > That's indeed another option. I assumed that the situation is such that > while fontifying region POS1..POS2 we discover a new type that forces > the whole buffer to be refontified (or at least some region POS3..POS4), > in which case it's best to use `font-lock-flush` and let this > refontification happen lazily. My idea is that, say, a new type "foo" is found by stealth fontification. CC Mode will then do a regexp search for "\\_" from BOB to EOB removing 'fontified text properties from each match it finds. This is fast (around 10ms per found type in xdisp.c). It should be enough to force (re)fontification of (the statements containing) "foo" whenever these occurrences are scrolled onto. Then there's the currently displayed window, as we've been discussing. That, of course, involves somehow persuading the user to enable stealth fontification. > But if indeed we can cheaply adjust the few places in the buffer that > are affected without performing a full "refontify" it might indeed be > a good idea to do that and adjust the `jit-lock-bounds` return value, > but in that case we have to be sure that the new bounds indeed describe > an area of the buffer that is now fully fontified, which is likely to be > a problem because there is no reason to assume that the buffer outside > of POS1..POS2 had already been fontified, so it may force us to eagerly > fontify additional parts of POS3..POS4. > Another option if we can cheaply adjust the few places in the buffer that > are affected without performing a full "refontify", is to do those > adjustments and then only force a redisplay but not a refontification. This is exactly my plan. > I think this can be done with something like: > (run-with-timer 0 nil > (lambda (buf) > (with-current-buffer buf > (put-text-property (point-min) (point-max) 'cc-dummy t) > (remove-text-properties (point-min) (point-max) '(cc-dummy)))) > (current-buffer)) I don't understand what that bit of code's doing. > -- Stefan -- Alan Mackenzie (Nuremberg, Germany).