From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language Date: Sat, 21 Aug 2021 09:55:57 +0000 Message-ID: References: <87sfz9fx0y.fsf@gnus.org> <87bl5vhng9.fsf@tcd.ie> <87sfz7fwlv.fsf@tcd.ie> <87k0kiguif.fsf@tcd.ie> <87k0kfenzh.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23715"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Glenn Morris , Lars Ingebrigtsen , emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 21 11:57:06 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mHNkP-0005yA-VA for ged-emacs-devel@m.gmane-mx.org; Sat, 21 Aug 2021 11:57:05 +0200 Original-Received: from localhost ([::1]:36392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mHNkO-00047g-2H for ged-emacs-devel@m.gmane-mx.org; Sat, 21 Aug 2021 05:57:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mHNjP-00031I-RM for emacs-devel@gnu.org; Sat, 21 Aug 2021 05:56:03 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:12132 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1mHNjM-0002rA-Du for emacs-devel@gnu.org; Sat, 21 Aug 2021 05:56:03 -0400 Original-Received: (qmail 56625 invoked by uid 3782); 21 Aug 2021 09:55:58 -0000 Original-Received: from acm.muc.de (p4fe15b48.dip0.t-ipconnect.de [79.225.91.72]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 21 Aug 2021 11:55:57 +0200 Original-Received: (qmail 5764 invoked by uid 1000); 21 Aug 2021 09:55:57 -0000 Content-Disposition: inline In-Reply-To: <87k0kfenzh.fsf@tcd.ie> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272778 Archived-At: Hello, Basil. On Fri, Aug 20, 2021 at 23:43:30 +0100, Basil L. Contovounesios wrote: > Alan Mackenzie [2021-08-20 21:20 +0000] wrote: [ .... ] > > I've just committed a patch to master which I think fixes the problem. > Thanks! That indeed fixes the hang here. > If it stops the hangs from happening on Hydra as well, then the relevant > electric-tests will no longer need to be skipped there. > I see only one minor issue with the patch: it introduces a use of the > macro c-benign-error before its definition, which gives rise to a > byte-compiler warning. I would have moved the macro's definition > myself, but I see the file is organised in a particular way, so I leave > that to you. Sorry about that. I completely missed that warning message (which perhaps ought to be an error, since it compiles a function call instead of expanding the macro). I've moved the macro to earlier on in the file. No big deal. I've committed the change, and it should be OK now. > Thanks, Thank you! > -- > Basil -- Alan Mackenzie (Nuremberg, Germany).