unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: "Basil L. Contovounesios" <contovob@tcd.ie>,
	Lars Ingebrigtsen <larsi@gnus.org>
Cc: Glenn Morris <rgm@gnu.org>, emacs-devel@gnu.org
Subject: Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language
Date: Fri, 20 Aug 2021 21:20:49 +0000	[thread overview]
Message-ID: <YSAcsbIi7Bzd2tXD@ACM> (raw)
In-Reply-To: <YR+IZEivSHghSb4n@ACM>

Hello, Lars and Basil.

On Fri, Aug 20, 2021 at 10:48:04 +0000, Alan Mackenzie wrote:
[ .... ]

> The problem is a bug in c-point-syntax.  There, there is
>   (i) an invocation of c-save-buffer-state, which binds buffer-undo-list
>   to t, followed by
>   (ii) an invocation of c-tentative-buffer-changes, which pushes nil onto
>   buffer-undo-list (simulating an undo group) giving (nil t).
>   (iii) A { is typed into the buffer, giving buffer-undo-list now as
>   something like ((5128 . 5129) nil t).
> At this point garbage collection occurs.  This strips the tail of
> buffer-undo-list, leaving ((5128 . 5129)).
>   (iv) In c-tnt-chng-cleanup, primitive-undo is repeated infinitely,
>   since buffer-undo-list will never become the expected value (nil t).

> The problem would appear to be the invalid value ((5128 . 5129) nil t) in
> buffer-undo-list.

> I'll see what I can do about this tonight.

I've just committed a patch to master which I think fixes the problem.

Thanks especially to Basil for exceptionally helpful debugging info.

> > -- 
> > Basil

-- 
Alan Mackenzie (Nuremberg, Germany).



  reply	other threads:[~2021-08-20 21:20 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210812190845.13266.82536@vcs0.savannah.gnu.org>
     [not found] ` <20210812190847.E372A20997@vcs0.savannah.gnu.org>
2021-08-13 14:20   ` master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language Lars Ingebrigtsen
2021-08-13 19:52     ` Alan Mackenzie
2021-08-14 11:53       ` Lars Ingebrigtsen
2021-08-14 14:53         ` Alan Mackenzie
2021-08-14 19:30           ` Lars Ingebrigtsen
2021-08-14 23:24             ` Glenn Morris
2021-08-14 23:31               ` Lars Ingebrigtsen
2021-08-15  6:12                 ` Eli Zaretskii
2021-08-15 15:23                 ` Alan Mackenzie
2021-08-16 11:29                   ` Lars Ingebrigtsen
2021-08-17 19:37                     ` Basil L. Contovounesios
2021-08-18  0:02                       ` Basil L. Contovounesios
2021-08-18 14:48                         ` Lars Ingebrigtsen
2021-08-18 17:07                           ` Basil L. Contovounesios
2021-08-18 17:37                         ` Alan Mackenzie
2021-08-18 19:20                           ` Alan Mackenzie
2021-08-18 20:47                             ` Alan Mackenzie
2021-08-19  0:15                               ` Basil L. Contovounesios
2021-08-20 10:48                                 ` Alan Mackenzie
2021-08-20 21:20                                   ` Alan Mackenzie [this message]
2021-08-20 22:43                                     ` Basil L. Contovounesios
2021-08-21  9:55                                       ` Alan Mackenzie
2021-08-21  7:15                                     ` Eli Zaretskii
2021-08-21 10:00                                       ` Alan Mackenzie
2021-08-21 10:04                                         ` Eli Zaretskii
2021-08-19  0:13                             ` Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YSAcsbIi7Bzd2tXD@ACM \
    --to=acm@muc.de \
    --cc=contovob@tcd.ie \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).