From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language Date: Fri, 13 Aug 2021 19:52:43 +0000 Message-ID: References: <20210812190845.13266.82536@vcs0.savannah.gnu.org> <20210812190847.E372A20997@vcs0.savannah.gnu.org> <87r1exa0jf.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26462"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 13 21:53:40 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mEdFL-0006e7-Iv for ged-emacs-devel@m.gmane-mx.org; Fri, 13 Aug 2021 21:53:39 +0200 Original-Received: from localhost ([::1]:53910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mEdFJ-0008Ie-PK for ged-emacs-devel@m.gmane-mx.org; Fri, 13 Aug 2021 15:53:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mEdEm-0007cM-K7 for emacs-devel@gnu.org; Fri, 13 Aug 2021 15:53:04 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:10393 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1mEdEk-0005zB-58 for emacs-devel@gnu.org; Fri, 13 Aug 2021 15:53:04 -0400 Original-Received: (qmail 87414 invoked by uid 3782); 13 Aug 2021 19:52:44 -0000 Original-Received: from acm.muc.de (p4fe159a7.dip0.t-ipconnect.de [79.225.89.167]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 13 Aug 2021 21:52:44 +0200 Original-Received: (qmail 19402 invoked by uid 1000); 13 Aug 2021 19:52:43 -0000 Content-Disposition: inline In-Reply-To: <87r1exa0jf.fsf@gnus.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272374 Archived-At: Hello, Lars. On Fri, Aug 13, 2021 at 16:20:52 +0200, Lars Ingebrigtsen wrote: > acm@muc.de (Alan Mackenzie) writes: > > +(defun c-ml-string-opener-around-point () > > + ;; If point is inside an ml string opener, return a dotted list of the start > > + ;; and end of that opener, and the position of its double-quote. That list > I'm not quite sure that it's this patch, but the some electric tests > started failing today with the following backtrace: Yes, sorry, it's that patch indeed. It's a rather serious bug which might have left C Mode unusable. I'll fix it right now. > Test electric-pair-electric-quote-replace-double-escaped-close-at-point-12-in-c-mode-in-strings backtrace: > c-ml-string-opener-at-or-around-point(1) > c-before-change-check-unbalanced-strings(12 12) > #f(compiled-function (fn) #)(c-before-c > mapc(#f(compiled-function (fn) #) (c-ex > c-before-change(12 12) > self-insert-command(1 34) > funcall-interactively(self-insert-command 1 34) > call-interactively(self-insert-command) > (closure ((vals) (syms) (temp-buffer . #) (doc-string > funcall((closure ((vals) (syms) (temp-buffer . #) (do > (let ((electric-quote-replace-double 't) (electric-quote-comment 't) > eval((let ((electric-quote-replace-double 't) (electric-quote-commen > (let* ((syms (mapcar #'car bindings)) (vals (mapcar #'cdr bindings)) > (progn (let* ((syms (mapcar #'car bindings)) (vals (mapcar #'cdr bin > (let ((last-command-event char) (transient-mark-mode 'lambda)) (goto > (closure ((temp-buffer . #) (doc-string . "Electricit > funcall((closure ((temp-buffer . #) (doc-string . "El > (unwind-protect (funcall fn) (electric-pair-mode saved-electric) (el > (let ((saved-electric (if electric-pair-mode 1 -1)) (saved-layout (i > call-with-saved-electric-modes((closure ((temp-buffer . # (progn (funcall mode) (insert fixture) (call-with-saved-electric-mod > (unwind-protect (progn (funcall mode) (insert fixture) (call-with-sa > (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn > (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current > electric-pair-test-for("\"foo \\“foo\\\"" 12 34 "\"foo \\“foo\\”\"" > (closure (t) nil (electric-pair-test-for "\"foo \\“foo\\\"" 12 34 "\ > ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test > ert-run-test(#s(ert-test :name electric-pair-electric-quote-replace- > ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m > ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil > ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) > ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco > eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n > command-line-1(("-L" ":." "-L" "./../../elpa/packages/url-http-ntlm/ > command-line() > normal-top-level() > Test electric-pair-electric-quote-replace-double-escaped-close-at-point-12-in-c-mode-in-strings condition: > (wrong-type-argument number-or-marker-p nil) > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no -- Alan Mackenzie (Nuremberg, Germany).