Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Lars Ingebrigtsen]

acm@muc.de (Alan Mackenzie) writes:

> +(defun c-ml-string-opener-around-point ()
> +  ;; If point is inside an ml string opener, return a dotted list of the start
> +  ;; and end of that opener, and the position of its double-quote.  That list

I'm not quite sure that it's this patch, but the some electric tests
started failing today with the following backtrace:

Test electric-pair-electric-quote-replace-double-escaped-close-at-point-12-in-c-mode-in-strings backtrace:
  c-ml-string-opener-at-or-around-point(1)
  c-before-change-check-unbalanced-strings(12 12)
  #f(compiled-function (fn) #<bytecode 0x1aaf1ff2c636a263>)(c-before-c
  mapc(#f(compiled-function (fn) #<bytecode 0x1aaf1ff2c636a263>) (c-ex
  c-before-change(12 12)
  self-insert-command(1 34)
  funcall-interactively(self-insert-command 1 34)
  call-interactively(self-insert-command)
  (closure ((vals) (syms) (temp-buffer . #<killed buffer>) (doc-string
  funcall((closure ((vals) (syms) (temp-buffer . #<killed buffer>) (do
  (let ((electric-quote-replace-double 't) (electric-quote-comment 't)
  eval((let ((electric-quote-replace-double 't) (electric-quote-commen
  (let* ((syms (mapcar #'car bindings)) (vals (mapcar #'cdr bindings))
  (progn (let* ((syms (mapcar #'car bindings)) (vals (mapcar #'cdr bin
  (let ((last-command-event char) (transient-mark-mode 'lambda)) (goto
  (closure ((temp-buffer . #<killed buffer>) (doc-string . "Electricit
  funcall((closure ((temp-buffer . #<killed buffer>) (doc-string . "El
  (unwind-protect (funcall fn) (electric-pair-mode saved-electric) (el
  (let ((saved-electric (if electric-pair-mode 1 -1)) (saved-layout (i
  call-with-saved-electric-modes((closure ((temp-buffer . #<killed buf
  (progn (funcall mode) (insert fixture) (call-with-saved-electric-mod
  (unwind-protect (progn (funcall mode) (insert fixture) (call-with-sa
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
  (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current
  electric-pair-test-for("\"foo \\“foo\\\"" 12 34 "\"foo \\“foo\\”\"" 
  (closure (t) nil (electric-pair-test-for "\"foo \\“foo\\\"" 12 34 "\
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name electric-pair-electric-quote-replace-
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
  ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
  ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
  eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
  command-line-1(("-L" ":." "-L" "./../../elpa/packages/url-http-ntlm/
  command-line()
  normal-top-level()
Test electric-pair-electric-quote-replace-double-escaped-close-at-point-12-in-c-mode-in-strings condition:
    (wrong-type-argument number-or-marker-p nil)


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Alan Mackenzie]

Hello, Lars.

On Fri, Aug 13, 2021 at 16:20:52 +0200, Lars Ingebrigtsen wrote:
> acm@muc.de (Alan Mackenzie) writes:

> > +(defun c-ml-string-opener-around-point ()
> > +  ;; If point is inside an ml string opener, return a dotted list of the start
> > +  ;; and end of that opener, and the position of its double-quote.  That list

> I'm not quite sure that it's this patch, but the some electric tests
> started failing today with the following backtrace:

Yes, sorry, it's that patch indeed.  It's a rather serious bug which
might have left C Mode unusable.  I'll fix it right now.

> Test electric-pair-electric-quote-replace-double-escaped-close-at-point-12-in-c-mode-in-strings backtrace:
>   c-ml-string-opener-at-or-around-point(1)
>   c-before-change-check-unbalanced-strings(12 12)
>   #f(compiled-function (fn) #<bytecode 0x1aaf1ff2c636a263>)(c-before-c
>   mapc(#f(compiled-function (fn) #<bytecode 0x1aaf1ff2c636a263>) (c-ex
>   c-before-change(12 12)
>   self-insert-command(1 34)
>   funcall-interactively(self-insert-command 1 34)
>   call-interactively(self-insert-command)
>   (closure ((vals) (syms) (temp-buffer . #<killed buffer>) (doc-string
>   funcall((closure ((vals) (syms) (temp-buffer . #<killed buffer>) (do
>   (let ((electric-quote-replace-double 't) (electric-quote-comment 't)
>   eval((let ((electric-quote-replace-double 't) (electric-quote-commen
>   (let* ((syms (mapcar #'car bindings)) (vals (mapcar #'cdr bindings))
>   (progn (let* ((syms (mapcar #'car bindings)) (vals (mapcar #'cdr bin
>   (let ((last-command-event char) (transient-mark-mode 'lambda)) (goto
>   (closure ((temp-buffer . #<killed buffer>) (doc-string . "Electricit
>   funcall((closure ((temp-buffer . #<killed buffer>) (doc-string . "El
>   (unwind-protect (funcall fn) (electric-pair-mode saved-electric) (el
>   (let ((saved-electric (if electric-pair-mode 1 -1)) (saved-layout (i
>   call-with-saved-electric-modes((closure ((temp-buffer . #<killed buf
>   (progn (funcall mode) (insert fixture) (call-with-saved-electric-mod
>   (unwind-protect (progn (funcall mode) (insert fixture) (call-with-sa
>   (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
>   (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current
>   electric-pair-test-for("\"foo \\“foo\\\"" 12 34 "\"foo \\“foo\\”\"" 
>   (closure (t) nil (electric-pair-test-for "\"foo \\“foo\\\"" 12 34 "\
>   ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
>   ert-run-test(#s(ert-test :name electric-pair-electric-quote-replace-
>   ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
>   ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
>   ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
>   ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
>   eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
>   command-line-1(("-L" ":." "-L" "./../../elpa/packages/url-http-ntlm/
>   command-line()
>   normal-top-level()
> Test electric-pair-electric-quote-replace-double-escaped-close-at-point-12-in-c-mode-in-strings condition:
>     (wrong-type-argument number-or-marker-p nil)


> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Lars Ingebrigtsen]

Alan Mackenzie <acm@muc.de> writes:

> Yes, sorry, it's that patch indeed.  It's a rather serious bug which
> might have left C Mode unusable.  I'll fix it right now.

Thanks; that fixed two of the failing tests.  There's still one
remaining, though:

1 unexpected results:
   FAILED  electric-pair-whitespace-chomping-2-at-point-4-in-c++-mode-in-strings


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Alan Mackenzie]

Hello, Lars.

On Sat, Aug 14, 2021 at 13:53:24 +0200, Lars Ingebrigtsen wrote:
> Alan Mackenzie <acm@muc.de> writes:

> > Yes, sorry, it's that patch indeed.  It's a rather serious bug which
> > might have left C Mode unusable.  I'll fix it right now.

> Thanks; that fixed two of the failing tests.  There's still one
> remaining, though:

> 1 unexpected results:
>    FAILED  electric-pair-whitespace-chomping-2-at-point-4-in-c++-mode-in-strings

Yes, I thought it best to fix the first bug first.  In C Mode, it threw
an error merely by typing into a string.

I've just comitted a fix for the other bug, which was more complicated.

> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Lars Ingebrigtsen]

Alan Mackenzie <acm@muc.de> writes:

> Yes, I thought it best to fix the first bug first.  In C Mode, it threw
> an error merely by typing into a string.
>
> I've just comitted a fix for the other bug, which was more complicated.

Thanks; I can confirm that the test failure disappeared here, too.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Glenn Morris]

On hydra, electric tests began timing out with c4d34d, and continue to
do so through at least 9c5dc3c.

Ref:
https://hydra.nixos.org/build/149924378
https://hydra.nixos.org/build/149941893

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Lars Ingebrigtsen]

Glenn Morris <rgm@gnu.org> writes:

> On hydra, electric tests began timing out with c4d34d, and continue to
> do so through at least 9c5dc3c.
>
> Ref:
> https://hydra.nixos.org/build/149924378
> https://hydra.nixos.org/build/149941893

Huh.

  ELC      lisp/electric-tests.elc
  GEN      lisp/electric-tests.log
building of '/nix/store/g7mnplyk8lfyxlv9ggcy25msgrwp5vz9-emacs-coverage-unknown' timed out after 7200 seconds of silence

I saw the same thing -- but only on one machine, and only with "make
check-maybe".  And it went away there after doing a full "make -j16" in
the test directory, so I thought it was just a transient thing...

Let's see...

Yup, the following seems to hang reliably for me:

touch lisp/electric.el; make check-maybe

This is on Debian/bullseye, if that makes a difference.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Sun, 15 Aug 2021 01:31:01 +0200
> Cc: Alan Mackenzie <acm@muc.de>, emacs-devel@gnu.org
> 
> Yup, the following seems to hang reliably for me:
> 
> touch lisp/electric.el; make check-maybe

You didn't pay your electricity bills?

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Alan Mackenzie]

Hello, Lars.

On Sun, Aug 15, 2021 at 01:31:01 +0200, Lars Ingebrigtsen wrote:
> Glenn Morris <rgm@gnu.org> writes:

> > On hydra, electric tests began timing out with c4d34d, and continue to
> > do so through at least 9c5dc3c.
> >
> > Ref:
> > https://hydra.nixos.org/build/149924378
> > https://hydra.nixos.org/build/149941893

> Huh.

>   ELC      lisp/electric-tests.elc
>   GEN      lisp/electric-tests.log
> building of '/nix/store/g7mnplyk8lfyxlv9ggcy25msgrwp5vz9-emacs-coverage-unknown' timed out after 7200 seconds of silence

> I saw the same thing -- but only on one machine, and only with "make
> check-maybe".  And it went away there after doing a full "make -j16" in
> the test directory, so I thought it was just a transient thing...

> Let's see...

> Yup, the following seems to hang reliably for me:

> touch lisp/electric.el; make check-maybe

> This is on Debian/bullseye, if that makes a difference.

For what it's worth, I can't reproduce it on Gentoo.  The check-maybe
just completes normally.

> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Lars Ingebrigtsen]

Alan Mackenzie <acm@muc.de> writes:

> For what it's worth, I can't reproduce it on Gentoo.  The check-maybe
> just completes normally.

And I can't reproduce it either now.  Yesterday, it was totally
reproducible on two different machines, but not today.  :-/

It still seems to be timing out on Hydra.  Perhaps it's something
weirdly timing related?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Basil L. Contovounesios]

Lars Ingebrigtsen [2021-08-16 13:29 +0200] wrote:

> Alan Mackenzie <acm@muc.de> writes:
>
>> For what it's worth, I can't reproduce it on Gentoo.  The check-maybe
>> just completes normally.
>
> And I can't reproduce it either now.  Yesterday, it was totally
> reproducible on two different machines, but not today.  :-/
>
> It still seems to be timing out on Hydra.  Perhaps it's something
> weirdly timing related?

It's hanged several times for me locally on Debian Testing after a
bootstrap, FWIW.  Haven't yet had time to investigate further.

-- 
Basil

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Basil L. Contovounesios]

Basil L. Contovounesios [2021-08-17 20:37 +0100] wrote:

> Lars Ingebrigtsen [2021-08-16 13:29 +0200] wrote:
>
>> Alan Mackenzie <acm@muc.de> writes:
>>
>>> For what it's worth, I can't reproduce it on Gentoo.  The check-maybe
>>> just completes normally.
>>
>> And I can't reproduce it either now.  Yesterday, it was totally
>> reproducible on two different machines, but not today.  :-/
>>
>> It still seems to be timing out on Hydra.  Perhaps it's something
>> weirdly timing related?
>
> It's hanged several times for me locally on Debian Testing after a
> bootstrap, FWIW.  Haven't yet had time to investigate further.

I'm able to reproduce the hang in the test
electric-layout-plainer-c-mode-use-c-style with:

  make TEST_LOAD_EL=no test/electric-tests

The hang seems to be happening in c-beginning-of-macro, from the second
call to c-point-syntax in electric-layout-for-c-style-du-jour.

HTH,

-- 
Basil

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Lars Ingebrigtsen]

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> I'm able to reproduce the hang in the test
> electric-layout-plainer-c-mode-use-c-style with:
>
>   make TEST_LOAD_EL=no test/electric-tests

I'm not able to reproduce this here on my two Debian machines -- but I
did see one of these hangs yesterday.  So it's a real heisenhang.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Basil L. Contovounesios]

Lars Ingebrigtsen [2021-08-18 16:48 +0200] wrote:

> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> I'm able to reproduce the hang in the test
>> electric-layout-plainer-c-mode-use-c-style with:
>>
>>   make TEST_LOAD_EL=no test/electric-tests
>
> I'm not able to reproduce this here on my two Debian machines -- but I
> did see one of these hangs yesterday.  So it's a real heisenhang.

Right now it's happening reliably on my Debian machine.  Should it be
tagged as unstable or unconditionally skipped until it's further
debugged?

Thanks,

-- 
Basil

In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars)
 of 2021-08-18 built on tia
Repository revision: 0d5ff75e944e765dce0e3a93ebdefa4fb6d5f356
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Debian GNU/Linux 11 (bullseye)

Configured using:
 'configure 'CC=ccache gcc' 'CFLAGS=-Og -ggdb' --config-cache
 --prefix=/home/blc/.local --enable-checking=structs
 --with-x-toolkit=lucid --with-file-notification=yes --with-x'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS
X11 XAW3D XDBE XIM XPM LUCID ZLIB

Important settings:
  value of $LANG: en_IE.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Alan Mackenzie]

Hello, Basi.

On Wed, Aug 18, 2021 at 01:02:52 +0100, Basil L. Contovounesios wrote:
> Basil L. Contovounesios [2021-08-17 20:37 +0100] wrote:

> > Lars Ingebrigtsen [2021-08-16 13:29 +0200] wrote:

> >> Alan Mackenzie <acm@muc.de> writes:

> >>> For what it's worth, I can't reproduce it on Gentoo.  The check-maybe
> >>> just completes normally.

> >> And I can't reproduce it either now.  Yesterday, it was totally
> >> reproducible on two different machines, but not today.  :-/

> >> It still seems to be timing out on Hydra.  Perhaps it's something
> >> weirdly timing related?

> > It's hanged several times for me locally on Debian Testing after a
> > bootstrap, FWIW.  Haven't yet had time to investigate further.

> I'm able to reproduce the hang in the test
> electric-layout-plainer-c-mode-use-c-style with:

>   make TEST_LOAD_EL=no test/electric-tests

> The hang seems to be happening in c-beginning-of-macro, from the second
> call to c-point-syntax in electric-layout-for-c-style-du-jour.

I can't reproduce the hang with your recipe, either.  For what it's
worth, I'm running a pure 64-bit AMD-Ryzen Gentoo Gnu/Linux system, with
the following Emacs configuration:

Configured using:
 'configure --with-gif=no --with-tiff=no --with-gpm
 --with-native-compilation'

Configured features:
ACL CAIRO DBUS FREETYPE GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG
SECCOMP SOUND THREADS TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB

> HTH,

Maybe I'll try configuring with some of the options you've been using
(that you reported in a later post).

> -- 
> Basil

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Alan Mackenzie]

Hello again, Basil.

On Wed, Aug 18, 2021 at 17:37:25 +0000, Alan Mackenzie wrote:
> On Wed, Aug 18, 2021 at 01:02:52 +0100, Basil L. Contovounesios wrote:
> > Basil L. Contovounesios [2021-08-17 20:37 +0100] wrote:

[ .... ]

> > > It's hanged several times for me locally on Debian Testing after a
> > > bootstrap, FWIW.  Haven't yet had time to investigate further.

> > I'm able to reproduce the hang in the test
> > electric-layout-plainer-c-mode-use-c-style with:

> >   make TEST_LOAD_EL=no test/electric-tests

> > The hang seems to be happening in c-beginning-of-macro, from the second
> > call to c-point-syntax in electric-layout-for-c-style-du-jour.

> I can't reproduce the hang with your recipe, either.  For what it's
> worth, I'm running a pure 64-bit AMD-Ryzen Gentoo Gnu/Linux system, with
> the following Emacs configuration:

> Configured using:
>  'configure --with-gif=no --with-tiff=no --with-gpm
>  --with-native-compilation'

> Configured features:
> ACL CAIRO DBUS FREETYPE GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
> LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG
> SECCOMP SOUND THREADS TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB

> > HTH,

> Maybe I'll try configuring with some of the options you've been using
> (that you reported in a later post).

To my above configuration, I added --enable-checking=structs, and with
that I can reproduce the hang using your recipe above.

But with TEST_LOAD_EL=yes, the test runs to completion.  This suggests
there is some bug in the compilation of some .el file -
electric-test.el, perhaps?  Are we talking about a .elc or a .eln here?

> > -- 
> > Basil

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Alan Mackenzie]

Hello, Basil.

On Wed, Aug 18, 2021 at 19:20:39 +0000, Alan Mackenzie wrote:
> On Wed, Aug 18, 2021 at 17:37:25 +0000, Alan Mackenzie wrote:
> > On Wed, Aug 18, 2021 at 01:02:52 +0100, Basil L. Contovounesios wrote:
> > > Basil L. Contovounesios [2021-08-17 20:37 +0100] wrote:

> [ .... ]

> > > > It's hanged several times for me locally on Debian Testing after
> > > > a bootstrap, FWIW.  Haven't yet had time to investigate further.

> > > I'm able to reproduce the hang in the test
> > > electric-layout-plainer-c-mode-use-c-style with:

> > >   make TEST_LOAD_EL=no test/electric-tests

> > > The hang seems to be happening in c-beginning-of-macro, from the
> > > second call to c-point-syntax in
> > > electric-layout-for-c-style-du-jour.

> > I can't reproduce the hang with your recipe, either.  For what it's
> > worth, I'm running a pure 64-bit AMD-Ryzen Gentoo Gnu/Linux system,
> > with the following Emacs configuration:

> > Configured using: 'configure --with-gif=no --with-tiff=no --with-gpm
> > --with-native-compilation'

> > Configured features:
> > ACL CAIRO DBUS FREETYPE GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
> > LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG
> > SECCOMP SOUND THREADS TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB

> > > HTH,

> > Maybe I'll try configuring with some of the options you've been using
> > (that you reported in a later post).

> To my above configuration, I added --enable-checking=structs, and with
> that I can reproduce the hang using your recipe above.

> But with TEST_LOAD_EL=yes, the test runs to completion.  This suggests
> there is some bug in the compilation of some .el file -
> electric-test.el, perhaps?  Are we talking about a .elc or a .eln here?

You say c-beginning-of-macro seems to be hanging.  js.el advises
c-beginning-of-macro (along with two other CC Mode functions), and this
may have something to do with it.

At least, if I comment out all the lines in test/lisp/electric-tests.el
with "js" in them (apart from the first occurrence, where one just
comments out "js-mode" from the line), then the hang doesn't happen.

Something to think about.

> > > -- 
> > > Basil

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Basil L. Contovounesios]

Alan Mackenzie [2021-08-18 20:47 +0000] wrote:

>> To my above configuration, I added --enable-checking=structs, and with
>> that I can reproduce the hang using your recipe above.
>
>> But with TEST_LOAD_EL=yes, the test runs to completion.  This suggests
>> there is some bug in the compilation of some .el file -
>> electric-test.el, perhaps?  Are we talking about a .elc or a .eln here?
>
> You say c-beginning-of-macro seems to be hanging.

Yes, that's as deep as I got with print debugging before calling it a
night.

> js.el advises c-beginning-of-macro (along with two other CC Mode
> functions), and this may have something to do with it.
>
> At least, if I comment out all the lines in test/lisp/electric-tests.el
> with "js" in them (apart from the first occurrence, where one just
> comments out "js-mode" from the line), then the hang doesn't happen.
>
> Something to think about.

Indeed, if I comment out all the js-mode-related
define-electric-pair-test forms, as well as the js-mode inside
define-electric-pair-test, then

  make TEST_LOAD_EL=no test/electric-tests

no longer hangs, but electric-pair-open-extra-newline fails.

Tonight, I tried the following approach instead (in an unedited source
tree):

0. C-x p c make TEST_LOAD_EL=no test/electric-tests RET
1. M-! pkill -SIGUSR2 -f ert-run-tests RET

I repeated this a few times, and the *emacs-compilation* buffer reliably
contained the same backtrace:

--8<---------------cut here---------------start------------->8---
Test electric-layout-plainer-c-mode-use-c-style backtrace:
  c-tnt-chng-cleanup(nil [(nil . t) #<buffer *Test buffer (electric-la
  #f(compiled-function () #<bytecode 0x1ce6cae08acf>)()
  c-point-syntax()
  electric-layout-for-c-style-du-jour(123)
  electric-layout-post-self-insert-function-1()
  electric-layout-post-self-insert-function()
  self-insert-command(1 123)
  funcall-interactively(self-insert-command 1 123)
  call-interactively(self-insert-command)
  #f(compiled-function () #<bytecode -0x8b013aec04deab5>)()
  ert--call-with-test-buffer(nil #f(compiled-function () #<bytecode -0
  #f(compiled-function () #<bytecode -0x10479e86da51cfc>)()
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name electric-layout-plainer-c-mode-use-c-
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
  ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
  ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
  eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
  command-line-1(("-L" ":." "-L" "./../../elpa/packages/url-http-ntlm/
  command-line()
  normal-top-level()
Test electric-layout-plainer-c-mode-use-c-style condition:
    Buffer: *Test buffer (electric-layout-plainer-c-mode-use-c-style)*
    (quit)
     QUIT    5/478  electric-layout-plainer-c-mode-use-c-style (54.497779 sec)
--8<---------------cut here---------------end--------------->8---

Sprinkling some prints in c-tnt-chng-cleanup revealed that the following
loop never terminates:

  (let ((undo-in-progress t))
    (while (not (eq (setq buffer-undo-list
                          (primitive-undo 1 buffer-undo-list))
                    saved-undo-list))))

HTH,

-- 
Basil

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Alan Mackenzie]

Hello, Basil.

On Thu, Aug 19, 2021 at 01:15:04 +0100, Basil L. Contovounesios wrote:

[ .... ]

> Tonight, I tried the following approach instead (in an unedited source
> tree):

> 0. C-x p c make TEST_LOAD_EL=no test/electric-tests RET
> 1. M-! pkill -SIGUSR2 -f ert-run-tests RET

> I repeated this a few times, and the *emacs-compilation* buffer reliably
> contained the same backtrace:

> --8<---------------cut here---------------start------------->8---
> Test electric-layout-plainer-c-mode-use-c-style backtrace:
>   c-tnt-chng-cleanup(nil [(nil . t) #<buffer *Test buffer (electric-la
>   #f(compiled-function () #<bytecode 0x1ce6cae08acf>)()
>   c-point-syntax()
>   electric-layout-for-c-style-du-jour(123)
>   electric-layout-post-self-insert-function-1()
>   electric-layout-post-self-insert-function()
>   self-insert-command(1 123)
>   funcall-interactively(self-insert-command 1 123)
>   call-interactively(self-insert-command)
>   #f(compiled-function () #<bytecode -0x8b013aec04deab5>)()
>   ert--call-with-test-buffer(nil #f(compiled-function () #<bytecode -0
>   #f(compiled-function () #<bytecode -0x10479e86da51cfc>)()
>   ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
>   ert-run-test(#s(ert-test :name electric-layout-plainer-c-mode-use-c-
>   ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
>   ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
>   ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
>   ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
>   eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
>   command-line-1(("-L" ":." "-L" "./../../elpa/packages/url-http-ntlm/
>   command-line()
>   normal-top-level()
> Test electric-layout-plainer-c-mode-use-c-style condition:
>     Buffer: *Test buffer (electric-layout-plainer-c-mode-use-c-style)*
>     (quit)
>      QUIT    5/478  electric-layout-plainer-c-mode-use-c-style (54.497779 sec)
> --8<---------------cut here---------------end--------------->8---

> Sprinkling some prints in c-tnt-chng-cleanup revealed that the following
> loop never terminates:

>   (let ((undo-in-progress t))
>     (while (not (eq (setq buffer-undo-list
>                           (primitive-undo 1 buffer-undo-list))
>                     saved-undo-list))))

> HTH,

That helps a great deal, thanks!

The problem is a bug in c-point-syntax.  There, there is
  (i) an invocation of c-save-buffer-state, which binds buffer-undo-list
  to t, followed by
  (ii) an invocation of c-tentative-buffer-changes, which pushes nil onto
  buffer-undo-list (simulating an undo group) giving (nil t).
  (iii) A { is typed into the buffer, giving buffer-undo-list now as
  something like ((5128 . 5129) nil t).
At this point garbage collection occurs.  This strips the tail of
buffer-undo-list, leaving ((5128 . 5129)).
  (iv) In c-tnt-chng-cleanup, primitive-undo is repeated infinitely,
  since buffer-undo-list will never become the expected value (nil t).

The problem would appear to be the invalid value ((5128 . 5129) nil t) in
buffer-undo-list.

I'll see what I can do about this tonight.

> -- 
> Basil

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Alan Mackenzie]

Hello, Lars and Basil.

On Fri, Aug 20, 2021 at 10:48:04 +0000, Alan Mackenzie wrote:
[ .... ]

> The problem is a bug in c-point-syntax.  There, there is
>   (i) an invocation of c-save-buffer-state, which binds buffer-undo-list
>   to t, followed by
>   (ii) an invocation of c-tentative-buffer-changes, which pushes nil onto
>   buffer-undo-list (simulating an undo group) giving (nil t).
>   (iii) A { is typed into the buffer, giving buffer-undo-list now as
>   something like ((5128 . 5129) nil t).
> At this point garbage collection occurs.  This strips the tail of
> buffer-undo-list, leaving ((5128 . 5129)).
>   (iv) In c-tnt-chng-cleanup, primitive-undo is repeated infinitely,
>   since buffer-undo-list will never become the expected value (nil t).

> The problem would appear to be the invalid value ((5128 . 5129) nil t) in
> buffer-undo-list.

> I'll see what I can do about this tonight.

I've just committed a patch to master which I think fixes the problem.

Thanks especially to Basil for exceptionally helpful debugging info.

> > -- 
> > Basil

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Basil L. Contovounesios]

Alan Mackenzie [2021-08-20 21:20 +0000] wrote:

> On Fri, Aug 20, 2021 at 10:48:04 +0000, Alan Mackenzie wrote:
>
>> The problem is a bug in c-point-syntax.  There, there is
>>   (i) an invocation of c-save-buffer-state, which binds buffer-undo-list
>>   to t, followed by
>>   (ii) an invocation of c-tentative-buffer-changes, which pushes nil onto
>>   buffer-undo-list (simulating an undo group) giving (nil t).
>>   (iii) A { is typed into the buffer, giving buffer-undo-list now as
>>   something like ((5128 . 5129) nil t).
>> At this point garbage collection occurs.  This strips the tail of
>> buffer-undo-list, leaving ((5128 . 5129)).
>>   (iv) In c-tnt-chng-cleanup, primitive-undo is repeated infinitely,
>>   since buffer-undo-list will never become the expected value (nil t).
>
>> The problem would appear to be the invalid value ((5128 . 5129) nil t) in
>> buffer-undo-list.
>
>> I'll see what I can do about this tonight.
>
> I've just committed a patch to master which I think fixes the problem.

Thanks!  That indeed fixes the hang here.

If it stops the hangs from happening on Hydra as well, then the relevant
electric-tests will no longer need to be skipped there.

I see only one minor issue with the patch: it introduces a use of the
macro c-benign-error before its definition, which gives rise to a
byte-compiler warning.  I would have moved the macro's definition
myself, but I see the file is organised in a particular way, so I leave
that to you.

Thanks,

-- 
Basil

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Alan Mackenzie]

Hello, Basil.

On Fri, Aug 20, 2021 at 23:43:30 +0100, Basil L. Contovounesios wrote:
> Alan Mackenzie [2021-08-20 21:20 +0000] wrote:

[ .... ]

> > I've just committed a patch to master which I think fixes the problem.

> Thanks!  That indeed fixes the hang here.

> If it stops the hangs from happening on Hydra as well, then the relevant
> electric-tests will no longer need to be skipped there.

> I see only one minor issue with the patch: it introduces a use of the
> macro c-benign-error before its definition, which gives rise to a
> byte-compiler warning.  I would have moved the macro's definition
> myself, but I see the file is organised in a particular way, so I leave
> that to you.

Sorry about that.  I completely missed that warning message (which
perhaps ought to be an error, since it compiles a function call instead
of expanding the macro).

I've moved the macro to earlier on in the file.  No big deal.  I've
committed the change, and it should be OK now.

> Thanks,

Thank you!

> -- 
> Basil

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Eli Zaretskii]

> Date: Fri, 20 Aug 2021 21:20:49 +0000
> From: Alan Mackenzie <acm@muc.de>
> Cc: Glenn Morris <rgm@gnu.org>, emacs-devel@gnu.org
> 
> I've just committed a patch to master which I think fixes the problem.

Thanks, but this triggers a byte-compilation warning:

  In c-benign-error:
  progmodes/cc-defs.el:1046:11: Warning: macro `c-benign-error' defined too late

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Alan Mackenzie]

On Sat, Aug 21, 2021 at 10:15:09 +0300, Eli Zaretskii wrote:
> > Date: Fri, 20 Aug 2021 21:20:49 +0000
> > From: Alan Mackenzie <acm@muc.de>
> > Cc: Glenn Morris <rgm@gnu.org>, emacs-devel@gnu.org

Hello, Eli.

> > I've just committed a patch to master which I think fixes the problem.

> Thanks, but this triggers a byte-compilation warning:

>   In c-benign-error:
>   progmodes/cc-defs.el:1046:11: Warning: macro `c-benign-error'
>   defined too late

Sorry, I just missed that warning.  I've committed a correction now, so
things should now be OK.

The bug in fact had nothing to do with multi-line strings, and had been
in place for many years.  Only a garbage collection in the "wrong" place
triggered it.

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Eli Zaretskii]

> Date: Sat, 21 Aug 2021 10:00:20 +0000
> Cc: contovob@tcd.ie, larsi@gnus.org, rgm@gnu.org, emacs-devel@gnu.org
> From: Alan Mackenzie <acm@muc.de>
> 
> >   In c-benign-error:
> >   progmodes/cc-defs.el:1046:11: Warning: macro `c-benign-error'
> >   defined too late
> 
> Sorry, I just missed that warning.  I've committed a correction now, so
> things should now be OK.

Thanks.

Re: master c4d34d2: CC Mode: Enhance C++ Mode raw strings to multi-line strings for any language

[Basil L. Contovounesios]

Alan Mackenzie [2021-08-18 19:20 +0000] wrote:

>> I can't reproduce the hang with your recipe, either.  For what it's
>> worth, I'm running a pure 64-bit AMD-Ryzen Gentoo Gnu/Linux system, with
>> the following Emacs configuration:
>
>> Configured using:
>>  'configure --with-gif=no --with-tiff=no --with-gpm
>>  --with-native-compilation'
>
>> Configured features:
>> ACL CAIRO DBUS FREETYPE GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
>> LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG
>> SECCOMP SOUND THREADS TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB
>
>> > HTH,
>
>> Maybe I'll try configuring with some of the options you've been using
>> (that you reported in a later post).
>
> To my above configuration, I added --enable-checking=structs, and with
> that I can reproduce the hang using your recipe above.

Huh, I wonder how that could possibly be making a difference here.

> But with TEST_LOAD_EL=yes, the test runs to completion.  This suggests
> there is some bug in the compilation of some .el file -
> electric-test.el, perhaps?  Are we talking about a .elc or a .eln here?

I haven't configured this Emacs with native compilation (I've done that
in a separate Git worktree), so this shouldn't have anything to do with
.eln files.

Thanks,

-- 
Basil