From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: scratch/ns/refactor 06d9e72 5/6: Move NS port toolbar handling to the window Date: Thu, 24 Jun 2021 15:05:43 +0100 Message-ID: References: <20210620155625.12886.44156@vcs0.savannah.gnu.org> <20210620155629.258B620B76@vcs0.savannah.gnu.org> <87h7hosqob.fsf@gmail.com> <874kdosk69.fsf@gmail.com> <87zgvfqs8f.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33051"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 24 16:06:36 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwQ04-0008LN-5l for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Jun 2021 16:06:36 +0200 Original-Received: from localhost ([::1]:51960 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwQ03-00056x-5d for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Jun 2021 10:06:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwPzT-0004Nr-NO for emacs-devel@gnu.org; Thu, 24 Jun 2021 10:05:59 -0400 Original-Received: from outbound.soverin.net ([2a01:4f8:fff0:65::8:228]:38151) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwPzR-00035W-2B for emacs-devel@gnu.org; Thu, 24 Jun 2021 10:05:59 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id A7B05B47; Thu, 24 Jun 2021 14:05:46 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1624543546; bh=I/dwnowPMAdoM08HNZVeacv43bHmo7Vk73uCGBZZkKE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fMNqHAi3RJaeaepBZqP7PejuCdzBKA7sjdZ/t2v9kcb3b6K0pjqQjE1g1eHYFgGTY m07yJRAGEyP6WjaOJdh26nS8ZhHgJrCgHDipxnWQR82R+7MCRzM5LvaiTme7EnZDel RWDiQ46N9OwCQCoQuzimcgUf6d6H9Khyw9WYVe3XZjnGQguaqApSCB9bFrotv9Y4e5 TPAEeC7aDW+OiQj536i5lwp8eL0xhtsZslZEcKmNyBx56zIH1u26wPeqG+Z2OBoecA G64MncGkPZM2mRp2hR21axrrpmYeq9a21xGgNe5WvAD2qtpqzSObVWUuXePWkpF+JG t5psXhAClUazg== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.94.2) (envelope-from ) id 1lwPzD-001Gmx-QT; Thu, 24 Jun 2021 15:05:43 +0100 Mail-Followup-To: Alan Third , Robert Pluim , emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: <87zgvfqs8f.fsf@gmail.com> Received-SPF: pass client-ip=2a01:4f8:fff0:65::8:228; envelope-from=alan@idiocy.org; helo=outbound.soverin.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270998 Archived-At: On Thu, Jun 24, 2021 at 03:58:40PM +0200, Robert Pluim wrote: > >>>>> On Wed, 23 Jun 2021 17:06:12 +0100, Alan Third said: > > Alan> On Wed, Jun 23, 2021 at 04:57:34PM +0200, Robert Pluim wrote: > >> >>>>> On Wed, 23 Jun 2021 15:27:42 +0100, Alan Third said: > >> >> The second frame has the tool-bar disabled, but unlike master the > >> >> frame height is greater than the initial frame, and the frame title is > >> >> bigger as well, as if its height had not been adjusted after removing > >> >> the tool-bar. > >> > Alan> What's happening is that the toolbar is set to be visible, but it has > Alan> nothing in it, so it shrinks to the toolbar's minimum height. > >> > Alan> Can you please try the following, I think it should sort it: > >> > >> Youʼre on a roll here Alan. That fixes it. > > Alan> I've pushed a fix if you want to give it a go. > > Alan> Plus another couple of patches which probably break something else. > > I guess that using the menus being dodgy when displaying a > tramp-visited buffer is normal? Emacs appears to be busy-looping, I > can provide backtrace if you want. > > I never use the menus, so itʼs not a big deal to me. No, that's not normal... Well, it kind of is... For some reason tramp + menus causes problems. It may be because we have to run a whole bunch of lisp stuff in the NS run loop while updating the contents of the menus before opening them and that interacts in some way with the tramp external processes' IO. I've no idea why. It may ultimately make more sense to take a copy of the menu structure when Emacs core updates the menus and then update them from that... If you revert 99adf4b2af is the menu behaviour better, worse or the same? -- Alan Third