From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: src/nsterm.m: fix window tabbing on macOS Date: Sun, 6 Jun 2021 19:56:58 +0100 Message-ID: References: <4cf0b73bcefc7d159881d368b3a4b7f5@purelymail.com> <228099F1-BAB6-4E3A-AD0F-FB4282817CEB@bydasein.com> <83mts3ikoa.fsf@gnu.org> <2C0F466D-0FEB-439B-8049-D8EA5FC0B21B@bydasein.com> <8CCF969D-32AF-4542-8838-21DF4AA45523@yasufuku.dev> <9814156B-6B84-4CFA-9F5F-A1B05F19826F@bydasein.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5038"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org, Naofumi Yasufuku To: "Paul W. Rankin" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 06 20:59:34 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpxzi-000195-OE for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Jun 2021 20:59:34 +0200 Original-Received: from localhost ([::1]:45200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpxzh-0006Lm-PC for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Jun 2021 14:59:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpxzE-0005e5-MG for emacs-devel@gnu.org; Sun, 06 Jun 2021 14:59:04 -0400 Original-Received: from ip6-2001-8b0-3f8-8129-8531-1ab5-b1d8-51e6.holly.idiocy.org ([2001:8b0:3f8:8129:8531:1ab5:b1d8:51e6]:50762 helo=breton.holly.idiocy.org) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpxzC-0002cj-Fq; Sun, 06 Jun 2021 14:59:04 -0400 Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 8FB74202C67F56; Sun, 6 Jun 2021 19:56:58 +0100 (BST) Mail-Followup-To: Alan Third , "Paul W. Rankin" , Naofumi Yasufuku , Eli Zaretskii , emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: <9814156B-6B84-4CFA-9F5F-A1B05F19826F@bydasein.com> Received-SPF: none client-ip=2001:8b0:3f8:8129:8531:1ab5:b1d8:51e6; envelope-from=alan@breton.holly.idiocy.org; helo=breton.holly.idiocy.org X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, KHOP_HELO_FCRDNS=0.398, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270497 Archived-At: On Sun, Jun 06, 2021 at 10:19:57PM +1000, Paul W. Rankin wrote: > > > On 6 Jun 2021, at 9:36 pm, Alan Third wrote: > > > > On Sun, Jun 06, 2021 at 07:07:53PM +0900, Naofumi Yasufuku wrote: > >> > >> I found the following issues with this macOS native tab commit. > >> Does anyone else encounter the same problems? > >> > >> 1) Frame height increases (even if frame-inhibit-implied-resize is t). > >> attachment: > >> 01_macOS-tab-issue-increases-height.gif > >> 01_macOS-tab-issue-increases-height-2.gif … (sets frame-inhibit-implied-resize t) > > > > Strangely I don't see this. The frame stays the same height... > > Alan did you see my video of this in action? > https://f002.backblazeb2.com/file/pwr-share/emacs_nsterm.mov Yeah, I was wrong, it is there and it's very annoying. I think there's a mismatch between the calculation of the height of the content and the actual height of the content. But if it's that I have no idea why it disappears when the toolbar is turned off, because the calculation should still be wrong. > >> 2) New tab name is ‘emacs’ instead of buffer name. > >> (even if C-x 5 C-f `find-file-other-frame’) > >> attachment: > >> 02_macOS-tab-issue-odd-tab-name.gif > > > > It turns out that when multiple NSViews are put into one NSWindow > > using tabs, AppKit doesn't bother telling all the views to update > > themselves when the window changes, it appears to only message the > > currently visible one. This is a problem. > > > > The tab name issue can be sorted with this change: > > ... > > Interestingly this only happens with tool-bar-mode on. With eamcs -Q > (tool-bar-mode 0) new frames/tabs get the correct name. Which makes > me wonder if it's another case of some code somewhere interfering? They don't here. The non-selected frame ends up with the wrong name whether the toolbar is on or off. > >> 3) Tabs are not shown in fullscreen. > >> attachment: > >> 03_macOS-tab-fullscreen-expected-textedit.gif. .. e.g. macOS Test Edit app > >> 03_macOS-tab-issue-fullscreen-emacs.gif > > Yeah we're considering this a separate nice-to-have, right? Yeah, the tabs work exactly as I'd expect them to in fullscreen given the way fullscreen works just now. I have to say I've spent most of the afternoon on this and I'm no closer to a solution to the height changing thing, so I'm tempted to revert the commit, or put it behind a build flag or something until we have a better solution. -- Alan Third