unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: "Paul W. Rankin" <pwr@bydasein.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
	emacs-devel@gnu.org, Naofumi Yasufuku <naofumi@yasufuku.dev>
Subject: Re: src/nsterm.m: fix window tabbing on macOS
Date: Sun, 6 Jun 2021 19:56:58 +0100	[thread overview]
Message-ID: <YL0aeorbXP6p+uZ3@breton.holly.idiocy.org> (raw)
In-Reply-To: <9814156B-6B84-4CFA-9F5F-A1B05F19826F@bydasein.com>

On Sun, Jun 06, 2021 at 10:19:57PM +1000, Paul W. Rankin wrote:
> 
> > On 6 Jun 2021, at 9:36 pm, Alan Third <alan@idiocy.org> wrote:
> > 
> > On Sun, Jun 06, 2021 at 07:07:53PM +0900, Naofumi Yasufuku wrote:
> >> 
> >> I found the following issues with this macOS native tab commit.
> >> Does anyone else encounter the same problems?
> >> 
> >> 1) Frame height increases (even if frame-inhibit-implied-resize is t).
> >>  attachment:
> >>    01_macOS-tab-issue-increases-height.gif
> >>    01_macOS-tab-issue-increases-height-2.gif … (sets frame-inhibit-implied-resize t)
> > 
> > Strangely I don't see this. The frame stays the same height...
> 
> Alan did you see my video of this in action?
> https://f002.backblazeb2.com/file/pwr-share/emacs_nsterm.mov

Yeah, I was wrong, it is there and it's very annoying. I think there's
a mismatch between the calculation of the height of the content and
the actual height of the content. But if it's that I have no idea why
it disappears when the toolbar is turned off, because the calculation
should still be wrong.

> >> 2) New tab name is ‘emacs’ instead of buffer name.
> >>    (even if C-x 5 C-f `find-file-other-frame’)
> >>  attachment:
> >>    02_macOS-tab-issue-odd-tab-name.gif
> > 
> > It turns out that when multiple NSViews are put into one NSWindow
> > using tabs, AppKit doesn't bother telling all the views to update
> > themselves when the window changes, it appears to only message the
> > currently visible one. This is a problem.
> > 
> > The tab name issue can be sorted with this change:
> > ...
> 
> Interestingly this only happens with tool-bar-mode on. With eamcs -Q
> (tool-bar-mode 0) new frames/tabs get the correct name. Which makes
> me wonder if it's another case of some code somewhere interfering?

They don't here. The non-selected frame ends up with the wrong name
whether the toolbar is on or off.

> >> 3) Tabs are not shown in fullscreen.
> >>  attachment:
> >>    03_macOS-tab-fullscreen-expected-textedit.gif. .. e.g. macOS Test Edit app
> >>    03_macOS-tab-issue-fullscreen-emacs.gif
> 
> Yeah we're considering this a separate nice-to-have, right?

Yeah, the tabs work exactly as I'd expect them to in fullscreen given
the way fullscreen works just now.

I have to say I've spent most of the afternoon on this and I'm no
closer to a solution to the height changing thing, so I'm tempted to
revert the commit, or put it behind a build flag or something until we
have a better solution.
-- 
Alan Third



  reply	other threads:[~2021-06-06 18:56 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-08  9:26 src/nsterm.m: fix window tabbing on macOS Paul W. Rankin via Emacs development discussions.
2021-05-08 11:21 ` Alan Third
2021-05-08 12:27   ` Paul W. Rankin via Emacs development discussions.
2021-05-08 12:35     ` Paul W. Rankin via Emacs development discussions.
2021-05-10 19:53     ` Alan Third
2021-05-11  5:45       ` Paul W. Rankin via Emacs development discussions.
2021-05-11 19:20         ` chad
2021-05-12  9:47           ` Paul W. Rankin via Emacs development discussions.
2021-05-12 21:23         ` Alan Third
2021-05-13  5:46           ` Paul W. Rankin via Emacs development discussions.
2021-05-13 21:05             ` Alan Third
2021-05-16  9:16               ` Paul W. Rankin via Emacs development discussions.
2021-05-26 19:56                 ` Alan Third
2021-05-27 11:06                   ` Andrii Kolomoiets
2021-05-28  8:26                     ` martin rudalics
2021-05-28  8:28                       ` Paul W. Rankin via Emacs development discussions.
2021-05-28  8:36                         ` martin rudalics
2021-05-28  8:54                           ` Alan Third
2021-06-06  4:09                             ` Paul W. Rankin via Emacs development discussions.
2021-06-06  7:43                               ` martin rudalics
2021-05-28  9:07                           ` Andrii Kolomoiets
2021-05-28  9:21                             ` martin rudalics
2021-05-28  9:37                               ` Paul W. Rankin via Emacs development discussions.
2021-05-28  9:51                                 ` martin rudalics
2021-05-28 14:33                                   ` Paul W. Rankin via Emacs development discussions.
2021-05-28 20:52                                     ` Andrii Kolomoiets
2021-06-05 20:58                   ` Alan Third
2021-06-06  4:01                     ` Paul W. Rankin via Emacs development discussions.
2021-06-06  6:14                       ` Eli Zaretskii
2021-06-06  6:48                         ` Paul W. Rankin via Emacs development discussions.
2021-06-06  9:13                           ` Alan Third
     [not found]                             ` <8CCF969D-32AF-4542-8838-21DF4AA45523@yasufuku.dev>
2021-06-06 11:36                               ` Alan Third
2021-06-06 12:19                                 ` Paul W. Rankin via Emacs development discussions.
2021-06-06 18:56                                   ` Alan Third [this message]
2021-06-07  0:27                                     ` Paul W. Rankin via Emacs development discussions.
2021-06-07 22:13                                       ` Alan Third
2021-06-08  7:32                                         ` Paul W. Rankin via Emacs development discussions.
2021-06-08  8:59                                           ` Eli Zaretskii
2021-06-09  8:35                                         ` martin rudalics
2021-06-09  8:48                                           ` Alan Third
2021-06-09 12:20                                             ` martin rudalics
2021-06-09 12:29                                               ` Alan Third
     [not found] <65f1-60bcfd80-157-23301c40@168015757>
2021-06-07  0:11 ` Paul W. Rankin via Emacs development discussions.
2021-06-07 21:57   ` Alan Third

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YL0aeorbXP6p+uZ3@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=naofumi@yasufuku.dev \
    --cc=pwr@bydasein.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).