From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: src/nsterm.m: fix window tabbing on macOS Date: Thu, 13 May 2021 22:05:00 +0100 Message-ID: References: <9cdf9d6dc55ccd4894d758d3237b0be2@purelymail.com> <03FB7137-A02D-4B94-AF1F-8B7E84DEF5DB@bydasein.com> <39fa782b82e274d3e9c40e934df89d68@purelymail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1787"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: "Paul W. Rankin" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 13 23:06:55 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lhIXn-0000Ls-07 for ged-emacs-devel@m.gmane-mx.org; Thu, 13 May 2021 23:06:55 +0200 Original-Received: from localhost ([::1]:43506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhIXm-0004PE-1u for ged-emacs-devel@m.gmane-mx.org; Thu, 13 May 2021 17:06:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhIW8-00026Y-AU for emacs-devel@gnu.org; Thu, 13 May 2021 17:05:13 -0400 Original-Received: from outbound.soverin.net ([2a01:4f8:fff0:2d:8::218]:60545) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhIW4-0003dr-Ap for emacs-devel@gnu.org; Thu, 13 May 2021 17:05:11 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id A0C7A60A33; Thu, 13 May 2021 21:05:04 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.142]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1620939904; bh=Lt0GnbbGvIIkIOBUJF/UsKyNIOVrmnFyOl0yGoBgDlg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DXjSSPaJ4ADGrjTqMO5AyXjJqZX/2PklBy9IHBnwMrPqQ7wLanZejNJUquz2ZkL80 OWXVdJmKJCM0J7YckR1owhcbK8I31KwpbiMm9POD1ooMhCrg5qXU9lqkZYnanMX6If a5bndyXNCidWRpiFsAT47YXzLWkuV5SxzuWfG7dfakbZJYE+iasoS4vrLk81RDQwq/ xP6TUwDB7gUcasS3lRJSJs6duTuPt83g/x+yNGJojGjkKNo1Lwdu9hghnTOS68Gito AerEwHZMZJUwTnyAY8dISF9ySROLt1a4i2g/zwBn+juAm2sD+Z+8QelmtrcnQ5JWuw Wns5DfiuoMDCA== Original-Received: from alan by faroe.holly.idiocy.org with local (Exim 4.94) (envelope-from ) id 1lhIVw-000351-U5; Thu, 13 May 2021 22:05:00 +0100 Mail-Followup-To: Alan Third , "Paul W. Rankin" , emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=2a01:4f8:fff0:2d:8::218; envelope-from=alan@idiocy.org; helo=outbound.soverin.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269258 Archived-At: On Thu, May 13, 2021 at 03:46:54PM +1000, Paul W. Rankin via Emacs development discussions. wrote: > On 2021-05-13 07:23, Alan Third wrote: > > > The only thing that's a little weird is that this tab bar is not > > > visible > > > when in full screen, requiring moving the mouse up to reveal it. It > > > would > > > clearer what's happening if the tab bar behaved more like > > > Terminal.app when > > > in full screen: opening more than a single tab keeps the tab bar > > > visible (in > > > full screen or windowed). > > > > Isn't that how all the window chrome works in fullscreen? Do we do > > some special thing to hide the toolbar? Perhaps we should rethink that > > (although enough people run in fullscreen all the time that I suspect > > that change would be genuinely contentious). > > You're right and I can't find another macOS app with a tab bar that behaves > the way Emacs.app does, so I gotta assume there is something somewhere > overriding the Cocoa window manager behaviour. But I'm really only qualified > to guess; I looked through nsterm.m and changed a few suspected BOOL values > and recompiled a few times but nothing had an effect on the hidden tab bar. > > Relatedly, tool-bar-mode is in the same boat; hidden in full screen, but > probably shouldn't be. Search in nsterm.m for "autohide", there are a couple of places where hiding various bits and bobs is done, all related to fullscreen afaict. I'm not on a Mac just now or I'd try removing them all to see what it does. As I said, I suspect this change could be contentious, so we may want to provide a variable to enable or disable it. > > If you just remove it completely does it do anything different from > > your patch? > > It appears that removing the code has the same effect as > NSWindowTabbingModeAutomatic. I like minimalism so happy to just remove it. 👍 -- Alan Third