unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: stefan@marxist.se, emacs-devel@gnu.org
Subject: Re: Yikes!  easy-menu-add is suddenly compiled to `ignore', without any warning.
Date: Wed, 7 Apr 2021 12:32:08 +0000	[thread overview]
Message-ID: <YG2mSKDrIjO1WhEl@ACM> (raw)
In-Reply-To: <8335w2b9v6.fsf@gnu.org>

Hello, Eli.

On Wed, Apr 07, 2021 at 14:41:01 +0300, Eli Zaretskii wrote:
> > Date: Wed, 7 Apr 2021 09:29:38 +0000
> > From: Alan Mackenzie <acm@muc.de>

> > Hello, Emacs and Stefan K.

> > In Emacs 28, easy-menu-add is now compiled to `ignore'.  This isn't
> > friendly, particularly as in Emacs 27.2 and earlier, it just worked,
> > without any warnings of impending obsoletion.

> > The warning message Emacs 28.1 gives out is particularly unfriendly and
> > unhelpful.  It looks like this:

> >     cc-mode.el:2591:4: Warning: `easy-menu-add' is an obsolete function
> >     (as of 28.1); use `ignore' instead.

> > Use `ignore' instead?

> easy-menu-add was an alias of 'ignore' since 4 years ago.  How come
> it is suddenly an issue what it is compiled to?  Are you sure the
> issue isn't the obsolescence warning itself? that was indeed added
> last November.

The issue is indeed the warning message, from which I got the impression
that menu functionality had been removed.  The message appeared to be
telling me not to bother about this apparent loss in functionality.

It's a strange thing indeed to suggest using `ignore' in source code,
except for certain specific reasons.  Suggesting total removal of
easy-menu-add, if there is a way of doing that, would be better.

> > Why have we not followed the normal procedure here, by marking the
> > function as obsolete, yet leaving it working, for one or two major
> > versions, and only then removing it?

> It wasn't removed, so the procedure followed here is indeed our usual
> one.

OK.  The warning message was confusing, at least for me.

-- 
Alan Mackenzie (Nuremberg, Germany).



      reply	other threads:[~2021-04-07 12:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07  9:29 Yikes! easy-menu-add is suddenly compiled to `ignore', without any warning Alan Mackenzie
2021-04-07 10:06 ` Stefan Kangas
2021-04-07 11:24   ` Ulrich Mueller
2021-04-07 11:37     ` Eli Zaretskii
2021-04-07 14:14       ` Ulrich Mueller
2021-04-07 14:24         ` Eli Zaretskii
2021-04-07 14:30     ` XEmacs compatibility (was: Yikes! easy-menu-add is suddenly compiled to `ignore', without any warning) Stefan Monnier
2021-04-07 11:58   ` Yikes! easy-menu-add is suddenly compiled to `ignore', without any warning Alan Mackenzie
2021-04-07 12:43     ` Stefan Kangas
2021-04-07 11:41 ` Eli Zaretskii
2021-04-07 12:32   ` Alan Mackenzie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YG2mSKDrIjO1WhEl@ACM \
    --to=acm@muc.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).