From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Yikes! easy-menu-add is suddenly compiled to `ignore', without any warning. Date: Wed, 7 Apr 2021 11:58:19 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21362"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 07 13:59:06 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lU6pu-0005RK-6S for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Apr 2021 13:59:06 +0200 Original-Received: from localhost ([::1]:44830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lU6pt-0000NL-5U for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Apr 2021 07:59:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46588) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lU6pG-0008No-PS for emacs-devel@gnu.org; Wed, 07 Apr 2021 07:58:28 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:57096 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1lU6pC-0001an-VT for emacs-devel@gnu.org; Wed, 07 Apr 2021 07:58:26 -0400 Original-Received: (qmail 97802 invoked by uid 3782); 7 Apr 2021 11:58:20 -0000 Original-Received: from acm.muc.de (p4fe15d87.dip0.t-ipconnect.de [79.225.93.135]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 07 Apr 2021 13:58:19 +0200 Original-Received: (qmail 18290 invoked by uid 1000); 7 Apr 2021 11:58:19 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267507 Archived-At: Hello, Stefan. First of all, sorry for being so strident in my opening post. I now understand what's happening. On Wed, Apr 07, 2021 at 05:06:04 -0500, Stefan Kangas wrote: > Alan Mackenzie writes: > > In Emacs 28, easy-menu-add is now compiled to `ignore'. This isn't > > friendly, particularly as in Emacs 27.2 and earlier, it just worked, > > without any warnings of impending obsoletion. > What does "working" mean here? No "threatening" warning message. The message I got from that warning message was that it would be necessary to replace easy-menu-add by some other working code, which the message didn't specify. > In Emacs 27.1, I have here: > easy-menu-add is an alias for ‘ignore’ in ‘easymenu.el’. > > Why have we not followed the normal procedure here, by marking the > > function as obsolete, yet leaving it working, for one or two major > > versions, and only then removing it? > It is my understanding that this has followed the normal procedure for > obsoletion. OK, I got confused. I might not be the only one. > > This sudden removal of easy-menu-add will cause unnecessary annoyance > > amongst maintainers whose sources still use it. Even in the Emacs > > sources there are 25 uses of the function. I think I might be right about that point. > This function is only relevant in XEmacs, so if this is important to you > I recommend changing any such call to say: > (when (featurep 'xemacs) > (easy-menu-add foo-menu)) > The Emacs sources should already be updated accordingly. Yes. I'd missed out the -B1 flag in my grep call. :-( > > The warning message Emacs 28.1 gives out is particularly unfriendly and > > unhelpful. It looks like this: > > cc-mode.el:2591:4: Warning: `easy-menu-add' is an obsolete function > > (as of 28.1); use `ignore' instead. > Yes, we could improve that message. > Perhaps it could say: "it is not needed, so just remove it". Maybe it could say something like "which was always a no-op in Emacs", thus reassuring maintainers that they needn't worry about lost menu functionality. -- Alan Mackenzie (Nuremberg, Germany).