From: Alan Mackenzie <firstname.lastname@example.org> To: Stefan Kangas <email@example.com> Cc: firstname.lastname@example.org Subject: Re: Yikes! easy-menu-add is suddenly compiled to `ignore', without any warning. Date: Wed, 7 Apr 2021 11:58:19 +0000 [thread overview] Message-ID: <YG2eW2GpWnXRA5t9@ACM> (raw) In-Reply-To: <CADwFkmnUou3pAhVV3fPvtg6Cby4L3uKt0GMO8Rx2_scEV4-FKA@mail.gmail.com> Hello, Stefan. First of all, sorry for being so strident in my opening post. I now understand what's happening. On Wed, Apr 07, 2021 at 05:06:04 -0500, Stefan Kangas wrote: > Alan Mackenzie <email@example.com> writes: > > In Emacs 28, easy-menu-add is now compiled to `ignore'. This isn't > > friendly, particularly as in Emacs 27.2 and earlier, it just worked, > > without any warnings of impending obsoletion. > What does "working" mean here? No "threatening" warning message. The message I got from that warning message was that it would be necessary to replace easy-menu-add by some other working code, which the message didn't specify. > In Emacs 27.1, I have here: > easy-menu-add is an alias for ‘ignore’ in ‘easymenu.el’. > > Why have we not followed the normal procedure here, by marking the > > function as obsolete, yet leaving it working, for one or two major > > versions, and only then removing it? > It is my understanding that this has followed the normal procedure for > obsoletion. OK, I got confused. I might not be the only one. > > This sudden removal of easy-menu-add will cause unnecessary annoyance > > amongst maintainers whose sources still use it. Even in the Emacs > > sources there are 25 uses of the function. I think I might be right about that point. > This function is only relevant in XEmacs, so if this is important to you > I recommend changing any such call to say: > (when (featurep 'xemacs) > (easy-menu-add foo-menu)) > The Emacs sources should already be updated accordingly. Yes. I'd missed out the -B1 flag in my grep call. :-( > > The warning message Emacs 28.1 gives out is particularly unfriendly and > > unhelpful. It looks like this: > > cc-mode.el:2591:4: Warning: `easy-menu-add' is an obsolete function > > (as of 28.1); use `ignore' instead. > Yes, we could improve that message. > Perhaps it could say: "it is not needed, so just remove it". Maybe it could say something like "which was always a no-op in Emacs", thus reassuring maintainers that they needn't worry about lost menu functionality. -- Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2021-04-07 11:58 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-07 9:29 Alan Mackenzie 2021-04-07 10:06 ` Stefan Kangas 2021-04-07 11:24 ` Ulrich Mueller 2021-04-07 11:37 ` Eli Zaretskii 2021-04-07 14:14 ` Ulrich Mueller 2021-04-07 14:24 ` Eli Zaretskii 2021-04-07 14:30 ` XEmacs compatibility (was: Yikes! easy-menu-add is suddenly compiled to `ignore', without any warning) Stefan Monnier 2021-04-07 11:58 ` Alan Mackenzie [this message] 2021-04-07 12:43 ` Yikes! easy-menu-add is suddenly compiled to `ignore', without any warning Stefan Kangas 2021-04-07 11:41 ` Eli Zaretskii 2021-04-07 12:32 ` Alan Mackenzie
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.gnu.org/software/emacs/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YG2eW2GpWnXRA5t9@ACM \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: Yikes'\!' easy-menu-add is suddenly compiled to `ignore'\'', without any warning.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
unofficial mirror of email@example.com This inbox may be cloned and mirrored by anyone: git clone --mirror https://yhetil.org/emacs-devel/0 emacs-devel/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 emacs-devel emacs-devel/ https://yhetil.org/emacs-devel \ firstname.lastname@example.org public-inbox-index emacs-devel Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.yhetil.org/yhetil.emacs.devel nntp://news.gmane.io/gmane.emacs.devel code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs.git AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git