From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Yikes! easy-menu-add is suddenly compiled to `ignore', without any warning. Date: Wed, 7 Apr 2021 09:29:38 +0000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13875"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org, Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 07 11:30:36 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lU4WC-0003Wq-JK for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Apr 2021 11:30:36 +0200 Original-Received: from localhost ([::1]:56288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lU4WB-0006qY-IG for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Apr 2021 05:30:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lU4VM-0006Q5-2e for emacs-devel@gnu.org; Wed, 07 Apr 2021 05:29:44 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:53470 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1lU4VJ-00065O-Uf for emacs-devel@gnu.org; Wed, 07 Apr 2021 05:29:43 -0400 Original-Received: (qmail 92640 invoked by uid 3782); 7 Apr 2021 09:29:39 -0000 Original-Received: from acm.muc.de (p4fe15d87.dip0.t-ipconnect.de [79.225.93.135]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 07 Apr 2021 11:29:38 +0200 Original-Received: (qmail 5112 invoked by uid 1000); 7 Apr 2021 09:29:38 -0000 Content-Disposition: inline X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267500 Archived-At: Hello, Emacs and Stefan K. In Emacs 28, easy-menu-add is now compiled to `ignore'. This isn't friendly, particularly as in Emacs 27.2 and earlier, it just worked, without any warnings of impending obsoletion. The warning message Emacs 28.1 gives out is particularly unfriendly and unhelpful. It looks like this: cc-mode.el:2591:4: Warning: `easy-menu-add' is an obsolete function (as of 28.1); use `ignore' instead. Use `ignore' instead? Why have we not followed the normal procedure here, by marking the function as obsolete, yet leaving it working, for one or two major versions, and only then removing it? This sudden removal of easy-menu-add will cause unnecessary annoyance amongst maintainers whose sources still use it. Even in the Emacs sources there are 25 uses of the function. The commit which created this situation was probably this one: commit affe9b225de711429248a73f920dc9f38b15c932 Author: Stefan Kangas Date: Tue Nov 24 17:39:11 2020 +0100 Make XEmacs compat aliases easy-menu-{add,remove} obsolete -- Alan Mackenzie (Nuremberg, Germany).