unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: emacs-devel@gnu.org, Stefan Kangas <stefan@marxist.se>
Subject: Yikes!  easy-menu-add is suddenly compiled to `ignore', without any warning.
Date: Wed, 7 Apr 2021 09:29:38 +0000	[thread overview]
Message-ID: <YG17goRa+2k1AzVt@ACM> (raw)

Hello, Emacs and Stefan K.

In Emacs 28, easy-menu-add is now compiled to `ignore'.  This isn't
friendly, particularly as in Emacs 27.2 and earlier, it just worked,
without any warnings of impending obsoletion.

The warning message Emacs 28.1 gives out is particularly unfriendly and
unhelpful.  It looks like this:

    cc-mode.el:2591:4: Warning: `easy-menu-add' is an obsolete function
    (as of 28.1); use `ignore' instead.

Use `ignore' instead?

Why have we not followed the normal procedure here, by marking the
function as obsolete, yet leaving it working, for one or two major
versions, and only then removing it?

This sudden removal of easy-menu-add will cause unnecessary annoyance
amongst maintainers whose sources still use it.  Even in the Emacs
sources there are 25 uses of the function.

The commit which created this situation was probably this one:

commit affe9b225de711429248a73f920dc9f38b15c932
Author: Stefan Kangas <stefan@marxist.se>
Date:   Tue Nov 24 17:39:11 2020 +0100

    Make XEmacs compat aliases easy-menu-{add,remove} obsolete

-- 
Alan Mackenzie (Nuremberg, Germany).



             reply	other threads:[~2021-04-07  9:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07  9:29 Alan Mackenzie [this message]
2021-04-07 10:06 ` Stefan Kangas
2021-04-07 11:24   ` Ulrich Mueller
2021-04-07 11:37     ` Eli Zaretskii
2021-04-07 14:14       ` Ulrich Mueller
2021-04-07 14:24         ` Eli Zaretskii
2021-04-07 14:30     ` XEmacs compatibility (was: Yikes! easy-menu-add is suddenly compiled to `ignore', without any warning) Stefan Monnier
2021-04-07 11:58   ` Yikes! easy-menu-add is suddenly compiled to `ignore', without any warning Alan Mackenzie
2021-04-07 12:43     ` Stefan Kangas
2021-04-07 11:41 ` Eli Zaretskii
2021-04-07 12:32   ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YG17goRa+2k1AzVt@ACM \
    --to=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    --cc=stefan@marxist.se \
    --subject='Re: Yikes'\!'  easy-menu-add is suddenly compiled to `ignore'\'', without any warning.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

unofficial mirror of emacs-devel@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/emacs-devel/0 emacs-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 emacs-devel emacs-devel/ https://yhetil.org/emacs-devel \
		emacs-devel@gnu.org
	public-inbox-index emacs-devel

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.emacs.devel
	nntp://news.gmane.io/gmane.emacs.devel


code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs.git

AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git