From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: master 2399541: Remove font-lock toggle from font-lock-update Date: Thu, 25 Mar 2021 11:00:56 +0000 Message-ID: References: <20210324143050.40C6E20D10@vcs0.savannah.gnu.org> <8786a8e8fa731c1bd1ef@heytings.org> <87h7l0blrc.fsf@gnus.org> <87czvobksy.fsf@gnus.org> <87r1k4a1c0.fsf@gnus.org> <87czvna9cc.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17479"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , Stefan Monnier , emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 25 12:02:41 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPNlA-0004Qy-E2 for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Mar 2021 12:02:40 +0100 Original-Received: from localhost ([::1]:50590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPNl9-0003Bl-F1 for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Mar 2021 07:02:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55426) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPNjd-00021I-E8 for emacs-devel@gnu.org; Thu, 25 Mar 2021 07:01:05 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:16968 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1lPNjZ-00061U-1o for emacs-devel@gnu.org; Thu, 25 Mar 2021 07:01:05 -0400 Original-Received: (qmail 37204 invoked by uid 3782); 25 Mar 2021 11:00:57 -0000 Original-Received: from acm.muc.de (p4fe1524f.dip0.t-ipconnect.de [79.225.82.79]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 25 Mar 2021 12:00:56 +0100 Original-Received: (qmail 4089 invoked by uid 1000); 25 Mar 2021 11:00:56 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267012 Archived-At: Hello, Gregory. There's an unnecessary vagueness in your proposed doc string for font-lock-dwim. On Thu, Mar 25, 2021 at 10:14:06 +0000, Gregory Heytings wrote: [ .... ] > -(defun font-lock-update (&optional arg) > +(defun font-lock-dwim (&optional arg) > "Updates the syntax highlighting in this buffer. > -Refontify the accessible portion of this buffer, or enable Font Lock mode > -in this buffer if it is currently disabled. With prefix ARG, toggle Font > -Lock mode." > +Enable Font Lock mode if it is disabled. Otherwise, refontify the region > +if it is active, or a large part of the accessible portion of the buffer. > +With prefix ARG, toggle Font Lock mode." <=========================== > (interactive "P") > (save-excursion > (if (and (not arg) font-lock-mode) > - (font-lock-fontify-region (point-min) (point-max)) > + (if (use-region-p) > + (font-lock-fontify-region (region-beginning) (region-end)) > + (font-lock-flush (point-min) (point-max)) > + (font-lock-fontify-region (max (point-min) (- (point) 50000)) > + (min (point-max) (+ (point) 50000)))) > (font-lock-unfontify-region (point-min) (point-max)) > (font-lock-mode 'toggle)))) I think the sentence should read: With prefix ARG, INSTEAD toggle Font Lock mode. .. The other meaning would be captured by: With prefix ARG, ALSO toggle Font Lock mode. .. Please consider amending the doc string accordingly. -- Alan Mackenzie (Nuremberg, Germany).