From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: Detecting changes between dark and light mode on Mac OS Date: Sat, 20 Mar 2021 17:52:53 +0000 Message-ID: References: <345983B0-C75E-46FF-870C-5FBD3D7381B9@nonceword.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1655"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Daphne Preston-Kendal Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 21 11:49:35 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNveJ-0000JX-9r for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Mar 2021 11:49:35 +0100 Original-Received: from localhost ([::1]:57146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNveI-00059B-1c for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Mar 2021 06:49:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNvbr-0004el-KM for emacs-devel@gnu.org; Sun, 21 Mar 2021 06:47:06 -0400 Original-Received: from outbound.soverin.net ([2a01:4f8:fff0:2d:8::218]:50727) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNvbm-0007sB-RO for emacs-devel@gnu.org; Sun, 21 Mar 2021 06:47:03 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 8D1CF6008F; Sun, 21 Mar 2021 10:46:52 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1616323612; bh=lhKbylB89SZz20Bk61lmsSM+g7pFCl129fCyfds7ucM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XEkro/y/l7Vpld/HF5m/Lizmip1JEkzchm7/g8IOsM7sbMFsLc4M7mRnBsnzKBraL lDzzDOHcNNxW10u14EpSPRHB3Oa6XkGUy/vtjNdd4mY0sHOw50XtnlC4NwrZZiyxWE OtQ+JxTHUP+lHPihQUjANtbomyDrZtsmUbzx4yzvVxH91IICNPnviigPVg8x0kwZcD ARnSsvU7aNbGboXFbMWkOnyWjAnhMv45hzB6evsXLMCIKon6ZdF/BJGZo3StJ3CWGB j9iDh0ieFeGLRlKeCLAouVcTlfWkqNuMLSrBoqbYiqYlgvkVfuhAX4NbvIhADi4iRI 2dzYSD2iJ5Jlw== Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id E4DA7202B14AA3; Sat, 20 Mar 2021 17:52:53 +0000 (GMT) Mail-Followup-To: Alan Third , Daphne Preston-Kendal , emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: <345983B0-C75E-46FF-870C-5FBD3D7381B9@nonceword.org> Received-SPF: pass client-ip=2a01:4f8:fff0:2d:8::218; envelope-from=alan@idiocy.org; helo=outbound.soverin.net X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_12_24=1.049, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266694 Archived-At: On Sat, Mar 20, 2021 at 05:51:26PM +0100, Daphne Preston-Kendal wrote: > Hello there, > > Not to pester, more to enquire: I submitted this patch nearly two > weeks ago and still haven’t heard any feedback. I submitted it here > because the Emacs manual says ‘If your patch is not complete and you > think it needs more discussion, you might want to send it to > emacs-devel@gnu.org instead.’ > > > I *think* my patch is complete, but out of inexperience I’m > unsure. (For instance, I know I shouldn’t break support for GNUstep or > any previous Mac OS version going back to 10.6, but I don’t have any > way to test that, nor sufficient experience with the relevant > platforms to know if the changes I made are even likely to cause > problems in those departments, though I don’t think they would.) Is > there a better place than this to send it to get the attention of the > people who work on Cocoa Emacs and can help more directly with this > question? Should I just send it directly to bug-gnu-emacs@gnu.org? Sorry, it fell through the cracks. I'm not sure about this patch purely on the grounds that the scrollbar colour Just Works with the Emacs theme in the current set up, but when you explicitly set light or dark it has to explicitly match the theme or it looks very strange. Even then the background is the wrong colour in themes that don't use white or black. Is that down to our choice of light and dark macOS themes? Perhaps there's a smarter way of setting the theme for various widgets? Aside from that it looks OK to me. The only major changes I think I'd require are some #ifs to limit the new code to macOS 10.14+, but that's not a big problem. -- Alan Third