unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: How about making `set-minibuffer-window' obsolete?
Date: Tue, 16 Mar 2021 20:50:17 +0000	[thread overview]
Message-ID: <YFEaCS5wghO7Vz+z@ACM> (raw)
In-Reply-To: <838s6ndjon.fsf@gnu.org>

Hello, Eli.

On Tue, Mar 16, 2021 at 20:42:32 +0200, Eli Zaretskii wrote:
> > Date: Tue, 16 Mar 2021 18:16:35 +0000
> > From: Alan Mackenzie <acm@muc.de>

> > Does anybody have any objection to me making set-minibuffer-window
> > obsolete?

> > It's defined in src/minibuf.c, but not used by any C function, and it's
> > not used by any Lisp in Emacs itself - the nearest to a use is a
> > commented out occurrence in lisp/textmodes/ispell.el.

> > This function just sets the C variable minibuf_window.  This variable is
> > defined (by comment) to be the minibuffer window of the selected frame.
> > So setting it to a random mini-window will cause nasty problems.

> > Actually, I'd prefer just to remove the function entirely - but there's
> > always the chance it's being used by some external library.

> > So, any objections?

> I'd object to obsoleting a command just because it can be dangerous
> when used unwisely.

Every use of this command is unwise.  It cannot possibly do anything
useful.  It can only cause problems.

> Emacs always gives you enough rope to hang yourself, and trusts you
> that you won't.

Rope is generally useful stuff.  Changing the value of an internal C
variable in violation of its definition is never useful.

This command appears to have been useful in the distant past - it's last
use was commented out in 1998 in the following commit:

    commit f5136913a18bd7415c59dbf7bcaf3c316593c41d
    Author: Richard M. Stallman <rms@gnu.org>
    Date:   Thu Apr 30 06:43:48 1998 +0000

        Generalized region skipping added.
        Checks comments only in code.
	Added backward compatible support for customize.

Could I ask you, please, to reconsider?

-- 
Alan Mackenzie (Nuremberg, Germany).



  reply	other threads:[~2021-03-16 20:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-16 18:16 How about making `set-minibuffer-window' obsolete? Alan Mackenzie
2021-03-16 18:42 ` Eli Zaretskii
2021-03-16 20:50   ` Alan Mackenzie [this message]
2021-03-17 12:57     ` Eli Zaretskii
2021-03-18 11:46       ` Alan Mackenzie
2021-03-18 12:01         ` Eli Zaretskii
2021-03-16 19:42 ` [External] : " Drew Adams
2021-03-16 23:04   ` Alan Mackenzie
2021-03-16 23:00 ` Stefan Monnier
2021-03-16 23:24   ` Alan Mackenzie
2021-03-17  3:31   ` Eli Zaretskii
2021-03-17  8:44     ` martin rudalics
2021-03-16 23:17 ` Dmitry Gutov
2021-03-16 23:28 ` Stefan Monnier
2021-03-17  8:44 ` martin rudalics
2021-03-17 13:17   ` Eli Zaretskii
2021-03-17 15:36     ` martin rudalics
2021-03-17 15:45       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YFEaCS5wghO7Vz+z@ACM \
    --to=acm@muc.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).