From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: [External] : How about making `set-minibuffer-window' obsolete? Date: Tue, 16 Mar 2021 23:04:55 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16869"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "emacs-devel@gnu.org" To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 17 00:07:14 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMImQ-0004I4-Q3 for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Mar 2021 00:07:14 +0100 Original-Received: from localhost ([::1]:38746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMImP-0002zM-PM for ged-emacs-devel@m.gmane-mx.org; Tue, 16 Mar 2021 19:07:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMIkM-0001jN-Gt for emacs-devel@gnu.org; Tue, 16 Mar 2021 19:05:09 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:22579 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1lMIkE-0003r8-Ok for emacs-devel@gnu.org; Tue, 16 Mar 2021 19:05:06 -0400 Original-Received: (qmail 34875 invoked by uid 3782); 16 Mar 2021 23:04:56 -0000 Original-Received: from acm.muc.de (p4fe1520c.dip0.t-ipconnect.de [79.225.82.12]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 17 Mar 2021 00:04:56 +0100 Original-Received: (qmail 10221 invoked by uid 1000); 16 Mar 2021 23:04:55 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266508 Archived-At: Hello, Drew. On Tue, Mar 16, 2021 at 19:42:11 +0000, Drew Adams wrote: > > Does anybody have any objection to me making set-minibuffer-window > > obsolete? > > It's defined in src/minibuf.c, but not used by any C function, and it's > > not used by any Lisp in Emacs itself - the nearest to a use is a > > commented out occurrence in lisp/textmodes/ispell.el. > > This function just sets the C variable minibuf_window. This variable is > > defined (by comment) to be the minibuffer window of the selected frame. > > So setting it to a random mini-window will cause nasty problems. > > Actually, I'd prefer just to remove the function entirely - but there's > > always the chance it's being used by some external library. > > So, any objections? > Thanks for asking. Hope anyone who uses it gets a > chance to see the question and respond. (How to know?) I doubt there's anybody using it. I don't think anybody's used it since 1998. > I don't use it, so a priori no objection from me wrt > my code. > But is the _only_ reason to remove it that it's not > being used in the vanilla Emacs code? If so, what's > the problem with keeping it? It's an unnecessary function with no legitimate use which could be damaging. > If we keep it, maybe you'll want to add a comment > saying "setting it to a random mini-window will cause > nasty problems" or what you had in mind about that. That's an idea! -- Alan Mackenzie (Nuremberg, Germany).