unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: Evgeny Zajcev <lg.zevlg@gmail.com>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: Image transformation filter for upscaled images
Date: Mon, 8 Mar 2021 18:58:01 +0000	[thread overview]
Message-ID: <YEZzud2sy5yGZF0I@breton.holly.idiocy.org> (raw)
In-Reply-To: <CADwFkmn3pk9dnLcKvieD4spcGZjhgD1sjib6n4J=4W763-8p6w@mail.gmail.com>

On Sun, Mar 07, 2021 at 05:27:44PM -0600, Stefan Kangas wrote:
> Evgeny Zajcev <lg.zevlg@gmail.com> writes:
> 
> >> The reason nearest was chosen was because scaled up pixel art (emojis,
> >> mostly, like etc/images/smilies/wry.xpm) looked abominable
> 
> Doesn't it seem like a bad trade-off to improve rendering of smileys at
> the cost of rendering PDF:s worse?  I rarely if ever use doc-view, but
> testing it now seems to produce less than stellar results (i.e. the text
> is barely readable).

This is the first I've heard of any complaints about the rendering of
PDFs, and I don't view them in Emacs. Certainly nobody brought it up
when the change was implemented, so the trade-off wasn't considered.

I don't feel strongly about this. Can someone try the "best" filter
and see if good is an improvement over it? We use best for scaling
down, so if we're happy with best for scaling up then we can just
remove the code that sets it completely. Or go with good across the
board, but best is, y'know, better. ;)

Remove the ternary operator in this line (image.c:2372), and probably
the one just below on line 2378 as well:

          XRenderSetPictureFilter (FRAME_X_DISPLAY (f), img->mask_picture,
                                   scale_down ? FilterBest : FilterNearest, 0, 0);

> > Just get rid of any xpm :) Emacs has nice support for SVG after all, we can
> > write xpm to svg converter to keep pixel art precision.
> 
> Is there a way to convert from XPM automatically, or are you saying you
> volunteer to make the SVG:s?

There are only 12 emoji XPMs, so trying to copy them directly into SVG
would probably not take too much effort... They might not look very
good, though. ;)

-- 
Alan Third



  parent reply	other threads:[~2021-03-08 18:58 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-07 19:12 Image transformation filter for upscaled images Evgeny Zajcev
2021-03-07 20:45 ` Alan Third
2021-03-07 22:35   ` Evgeny Zajcev
2021-03-07 23:27     ` Stefan Kangas
2021-03-08  0:42       ` Evgeny Zajcev
2021-03-08  2:31         ` Stefan Kangas
2021-03-08 13:34           ` Eli Zaretskii
2021-03-08 13:31       ` Eli Zaretskii
2021-03-08 18:58       ` Alan Third [this message]
2021-03-08 19:18         ` Lars Ingebrigtsen
2021-03-08 21:27           ` Alan Third
2021-03-08 21:31             ` Lars Ingebrigtsen
2021-03-08 21:59               ` Alan Third
2021-03-09  8:34                 ` Evgeny Zajcev
2021-03-09  9:28                   ` Alan Third
2021-03-09  9:46                     ` Evgeny Zajcev
2021-03-09 14:16                     ` Stefan Monnier
2021-03-09 13:09                   ` Eli Zaretskii
2021-03-09 13:48                     ` Evgeny Zajcev
2021-03-09 13:59                     ` Lars Ingebrigtsen
2021-03-09 16:37                       ` Eli Zaretskii
2021-03-09 17:04                         ` Lars Ingebrigtsen
2021-03-09 18:01                           ` Eli Zaretskii
2021-03-10  4:23                           ` Yuri Khan
2021-03-10 14:44                             ` Lars Ingebrigtsen
2021-03-09 13:16                   ` Lars Ingebrigtsen
2021-03-09 13:50                     ` Dov Grobgeld
2021-03-09 18:16                       ` Alan Third
2021-03-09 18:12                     ` Alan Third
2021-03-09 22:31                       ` Basil L. Contovounesios
2021-03-09 23:59                         ` Stefan Monnier
2021-03-10 13:37                         ` Alan Third
2021-03-10 14:49                       ` Lars Ingebrigtsen
2021-03-10 21:45                         ` Alan Third
2021-03-11 16:53                           ` Lars Ingebrigtsen
2021-03-12  1:38                           ` Lars Ingebrigtsen
2021-03-12  2:01                             ` Evgeny Zajcev
2021-03-12 18:32                             ` Alan Third
2021-03-08 20:05         ` Evgeny Zajcev
2021-03-08 21:29           ` Alan Third
2021-03-08 13:27     ` Eli Zaretskii
2021-03-07 23:12   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YEZzud2sy5yGZF0I@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=emacs-devel@gnu.org \
    --cc=lg.zevlg@gmail.com \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).