From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Stop frames stealing eachothers' minibuffers! Date: Sun, 14 Mar 2021 18:26:18 +0000 Message-ID: References: <874kinakv2.fsf@miha-pc> <87sg6690vc.fsf@miha-pc> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8366"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jakanakaevangeli , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 14 19:28:49 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lLVTs-00024C-HU for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Mar 2021 19:28:48 +0100 Original-Received: from localhost ([::1]:40204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLVTr-0003MK-Eu for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Mar 2021 14:28:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52562) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLVRa-0001YO-DS for emacs-devel@gnu.org; Sun, 14 Mar 2021 14:26:26 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:47533 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1lLVRY-00064Y-7v for emacs-devel@gnu.org; Sun, 14 Mar 2021 14:26:26 -0400 Original-Received: (qmail 96011 invoked by uid 3782); 14 Mar 2021 18:26:18 -0000 Original-Received: from acm.muc.de (p2e5d5102.dip0.t-ipconnect.de [46.93.81.2]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 14 Mar 2021 19:26:18 +0100 Original-Received: (qmail 31130 invoked by uid 1000); 14 Mar 2021 18:26:18 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266459 Archived-At: Hello, Stefan. On Sat, Mar 13, 2021 at 15:52:51 -0500, Stefan Monnier wrote: > > I didn't actually know there was a `sort_list' function, or a merge part > > of it, so that should save quite a lot of code if I can use it (which I > > probably can). > I didn't either, really, I found them by following the code from > `Fsort`. Of course, this is meant for ELisp so the predicate has to be > an ELisp value rather than a C function, so it will probably force you > to define the predicate with DEFUN, which is not completely > satisfactory (tho not terribly harmful either, I guess). No, not completely satisfactory. So, after spending an hour or so trying to work out how to define a Lisp function in C without it being visible in the Lisp world, I hit on a simpler solution - copy `merge' to a new function `merge_c', replacing the Lisp predicate with a boolean C function. This works fine, at the small cost of a little code duplication. I think I've followed all your other suggestions from yesterday, now. Anyhow, I think I've fixed the bugs that jakanakaevangeli pointed out yesterday, so I'll post my updated patch in my reply to her/him. > Stefan -- Alan Mackenzie (Nuremberg, Germany).