unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: emacs-devel@gnu.org
Subject: Re: master fbc9c59: Make goto-line-history buffer local only when so customized
Date: Fri, 26 Feb 2021 13:01:46 +0000	[thread overview]
Message-ID: <YDjxOnQb5I9Lsf9+@ACM> (raw)
In-Reply-To: <87wnuv3ttp.fsf@tcd.ie>

Hello, Basil.

On Fri, Feb 26, 2021 at 12:19:14 +0000, Basil L. Contovounesios wrote:
> acm@muc.de (Alan Mackenzie) writes:

> > branch: master
> > commit fbc9c59b9eb02d49f426341ee32334784d224ce4
> > Author: Alan Mackenzie <acm@muc.de>
> > Commit: Alan Mackenzie <acm@muc.de>

> >     Make goto-line-history buffer local only when so customized

> >     * lisp/simple.el (goto-line-history-local): New customizable option.
> >     (goto-line-history): Define this simply with defvar, not defvar-local.
> >     (goto-line-read-args): Handle goto-line-history-local, and changes to it.

> >     * doc/emacs/basic.texi (Moving Point): Add a paragraph about
> >     goto-line-history-local.

> >     * etc/NEWS: Add an item under "Editing Changes in Emacs 28.1".

> [...]

> > diff --git a/etc/NEWS b/etc/NEWS
> > index b96bcd9..7665d47 100644
> > --- a/etc/NEWS
> > +++ b/etc/NEWS
> > @@ -345,6 +345,11 @@ trying to be non-destructive.
> >  This command opens a new buffer called "*Memory Report*" and gives a
> >  summary of where Emacs is using memory currently.

> > ++++
> > +** The history list for the 'goto-line' command is now a single list
> > +for all buffers by default.  You can configure a separate list for
> > +each buffer by customizing the user option 'goto-line-history-local'.

> I think this contradicts a preceding entry:

> ** Input history for 'goto-line' is now local to every buffer.
> Each buffer will keep a separate history of line numbers used with
> 'goto-line'.  This should help making faster the process of finding
> line numbers that were previously jumped to.

Well, I think "contradict" is not quite the right word.  Whether the list
is buffer local or not is now customisable, which it wasn't before.  The
default is somewhat arbitrary, as it always is in these things, with some
people proclaiming a particular setting "obviously" should be the
default, others saying the opposite is "obvious".  That the list, before
that previous patch, wasn't buffer local points to the current default.

Or, have I misunderstood what you're saying?

> Thanks,

> -- 
> Basil

-- 
Alan Mackenzie (Nuremberg, Germany).



  reply	other threads:[~2021-02-26 13:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210217212130.32410.14813@vcs0.savannah.gnu.org>
     [not found] ` <20210217212132.0B17F20DFB@vcs0.savannah.gnu.org>
2021-02-26 12:19   ` master fbc9c59: Make goto-line-history buffer local only when so customized Basil L. Contovounesios
2021-02-26 13:01     ` Alan Mackenzie [this message]
2021-02-26 13:15       ` Basil L. Contovounesios
2021-02-26 13:36         ` Alan Mackenzie
2021-02-27 14:27           ` Basil L. Contovounesios
2021-02-28 21:33             ` Alan Mackenzie
2021-02-28 21:53               ` Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YDjxOnQb5I9Lsf9+@ACM \
    --to=acm@muc.de \
    --cc=contovob@tcd.ie \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).