From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: master fbc9c59: Make goto-line-history buffer local only when so customized Date: Fri, 26 Feb 2021 13:36:02 +0000 Message-ID: References: <20210217212130.32410.14813@vcs0.savannah.gnu.org> <20210217212132.0B17F20DFB@vcs0.savannah.gnu.org> <87wnuv3ttp.fsf@tcd.ie> <875z2f3r8p.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30008"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 26 14:37:19 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lFdJ0-0007iN-Td for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Feb 2021 14:37:18 +0100 Original-Received: from localhost ([::1]:35058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lFdIz-0002eD-VY for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Feb 2021 08:37:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33530) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFdHs-0002CO-R4 for emacs-devel@gnu.org; Fri, 26 Feb 2021 08:36:08 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:62554 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1lFdHq-00060u-3J for emacs-devel@gnu.org; Fri, 26 Feb 2021 08:36:08 -0500 Original-Received: (qmail 16137 invoked by uid 3782); 26 Feb 2021 13:36:03 -0000 Original-Received: from acm.muc.de (p4fe15b25.dip0.t-ipconnect.de [79.225.91.37]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 26 Feb 2021 14:36:02 +0100 Original-Received: (qmail 9585 invoked by uid 1000); 26 Feb 2021 13:36:02 -0000 Content-Disposition: inline In-Reply-To: <875z2f3r8p.fsf@tcd.ie> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265682 Archived-At: Hello, Basil. On Fri, Feb 26, 2021 at 13:15:02 +0000, Basil L. Contovounesios wrote: > Alan Mackenzie writes: > >> > ++++ > >> > +** The history list for the 'goto-line' command is now a single list > >> > +for all buffers by default. You can configure a separate list for > >> > +each buffer by customizing the user option 'goto-line-history-local'. > >> I think this contradicts a preceding entry: > >> ** Input history for 'goto-line' is now local to every buffer. > >> Each buffer will keep a separate history of line numbers used with > >> 'goto-line'. This should help making faster the process of finding > >> line numbers that were previously jumped to. > > Well, I think "contradict" is not quite the right word. Whether the list > > is buffer local or not is now customisable, which it wasn't before. The > > default is somewhat arbitrary, as it always is in these things, with some > > people proclaiming a particular setting "obviously" should be the > > default, others saying the opposite is "obvious". That the list, before > > that previous patch, wasn't buffer local points to the current default. > > Or, have I misunderstood what you're saying? > I think so. My point is that the older entry says goto-line has > buffer-local history by default, whereas the newer entry says goto-line > does not have buffer-local history by default. Yes, I had misunderstood, sorry. I was under the mistaken impression that the previous change to the input history was in Emacs 27. So, yes, you're correct, the two entries in NEWS do contradict eachother, and need merging into a single entry. I don't have time to do this today, I'll try and do it over the weekend. [ .... ] > The latter change reverts some parts of the former, and makes the > behaviour customisable, but the older NEWS entry was not updated to > reflect this. I was hoping you would merge the two NEWS entries or > simply delete the older one, since it no longer accurately represents > the default, and is duplicated by the newer entry. > This part of (info "(elisp) Minibuffer History") also needs updating: > -- Variable: goto-line-history > A history list for arguments to ‘goto-line’. This variable is > buffer local. Hmm. OK. But what's this variable doing in the elisp manual, as opposed to the emacs manual? It's purely a user convenience. > Thanks, > -- > Basil -- Alan Mackenzie (Nuremberg, Germany).