From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Edebug corrupting point in buffers. Date: Thu, 3 Nov 2022 18:07:16 +0000 Message-ID: References: <83v8nybnuk.fsf@gnu.org> <83pme6bls8.fsf@gnu.org> <83mt99a223.fsf@gnu.org> <83cza59tvg.fsf@gnu.org> <83wn8c6u96.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7029"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 03 19:07:59 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqedC-0001b9-ME for ged-emacs-devel@m.gmane-mx.org; Thu, 03 Nov 2022 19:07:58 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqect-0005cJ-3u; Thu, 03 Nov 2022 14:07:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqeco-0005YP-OH for emacs-devel@gnu.org; Thu, 03 Nov 2022 14:07:34 -0400 Original-Received: from mx3.muc.de ([193.149.48.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqecl-0001D7-Jb for emacs-devel@gnu.org; Thu, 03 Nov 2022 14:07:34 -0400 Original-Received: (qmail 96769 invoked by uid 3782); 3 Nov 2022 19:07:18 +0100 Original-Received: from acm.muc.de (p4fe15d9a.dip0.t-ipconnect.de [79.225.93.154]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 03 Nov 2022 19:07:17 +0100 Original-Received: (qmail 9084 invoked by uid 1000); 3 Nov 2022 18:07:16 -0000 Content-Disposition: inline In-Reply-To: <83wn8c6u96.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.5; envelope-from=acm@muc.de; helo=mx3.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299088 Archived-At: Hello, Eli. On Thu, Nov 03, 2022 at 15:29:57 +0200, Eli Zaretskii wrote: > > Date: Thu, 3 Nov 2022 11:32:29 +0000 > > Cc: emacs-devel@gnu.org > > From: Alan Mackenzie > > +@node Edebug Buffer Points > > +@subsubsection Edebug's handling of buffer points > > + > > +When Edebug enters its recursive edit to get a command from the user, > > +by default it saves the window points of each window in the selected > > +frame (@pxref{Edebug Display Update}). These are usually, but not > > +always, the same as the values of point in the buffers displayed by > > +these windows (@pxref{Window Point}). On leaving the recursive edit, > > +these window points get restored, but sometimes buffer points get > > +overwritten by them too. > > + > > +This can occasionally be a problem when your program switches buffers > > +and sets point in them. The recommended workaround is to disable the > > +option @code{edebug-save-windows}, for example with the command > > +@kbd{W} (@pxref{Edebug Options}). > > + > > @node Edebug Recursive Edit > > @subsubsection Edebug Recursive Edit > > @@ -1657,6 +1674,11 @@ Edebug Options > > what happens to the window configurations, it is better to set this > > variable to @code{nil}. > > +Saving the window configuration can sometimes corrupt the values of > > +point in buffers displayed by these windows. If this happens, you are > > +recommended to set @code{edebug-save-windos} to @code{nil}. > > +@xref{Edebug Buffer Points}. > > + > The node you added is very short, barely a dozen lines. It makes > little sense to have it separate from where edebug-save-windows is > described. So I think you should move it there. The location of the > node inside the manual's hierarchy is much less important than to have > the information pertaining to edebug-save-windows in a single place, > because no one reads the ELisp reference manual in its entirety. The > only thing we need to facilitate people finding this place is add good > index entries there. So you're proposing leaving the "The outside context" node incomplete, according to its clearly defined purpose, and therefore wrong? Why? Remember, this patch is not about edebug-save-windows. It's about point getting corrupted. > Thanks. -- Alan Mackenzie (Nuremberg, Germany).