From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: Redisplay slower in Emacs 28 than Emacs 27 Date: Mon, 7 Dec 2020 21:23:06 +0000 Message-ID: References: <878sa9hbe2.fsf@gnus.org> <877dptfvae.fsf@gnus.org> <83czzl8qwu.fsf@gnu.org> <87sg8h78s8.fsf@gnus.org> <87h7ox71xc.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40880"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gregory Heytings , Eli Zaretskii , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 07 22:25:47 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmO0x-000AVX-9N for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Dec 2020 22:25:47 +0100 Original-Received: from localhost ([::1]:35424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmO0w-0004qG-6A for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Dec 2020 16:25:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmNye-00048j-MP for emacs-devel@gnu.org; Mon, 07 Dec 2020 16:23:24 -0500 Original-Received: from outbound.soverin.net ([116.202.65.218]:47969) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmNyW-0002vz-6L; Mon, 07 Dec 2020 16:23:23 -0500 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 669EA60157; Mon, 7 Dec 2020 21:23:10 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id BD0AC2028665E6; Mon, 7 Dec 2020 21:23:06 +0000 (GMT) Mail-Followup-To: Alan Third , Lars Ingebrigtsen , Gregory Heytings , Eli Zaretskii , emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: <87h7ox71xc.fsf@gnus.org> Received-SPF: pass client-ip=116.202.65.218; envelope-from=alan@idiocy.org; helo=outbound.soverin.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260520 Archived-At: On Mon, Dec 07, 2020 at 10:15:43PM +0100, Lars Ingebrigtsen wrote: > Gregory Heytings writes: > > > With equal_lists 18.7s, with !equal_lists 16.1s. > > > > This difference is not due to an obscure compiler bug, the timings > > above are with GCC 10, but the timings with Clang 9 are similar: with > > equal_lists 19.0s, with !equal_lists 16.6s. > > Very interesting. Using the image cache for small images slows Emacs > down? Or is there a bug in equal_lists? > > Just to make 100% sure -- could you re-run the benchmark with something > like the following as the function: > > static struct image * > search_image_cache (struct frame *f, Lisp_Object spec, EMACS_UINT hash, > unsigned long foreground, unsigned long background, > bool ignore_colors) > { > return NULL; > } I already tried that and it absolutely killed Emacs when the toolbar was displayed. As far as I can tell the "!" makes no great difference to the toolbar images as it somehow finds a matching image in the cache anyway. -- Alan Third