From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jean Louis Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Support "\n" in icomplete-separator Date: Fri, 6 Nov 2020 08:52:37 +0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20616"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mutt/+ (1036f0e) (2020-10-18) Cc: emacs-devel@gnu.org To: Andrii Kolomoiets Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 06 10:09:53 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kaxkm-0005HX-IY for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Nov 2020 10:09:52 +0100 Original-Received: from localhost ([::1]:36256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaxkl-0001vf-Fw for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Nov 2020 04:09:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaxjM-0000Cy-6j for emacs-devel@gnu.org; Fri, 06 Nov 2020 04:08:25 -0500 Original-Received: from static.rcdrun.com ([95.85.24.50]:45389) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaxjK-0004eL-82 for emacs-devel@gnu.org; Fri, 06 Nov 2020 04:08:23 -0500 Original-Received: from localhost ([::ffff:197.157.0.43]) (AUTH: PLAIN admin, TLS: TLS1.2,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by static.rcdrun.com with ESMTPSA id 00000000002C0006.000000005FA51284.00005A4B; Fri, 06 Nov 2020 09:08:20 +0000 Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=95.85.24.50; envelope-from=bugs@gnu.support; helo=static.rcdrun.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/06 04:08:03 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592, RCVD_IN_SORBS_WEB=1.5, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258788 Archived-At: * Andrii Kolomoiets [2020-11-06 02:11]: > Hi, > > I'm a bit late to the icomplete-vertical party, but please let me show > you my approach at supporting "\n" in 'icomplete-separator'. > > The main idea is to treat the 'icomplete-prospects-height' variable > value as the amount of completions we want to see if there is "\n" in the > 'icomplete-separator'. > > Please see attached patch. > > Also see attached screenshot of minibuffer-only frame after: > > emacs -Q --eval "(setq default-frame-alist '((minibuffer . nil)))" > M-x icomplete-mode > (setq icomplete-prospects-height 5) > (setq icomplete-hide-common-prefix nil) > (setq icomplete-separator "\n ") > (setq resize-mini-frames t) > M-x icomp > > If that approach was already discussed, please let me know. Maybe you can also improve ido-mode to work vertically?