Re: master d3d60ab: Remove unnecessary dependency on seq library

Re: master d3d60ab: Remove unnecessary dependency on seq library

[Basil L. Contovounesios]

mvoteiza@udel.edu (Mark Oteiza) writes:

> branch: master
> commit d3d60ab2723fe4b3fa15f4d593319d0d08892cb0
> Author: Mark Oteiza <mvoteiza@udel.edu>
> Commit: Mark Oteiza <mvoteiza@udel.edu>
>
>     Remove unnecessary dependency on seq library
>     
>     * lisp/json.el: Remove require declaration.
>     (json-encode-array): Just use length and /=.
> ---
>  lisp/json.el | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lisp/json.el b/lisp/json.el
> index f5659d8..2498659 100644
> --- a/lisp/json.el
> +++ b/lisp/json.el
> @@ -55,7 +55,6 @@
>  ;;; Code:
>  
>  (require 'map)
> -(require 'seq)
>  (require 'subr-x)
>  
>  ;; Parameters
> @@ -655,7 +654,7 @@ become JSON objects."
>  (defun json-encode-array (array)
>    "Return a JSON representation of ARRAY."
>    (if (and json-encoding-pretty-print
> -           (not (seq-empty-p array)))
> +           (/= 0 (length array)))

The reason for seq-empty-p was that it doesn't traverse the entire
length of lists.  Please keep this optimisation, e.g. via:

  (if (listp array)
      array
    (> (length array) 0))

Thanks,

-- 
Basil

Re: master d3d60ab: Remove unnecessary dependency on seq library

[Mark Oteiza]

On 04/01/21 at 02:24am, Basil L. Contovounesios wrote:
> mvoteiza@udel.edu (Mark Oteiza) writes:
> 
> > branch: master
> > commit d3d60ab2723fe4b3fa15f4d593319d0d08892cb0
> > Author: Mark Oteiza <mvoteiza@udel.edu>
> > Commit: Mark Oteiza <mvoteiza@udel.edu>
> >
> >     Remove unnecessary dependency on seq library
> >     
> 
> The reason for seq-empty-p was that it doesn't traverse the entire
> length of lists.  Please keep this optimisation, e.g. via:
> 
>   (if (listp array)
>       array
>     (> (length array) 0))
> 

Thank you, I pushed the fix.