unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark Oteiza <mvoteiza@udel.edu>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: emacs-devel@gnu.org
Subject: Re: master d3d60ab: Remove unnecessary dependency on seq library
Date: Sun, 3 Jan 2021 22:09:37 -0500	[thread overview]
Message-ID: <X/KG8d2q+yBYdPpD@logos.localdomain> (raw)
In-Reply-To: <87sg7hbfrg.fsf@tcd.ie>

On 04/01/21 at 02:24am, Basil L. Contovounesios wrote:
> mvoteiza@udel.edu (Mark Oteiza) writes:
> 
> > branch: master
> > commit d3d60ab2723fe4b3fa15f4d593319d0d08892cb0
> > Author: Mark Oteiza <mvoteiza@udel.edu>
> > Commit: Mark Oteiza <mvoteiza@udel.edu>
> >
> >     Remove unnecessary dependency on seq library
> >     
> 
> The reason for seq-empty-p was that it doesn't traverse the entire
> length of lists.  Please keep this optimisation, e.g. via:
> 
>   (if (listp array)
>       array
>     (> (length array) 0))
> 

Thank you, I pushed the fix.



      reply	other threads:[~2021-01-04  3:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210103220053.27764.38848@vcs0.savannah.gnu.org>
     [not found] ` <20210103220055.5BBC120999@vcs0.savannah.gnu.org>
2021-01-04  2:24   ` master d3d60ab: Remove unnecessary dependency on seq library Basil L. Contovounesios
2021-01-04  3:09     ` Mark Oteiza [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X/KG8d2q+yBYdPpD@logos.localdomain \
    --to=mvoteiza@udel.edu \
    --cc=contovob@tcd.ie \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).