Hello, Martin.

On Sun, Jan 03, 2021 at 21:08:21 +0100, martin rudalics wrote:
>  > OK, here it is!

> Thanks.  It fails to build here as:


> CC       cmds.o
> ../../src/minibuf.c: In function ‘choose_minibuf_frame’:
> ../../src/minibuf.c:136:19: warning: unused variable ‘sf’ [-Wunused-variable]
>       struct frame *sf = XFRAME (selected_frame);
>                     ^~
> ../../src/minibuf.c: In function ‘read_minibuf’:
> ../../src/minibuf.c:784:11: error: invalid operands to binary != (have ‘Lisp_Object’ {aka ‘struct Lisp_Object’} and ‘Lisp_Object’ {aka ‘struct Lisp_Object’})
>         if ((inactive_map =
>             ~~~~~~~~~~~~~~~
>              find_symbol_value (intern ("minibuffer-inactive-mode-map")))
>              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>             != Qunbound)
>             ^~
>    CC       casetab.o
> make[1]: *** [Makefile:405: minibuf.o] Fehler 1
> make[1]: *** Es wird auf noch nicht beendete Prozesse gewartet....
> make[1]: Verzeichnis „/home/martin/emacs-git/trunk/obj-gtk/src“ wird verlassen
> make: *** [Makefile:424: src] Fehler 2

Thanks!  My compiler (GCC 9.3.0) didn't even raise a warning for that.
I've corrected it, and also got rid of the unused variable.

> You have to use !EQ when testing Lisp Objects for inequality.

Yes, indeed.

The corrected patch is attached.

> martin

-- 
Alan Mackenzie (Nuremberg, Germany).