From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arthur Miller Newsgroups: gmane.emacs.devel Subject: Re: empty-directory predicate, native implementation Date: Wed, 14 Oct 2020 16:43:45 +0200 Message-ID: References: <83y2ka18t7.fsf@gnu.org> <83d01m0wjp.fsf@gnu.org> <834kmw293v.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12712"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 14 16:57:41 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSiDl-0003Eb-9j for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Oct 2020 16:57:41 +0200 Original-Received: from localhost ([::1]:40158 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSiDk-0002ru-Au for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Oct 2020 10:57:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSi0P-0003xE-AO for emacs-devel@gnu.org; Wed, 14 Oct 2020 10:43:57 -0400 Original-Received: from mail-am7eur06olkn2052.outbound.protection.outlook.com ([40.92.16.52]:41184 helo=EUR06-AM7-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSi0L-0007FK-O1; Wed, 14 Oct 2020 10:43:52 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HRpX8kUlpqdbO4zoo3OiGnZmA/Ep6K/oeiICwKo9EPDPr72mRnAoV2cKcvpCPpV36Wzy73R+UROmJOb0ovKu0yPBwAlw0lWQs6FAvYKbWG2kqqRPLiPZZhttZrSKZZglq27TWXuiluSjyNWZ/UfjP1t/7Ys45Vehtpd2rEzLlV9iNykQbp7/Q9iqNymMZ/UBWub5MTSIRVEBRsUOP56x6v0+2hytGY27tBFHNKP2aUgCzotdZNZj5hzAOuwwLnDLMImCBTzyQIIDM6VCFEdy/f5FtEi8BQoQ4vHRXUqOMXyWoFuSKeezebNRGNAWQa/zEsoleN0RyJr07gw7Xf7tPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PdbdD1uxJ0EhPunei/Z7ta+2d/0mY/QRXXIH0gL0fac=; b=YR2CXxwhND0MRnLt0D+FJoe+FZgmr9m0e4tHXycLg8Oa7FO0CcvS4uzDqM9qKa9wXf95ZylBvt+LzerIcRdO0jueRcfAXC8MfwBIJovHx2CmnQFLuBUaZ6eDsjBnKOxhRTm/QlQe7AmuSQPalootyXOJZBkEl4YoMPIzuWDszpBmAdUlo7QJLeXjJznHLZexjHj95H8c+rOtgvj9jtBhPG6LxCVrGBbaSIBk9jzvbKcjJwiKQm1eKP4ZBOBXqLUZLEXR5YlJHwBMBDh1aajrRzz14LZVoiqPWhdZEniotu1vJY+aqo4t6AZXm0mLne6REYuKj/nZdxkn6eWvqFtMMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PdbdD1uxJ0EhPunei/Z7ta+2d/0mY/QRXXIH0gL0fac=; b=ZXlOiqQU42v/OhKrLKscbJtITtLyUmH7FJLaVU8PNK54sZfnMJrTyb9VbX75kn47TONd6vKNvexaTkdI3HMJO0Y2uEjQosqTWsFGfxPKTuYg0ytMJhYjw137q26oIjSyXqAxpDh3ivdpUu7rv+P56hX/7vt4VzhPlBO4/tNdFwFn2CXIeEcj99UdmGp14FrEKjDzENL3nCbX9ULEMKBIYUDpFEWe/wodxmNl9hYHI2AB4sDnZFoxHJjEWiNp4sclq3eErK0S+3hkcG/PROGVCXpVFYejxwaORSkxXrgxkRV0S1JQCVmAg8vftOoRKBhQQMB0Uh1yWGCY0fizHDGeFQ== Original-Received: from AM7EUR06FT058.eop-eur06.prod.protection.outlook.com (2a01:111:e400:fc36::49) by AM7EUR06HT131.eop-eur06.prod.protection.outlook.com (2a01:111:e400:fc36::111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21; Wed, 14 Oct 2020 14:43:47 +0000 Original-Received: from VI1PR06MB4526.eurprd06.prod.outlook.com (2a01:111:e400:fc36::4c) by AM7EUR06FT058.mail.protection.outlook.com (2a01:111:e400:fc36::161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21 via Frontend Transport; Wed, 14 Oct 2020 14:43:47 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:C52B097CCAEC4C920B8B10DAE6741324051B169A614A38C65D7459109505361A; UpperCasedChecksum:7EA73DFAA2FC5BA1579ED4C584B1F9F6E47140FCE4F05821DB7F4DD6C93D80F2; SizeAsReceived:7675; Count:46 Original-Received: from VI1PR06MB4526.eurprd06.prod.outlook.com ([fe80::b547:51cd:16c5:4487]) by VI1PR06MB4526.eurprd06.prod.outlook.com ([fe80::b547:51cd:16c5:4487%7]) with mapi id 15.20.3455.031; Wed, 14 Oct 2020 14:43:47 +0000 In-Reply-To: <834kmw293v.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 14 Oct 2020 17:08:36 +0300") X-TMN: [srQaWDV5eQUixN+Sq30SfREFtENfUAF3] X-ClientProxiedBy: AM6P195CA0025.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::38) To VI1PR06MB4526.eurprd06.prod.outlook.com (2603:10a6:803:ac::17) X-Microsoft-Original-Message-ID: <87mu0oyiji.fsf@live.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from pascal.homepc (90.230.29.56) by AM6P195CA0025.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21 via Frontend Transport; Wed, 14 Oct 2020 14:43:46 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 46 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: a6f6b931-c6cb-46d9-8c59-08d8704f8e7c X-MS-TrafficTypeDiagnostic: AM7EUR06HT131: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wm/Xe2ynnnuJh3I2CfY9ZLrRh7tekQNFcDNNBFohOVzGexFkB7lvy5tJLiynTmVfOpspSP6UhrPx57EAEfsg8g/mci+VuX9ueUltGYivZuaaQDGhHlqMFnrZD32qZtMdcHfO+0NFIhjWv367wsjHH9huCgjnASAp4uruuqOP8EgtLurfo2FextFKV7jjpfIB1fY7TGMVizp0kqyQZHJvog== X-MS-Exchange-AntiSpam-MessageData: JFEd+HwRujfovF590N/bou1nBbrZDIMikaOGDShHhKHrZYZnTS+3o8pZ7BLwmGWP7bsNF6DZx2iHXoh+q8vRbjcGy3E3SZJYYk3nZCwqs17Ib9ATAgPlTq6yNzpKlHXBUPflx+LMp9qus0K6nxl08w== X-OriginatorOrg: live.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6f6b931-c6cb-46d9-8c59-08d8704f8e7c X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2020 14:43:47.1547 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: AM7EUR06FT058.eop-eur06.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7EUR06HT131 Received-SPF: pass client-ip=40.92.16.52; envelope-from=arthur.miller@live.com; helo=EUR06-AM7-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/14 10:43:47 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:257637 Archived-At: Eli Zaretskii writes: >> From: Arthur Miller >> Cc: emacs-devel@gnu.org >> Date: Tue, 13 Oct 2020 21:59:47 +0200 >> >> Can I ask two questions, just for my learning; you seem to handle >> ascii/unicode "manually"; in w32.c I have seen quite a few places where >> switch is done on if(w32_unicode_filenames); is it possible to somehow >> pass to configure script if Emacs should be compiled with wide or asci >> version of win api? > > The idea is not to decide this at configure and compile time, but at > runtime. That way, the same Emacs binary can run both on systems that > support "wide" (a.k.a. "Unicode") APIs and on systems that don't. > Think about users who download the "official" binaries from the GNU > FTP site. Ok, I understand the reason now. > Besides, the compile-time "switch" to Unicode makes all TCHAR > variables be wchar_t under the hood, which means one cannot use > strlen, strcat, etc. So this "feature" is a mixed blessing, > especially when the internal encoding is UTF-8. Yes; that is what they do in VS (they have option on general tab to use unicode/multibyte/not-defined == ascii), so I was thinking about something like that with configure, but now I understand why you don't have it. >> Second question: block_input; is there some general rule(s) what calls you >> enclose with block/unblock_input? I guess OS will anyway block the >> process after call to SYS_getdents so I didn't enclosed it; but I am not >> sure if that would be needed at all or not. > > See the commentary in src/blockinput.h, I hope it answers the > question. Yes, will do. Thanks.