unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "stefankangas@gmail.com" <stefankangas@gmail.com>,
	"jporterbugs@gmail.com" <jporterbugs@gmail.com>,
	"dov.grobgeld@gmail.com" <dov.grobgeld@gmail.com>,
	"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: RE: [External] : Re: [PATCH] color-hsv-to-rgb
Date: Fri, 20 Oct 2023 21:04:55 +0000	[thread overview]
Message-ID: <SJ0PR10MB5488DD3F0C363E485053F871F3DBA@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)

> It is hard for anyone but you to know what
> is your POV on this issue.

I don't have a POV on what else in `hexrgb.el'
might be missing from `color.el' and might want
to be added now by Emacs Dev.  And that's what
I said, at the outset of my reply to Stefan's
question:

  "Sorry, but I don't know"

All of hexrgb.el was considered when `color.el'
was being created, including `hexrgb-hsv-to-rgb'.
Whatever was wanted was used, and that didn't
include `hexrgb-hsv-to-rgb'.

I mentioned that function in this thread only
because of the thread Subject.  Would you have
preferred that I not mention it?  I figured
its code might help in some way, as well as
the fact that I (too) think such a function is
useful.  The latter was the main reason I wrote
to the thread: to say +1 to Jim's +1 to Dov's
request.  That's the main msg: it's useful.

There's no need for me to guess what else you
might be interested in.  If you're interested,
just take a look at the available functions.
It's not like there are zillions of them, and
they're all handily listed in one place, with
clear names.

As I said, I haven't looked at this code since
2018, and likewise `color.el'.  If someone is
interested in investigating the differences
they are as capable as I am for that.

And again, I have no POV about "main things 
besides `color-hsv-to-rgb'".
___

A quick look now at `color.el' shows it's
mostly about color conversion, not color
modification, HSL being the sole exception,
and only for S and L. `hexrgb.el' has eight
functions for incrementing/decrementing:

  +/- R, G, B individually and together
  +/- H, S, V individually
  +/- hex digits together

Why `color.el' has separate functions (8 of
them!) for the two directions to increment
only S and L is a mystery.  With `hexrgb.el',
just use a negative increment to decrement.

`hexrgb.el' also has functions to modify a
color by complementing only one component: red/green/blue/hue/saturation/value.  E.g.,
complementing hue doesn't change saturation
or value.

  (hexrgb-hue-complement "LightBlue")
    ; => "#E6E5BBBAADAC"

HTH.



             reply	other threads:[~2023-10-20 21:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-20 21:04 Drew Adams [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-10-16  7:28 [PATCH] color-hsv-to-rgb Dov Grobgeld
2023-10-16  7:59 ` Stefan Kangas
2023-10-19 19:58   ` Jim Porter
2023-10-19 20:12     ` [External] : " Drew Adams
2023-10-19 21:22       ` Stefan Kangas
2023-10-19 21:35         ` Drew Adams
2023-10-20  6:09           ` Eli Zaretskii
2023-10-20 15:04             ` Drew Adams
2023-10-20 17:59               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR10MB5488DD3F0C363E485053F871F3DBA@SJ0PR10MB5488.namprd10.prod.outlook.com \
    --to=drew.adams@oracle.com \
    --cc=dov.grobgeld@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jporterbugs@gmail.com \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).