From: Drew Adams <drew.adams@oracle.com>
To: Constantin Kulikov <zxnotdead@gmail.com>,
emacs-devel <emacs-devel@gnu.org>
Subject: RE: [External] : Re: [PATCH] Make rectangle-select able to skip lines(empty one, for example)
Date: Thu, 2 Feb 2023 19:53:31 +0000 [thread overview]
Message-ID: <SJ0PR10MB548890FD6505F3D8BE6F9155F3D69@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <CAFkz2yqYAqZk8_H=nkipthtbP0vt_OEBw-9jY4Msm=re_c=yPw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]
below
> 1. Lose the *...* earmuffs. Elisp doesn't embrace that CL convention for defvars.
I wonder, is it because Emacs had only dynamic binding? Maybe now the "*..*" can be helpful to distinguish dynamic vars from lexical.
The question is for others. I'm just pointing out the current (and longstanding) convention (lack of that particular convention. (I'm guessing "that ship has sailed".)
> 2. The var's doc should say what it means by "skip". Apparently it means (only) that function `apply-on-rectangle' doesn't apply its FUNCTION arg to empty lines. I think it's important to say that the var affects (only) that function's behavior.
I think the application of FUNCTION is the main part of `apply-on-rectangle', so it is more or less obvious.
And you can easily see the effect in GUI, when using `rectangle-mark-mode' (C-x SPC).
I disagree that it's obvious what "skip" means.
I'm not quite sure how to name the var.
What it does:...
The description is good. Thx.
[-- Attachment #2: Type: text/html, Size: 4770 bytes --]
prev parent reply other threads:[~2023-02-02 19:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 13:47 [PATCH] Make rectangle-select able to skip lines(empty one, for example) Constantin Kulikov
2023-01-30 14:36 ` Constantin Kulikov
2023-01-31 15:05 ` Constantin Kulikov
2023-01-31 16:18 ` [External] : " Drew Adams
2023-02-02 18:26 ` Constantin Kulikov
2023-02-02 19:53 ` Drew Adams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR10MB548890FD6505F3D8BE6F9155F3D69@SJ0PR10MB5488.namprd10.prod.outlook.com \
--to=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=zxnotdead@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).