From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: [External] : Re: Completions and history Date: Wed, 13 Apr 2022 15:49:49 +0000 Message-ID: References: <20220411112901.kv3lsyvx6yxwjbph.ref@Ergus> <20220411112901.kv3lsyvx6yxwjbph@Ergus> <86sfqjzhgl.fsf@mail.linkov.net> <20220411174031.2yuh2je5fl3lej7i@Ergus> <87ilre5i5a.fsf@gmail.com> <86k0burxd4.fsf@mail.linkov.net> <865yndxvzt.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16614"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Daniel Mendler , Ergus , Augusto Stoffel , "emacs-devel@gnu.org" To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 13 17:51:33 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nefHI-00045a-HI for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Apr 2022 17:51:32 +0200 Original-Received: from localhost ([::1]:58262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nefHH-0005Dp-4b for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Apr 2022 11:51:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nefFt-0004QN-1F for emacs-devel@gnu.org; Wed, 13 Apr 2022 11:50:05 -0400 Original-Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:53560) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nefFq-0002nn-3v for emacs-devel@gnu.org; Wed, 13 Apr 2022 11:50:04 -0400 Original-Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 23DF6wXH022836; Wed, 13 Apr 2022 15:49:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=EmBkm9WL6M+t3s2efNc/gpbF+uLYUjJMiAcMu5p0NGo=; b=pALKkqFLAKOeBY5lNB7gQarRBV2gJFfj+zAUMK7d5cWEV3YEzzYscwOFzhMjz8QpROh0 3+JHsjPMWaep7ZrINjCbhN+zFhYRhZBUxz4q9ETPVL+hTB+HQVcn8rsr5Fx9FqFNx8Nm 6UuyppNfZ3ALk2/cJBK2R4K0Qz1ukdwWqC1RuUqgLjOLujPjecVV9dnYEog6DQHO7q+P Uf4VqUElObMdTDoCA5Qtnrq159/fwKWsix1g/t1S/nrAMzTIDezF3vKA5Mnvu2FCdXy/ +6y6B5bAPu325p8ck0IQyDSmlpaS/BwSlBd01NP43ssdXP4Ivfe/nUHjYb8YIpeUwIqU 5Q== Original-Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com with ESMTP id 3fb0jda3p3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Apr 2022 15:49:52 +0000 Original-Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 23DFaNqC015215; Wed, 13 Apr 2022 15:49:51 GMT Original-Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam07lp2046.outbound.protection.outlook.com [104.47.51.46]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3fcg9ju73q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Apr 2022 15:49:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rns37GPM4FoSM+JWcUkiMmKOeASuHbS/mp+X8x+tnb7IhVoH5ZLFX5Y9nTE+7zVfNlwbAu0F7kXCX1Pn0BdpBit7jvDVJzZiPEMyuo1VzSBKIuzsdx0+SUpA/q+2Fb9CucrSdNfAF2ogbu7+UEW3U+0OXEPltfUm0RZXyil0LRG4s032YBhBRJtfzUaScNpLvDpw4Jz4wNsCuxymL2rWCDfkRS9g1OANMYwQFGl9sPyJ+AudOPhU8iXtquBAt0HGspIKIF4UrZMDI5Z/5yttZPZhAZHnyVhMjeES0KDqI16y+LxDH2vF+J4qrwqzAKC/dvSVccM5UUsxP/ZbCxk9Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EmBkm9WL6M+t3s2efNc/gpbF+uLYUjJMiAcMu5p0NGo=; b=EI08NvdHyAkN/iBVbkpG5QbjQpovzyhXvgdf7AS0xyl5Q2wyaj3a99lt0uFZg80UNcohYYtinLtqcUPpe+ptJSG6IP0/ethpVtMAnfTheALOLiNaMDCUvS5XWOx6YKZZD8ZjCKe/hRf+8EX/EGKJCKFtH8WYCk5gZeJMmrZEb4qfvdcLT5Dfbzl3gCDmMxp3/mvwloK5aNhpStdFjZNgEXtVZDKeiWnmkUt1xB34SPq0IgQE680fT/mYdWSVCARQvxGxOSZuCrFz3YCzI0AgOq49lVDX0jSdvLfGG+LD+b8q2YO2LdsN+hDsqJgW2qHhBPbILvDutWyEr4S8o9Ue/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EmBkm9WL6M+t3s2efNc/gpbF+uLYUjJMiAcMu5p0NGo=; b=XOkTn1eAzTk1eP+zA3cvMXLiDUYR+ZW1+JdX5dBJjulQcV2H61TPx64BqmkTWGD6OwtCyfiJreb9sBHz4LcgEgmKt6YEKwHWS6xIotqQNzZXOGcZPf0n8J0eQOCS7eTiN4GhB5dpOz+xpbt0rOT+sJiQOuy9dzvCP3HAQxRWK+U= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by DM5PR10MB1387.namprd10.prod.outlook.com (2603:10b6:3:13::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Wed, 13 Apr 2022 15:49:49 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::a0e7:5f38:ab50:5123]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::a0e7:5f38:ab50:5123%7]) with mapi id 15.20.5144.030; Wed, 13 Apr 2022 15:49:49 +0000 Thread-Topic: [External] : Re: Completions and history Thread-Index: AQHYTwuBnHvW+h3uLk63EP4BlLt7SKzt+W2g In-Reply-To: <865yndxvzt.fsf@mail.linkov.net> Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f05509a7-e8d9-40dc-853b-08da1d653dcf x-ms-traffictypediagnostic: DM5PR10MB1387:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b1d76bZ8dvlJWBEwOvxsHS+U91Y04gY07aE1rmj0QFDL1vdhttF0JZfV0PnvIH3CUtXdE8sggfvtG9s68v2qZ3zdDGFovVPfSzVfI83DTj5OrDIJlikrh4EmtmJiVHvWwR2U3M50hrHxOKbfGaCpF7l8calrVHh/u07n3k+GoRpWPYUsv1ulAnCXE/9WRlsRjXf+7THwurWTp1eSoV4U/SLeHmhUIBYaQ/X4yNJAlrnWmpFu4s3aVmgnMDaYueAvRYXO2HLDEK12WlvJoCRDHTvd2G8GWVSukEJjxY+XmxABMJvO+kLbjRmoHy8bc4mxk17PnJWkZLhaSdSTWcTXXEeFm08yugVzz/5aHqfanRiSR6OzpS5Jt0mqIIUWPyZOanPedEqoOgaeISD3tqZ3j0lwzD1WrFfbR4kdN1y6Y/BYqhAUeUb5FKYjB6HorDr/w3kbWLm8Elg7nrn8/LlpJA6rsNs66ZE/YB06GY5hOiMUZ4HGjZGmcowPzWQfENDW2m72zveProDxQyzcrWkfesluLiqGy0Fp4MlFfVcznqF7TOZAMHk8Etj3RSTrEWTKIETxDSrmXVJKA9zRB2NPJBv3ecDpoHA8U0F22LZ4OxQPG40bQWFjYoOc9UhZ06t2In/bDOTfgbCxrDqPGbfCmqQc9sQN0/6NxnxtWkCZAA0jAHOOdK0qdCINPFwe8FMVkeFOR2Dp20RiMEC0NYYupA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38070700005)(5660300002)(54906003)(9686003)(316002)(33656002)(55016003)(8936002)(122000001)(52536014)(2906002)(66556008)(508600001)(38100700002)(66946007)(6916009)(44832011)(6506007)(7696005)(186003)(26005)(66446008)(66476007)(4326008)(76116006)(71200400001)(86362001)(8676002)(83380400001)(64756008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OLxO6fs48LHN54WjlOU4fGbVbzAEL+07E83/9Lr6LytbQcT+rEtjpJjYOyFD?= =?us-ascii?Q?HlxvIZb9FwSGZt66iSLQ49J5gra1CXCIQVtvNf7Ety2AbEduzWaolYL7Zuj4?= =?us-ascii?Q?Wrr0Sr13GjyTZIbWCX6OyvinjoFEeMtg4M8juNS6Y3DNkxJsras8GRly/g4q?= =?us-ascii?Q?k80YH8WZsBgnmQc7NKtc6zCrDitJeDQWUU4VsTZM6CsL/fPwFi8LqN03hiKd?= =?us-ascii?Q?jNBZBHsap8813WcpP7hBx0K8ZcP0YVoVgzNbnOCUcXloB7HPPZbv+FRdp0hN?= =?us-ascii?Q?/4vOELmL/jKqS8SWHszkQxKtfMwbRFAL6lgiH32LoZUEUSfXFOwMg5AAHDYK?= =?us-ascii?Q?Di3wIXfgqj+IJYbPCh0qnUN6CCARSBlHKTWy0TT7MWKJZv/0OeXRcCpsslke?= =?us-ascii?Q?bU0KA4pamUt2dAqm+7wdquoUQ7blvnPUq91dBPX8mTfHLrE0bPwmsg0Iv+XK?= =?us-ascii?Q?KSWZeaolrl9UPbxn7b04bB63otkfgU3Hk9/l3ZV/icbLkZVcib00SGCkQ/CH?= =?us-ascii?Q?H71l57wfouMLfP0WpZs/29nfUv2EVKZtANU+e3F7iketUHCbNhhiRtX1Q5wn?= =?us-ascii?Q?dlQR45z3j64DTStUsg38aqt7Vfd+/KZZrUQuMM1syE9tA0awIzox+l4KLWZO?= =?us-ascii?Q?+i X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f05509a7-e8d9-40dc-853b-08da1d653dcf X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2022 15:49:49.1478 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: klYae1PCkMECHd06pebYINyFQH7rR2RDnwEkttFC5Ovp4k7omU0ctHDlsHt3nWHfcOfrESa/fWRIBTjI4roC5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1387 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486, 18.0.858 definitions=2022-04-13_02:2022-04-13, 2022-04-13 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=672 spamscore=0 suspectscore=0 malwarescore=0 adultscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204130083 X-Proofpoint-ORIG-GUID: 3VSBRupSOKqapH5zQ4veqD_dn2wGcsJy X-Proofpoint-GUID: 3VSBRupSOKqapH5zQ4veqD_dn2wGcsJy Received-SPF: pass client-ip=205.220.177.32; envelope-from=drew.adams@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288366 Archived-At: > > Command `icicle-comint-command': > > Retrieve a previously used command. > > Use this in a `comint-mode' buffer such as `*shell*' or > > `*inferior-lisp*'. >=20 > It seems `icicle-comint-command' does the same as > `comint-dynamic-list-input-ring' bound to `C-c C-l'. No, it doesn't. The only similarity is that they both let you choose a comint history item. `icicle-comint-command' is a multi-command. And it shows completion candidates in *Completions*. > Maybe the same key `C-c C-l' could be bound by default > in the minibuffer to enable history completion? Why would that be appropriate? `C-c' followed by a control char is reserved for major modes. Even if Emacs has recently given the minibuffer its own major mode (maybe a misfeature), I think that such a key is inappropriate for the minibuffer. The major mode that's really involved (should be anyway) when you use the minibuffer is the major mode of the buffer where you activated use of the minibuffer (at least at the outset of that activation). When in `comint-mode', it makes sense to have such a key bound to such a command. It doesn't make sense to use that key for a minibuffer keymap, IMO. > BTW, currently this command highlights the header line only partly. > Here is a fix to keep text properties by replace-match: That's orthogonal to the rest of your message, IIRC. It's a change to `comint-dynamic-list-input-ring'. I have no comment on that (other than it's unrelated to the rest of your msg).