From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: [External] : Re: master 431f8ff1e38: * lisp/imenu.el: Support more values for imenu-flatten (bug#70846) Date: Tue, 14 May 2024 15:26:54 +0000 Message-ID: References: <171558357066.26019.9766615061719600757@vcs2.savannah.gnu.org> <20240513065931.0D83AC12C31@vcs2.savannah.gnu.org> <86v83hwxjs.fsf@mail.linkov.net> <86ikzhq6ja.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18937"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "emacs-devel@gnu.org" To: Juri Linkov , Eshel Yaron Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 14 17:27:56 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s6u4K-0004kB-EA for ged-emacs-devel@m.gmane-mx.org; Tue, 14 May 2024 17:27:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s6u3W-0007WX-WE; Tue, 14 May 2024 11:27:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6u3U-0007WO-D3 for emacs-devel@gnu.org; Tue, 14 May 2024 11:27:04 -0400 Original-Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6u3S-00074D-8n for emacs-devel@gnu.org; Tue, 14 May 2024 11:27:04 -0400 Original-Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 44ECfu5d014525; Tue, 14 May 2024 15:26:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=1+1ePMf21sgwLzT33I3yZuKVDlfxTvtr22QUsHzwXtY=; b=Do7rKONhEySZWUfDvR76wRVDF0RclUefQEAqA6tOREItPIch1HfFwos5dayeoP5AYDue BVGSK6hMNg7Zb6you9ULEdflEHQsWMo9Qg0bkTMBEDsvoR1OJTYQZIWGJ6SzOy7kyR/3 xczFf7mcwzV0WoKqYmG2as9sNq/t4X7cohJZpMB/DgY2k7ZCqOLuHK84uBmxLj+QJxMF UaMhHgrJvEvWJ+mXeeac7YqJw0L2nRwc/+/3eUUggrVcLPOOgxi4KeB4u1RpNZjF+xfB 6uQ5xuxCz3+62FXaYtimAWIraHq9AVorpWATQjZOF1t4/tx3v4FHKntXioaHk+zhEEE5 xg== Original-Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3y3twysmhw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 May 2024 15:26:57 +0000 Original-Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 44EE7hQh005756; Tue, 14 May 2024 15:26:56 GMT Original-Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2101.outbound.protection.outlook.com [104.47.70.101]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3y1y47dmcs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 May 2024 15:26:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gl25bFEVnm+vrAlB+4rSxWb4ooDWfeTZkaFBHrCUV1oEO08k1FA/P0QIn+nBD11IDyeP6P/kArDcB5mIy3s0prlD9wJQHvu8rfF8t0Fg58uftHkcUphNHAUx+hQuXkTOk4byoI1XtLC+7nCaNfglAG9J85BRnYcFqThCzBqofFr0rSR1vHQvqiLwZfOpzRFqbXUHQAg1Kqc79hDJNyNu+8lR2NovxJuEZSpk3lGh4lMcXzjS/FzynWWe6qqjDUmh1FKgaQSrpP0E2iwnMoT/UqwGTCJ7CA3K3fz/diXVZ/emIUBVvROHuWGlqG1+9orH92+ZHUAFCL7fQQwLsQR0Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1+1ePMf21sgwLzT33I3yZuKVDlfxTvtr22QUsHzwXtY=; b=nD372b5lXraAeq/yBBDJ77v5l1fDk7hGJCERLN/GcUA9HQEioh2a6/6ijc2dah7iUejK4sw24HVUMvL/7CCnHzUZynhqIRdggKcxfqeO7WaJnOo8chSN+4luBn9qyo2YSsBSl7pLuIRkZrKoEjO5rsVlJ2n9Y/rzQ+z/H4rG1sJ8iJ4UfR6qqux0WmkvkLXQQ3mJxHzKmRzfHk92rB7uJ66345NqQqf9BU9hkdBCgaULPoITKhLnJXaccGNyFYk5RN8kpKtrG+B6x/bJwQcn1BRZ8GHnMkXJyqfSEGqzAUVFe/3DmAX05jXcYyPaMD5qy5vrgFuvsx7HMlb4vtq3TQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1+1ePMf21sgwLzT33I3yZuKVDlfxTvtr22QUsHzwXtY=; b=RT3Cj5dO4YungplNF2YMSptGKp/O3cEhGid9niFSIWF98o43W0XrBJXs6TnDybaSM7ZaoaQjCdmhNzzMJeMcjnII4jB25un+EJAA4YnGLyM3VgNbgxodQhLYQUssLZBKfpGyLV1/+z7K5NEKjIRXzxm5WngI5lU1zutiCaG06aY= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by SJ0PR10MB5664.namprd10.prod.outlook.com (2603:10b6:a03:3e2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.26; Tue, 14 May 2024 15:26:54 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::380d:4e6d:faae:a72a]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::380d:4e6d:faae:a72a%7]) with mapi id 15.20.7544.052; Tue, 14 May 2024 15:26:54 +0000 Thread-Topic: [External] : Re: master 431f8ff1e38: * lisp/imenu.el: Support more values for imenu-flatten (bug#70846) Thread-Index: AQHapcVC61iH6p1JI0yZBsIr2TMU+rGW0w7w In-Reply-To: <86ikzhq6ja.fsf@mail.linkov.net> Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|SJ0PR10MB5664:EE_ x-ms-office365-filtering-correlation-id: 0253f807-307d-4ec0-8274-08dc742a4925 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|366007|1800799015|376005|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?4UFjttf2mWxQTvEnTLgJeYiMBhXYWhyP98NOvrwrex3ZlRI3Smo9PFrGJfM2?= =?us-ascii?Q?t5QjDzsCYEzyHYwPVrLaPEKOCgJtqBipHtjU73+wqOsompQ+7BAQaUMo2cGi?= =?us-ascii?Q?jZjYZ1L1R9PRl2cr+RhhG5DrNQnfrnEuxpJiLoYULGNWGS+Ts4VFIOdKPf5J?= =?us-ascii?Q?+mlkCA+VEpVV6sKn3qTadmeBK0FX8K3vhwRRn9YRiR+QBWypjcMm3BSiBjaQ?= =?us-ascii?Q?MiHrAfC2/OVhDWHpg9EK3NqVXwXBIVrt+lH03Z78Iyabh24HHJCypQqPZoGm?= =?us-ascii?Q?rDdilm/UerXt6Fk+BCTt2eZv8MDewgyLLAEuKzPsjNBjXGrPKngUX9RqMJn+?= =?us-ascii?Q?B6pLJ+8D0RUoM+x1Mzou4fdhiEnYe9cyVqWRV+r7sYjD3OzHPu9LJNWrs6pr?= =?us-ascii?Q?3tZ7RA5rOFJshmz1dmzTOQIKgvxoBYeDTXBGmj6LgkKyj32VqUM7ViEtLbhF?= =?us-ascii?Q?/5oPnseACFZjxsOte7w565FAZ7YWU23SQwpR99V8FVl1vU58lXP7WTCjVyIR?= =?us-ascii?Q?hc9+u0pUsRzrdpNo4WgNWorUirCdFxgyWgLbUb5Y8jUDC8ssPVyre1Lxwbz4?= =?us-ascii?Q?XxK4ydgiguY98i+5JTKzW3fRXYSQ4TUX9ND7Yt8Z8C0L2FM/noyp0AWOiO0O?= =?us-ascii?Q?rFX6d x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1DWrhSwChob6u4+mWfraI0ixe0WNg3Lhxhi/jTdLYSAvCpgTCz/texs/OZFa?= =?us-ascii?Q?M7KhNFjGrV+PxBYjU9C38Vo6kfYql1P9KbLIfoEqipDMnZjDLjbWu/W+KLd4?= =?us-ascii?Q?SDNcVdA7w7lt1KFD9bktenWwYnHGK2sxWAHZu6FhC0c9gVB23wVSHOuU3rv6?= =?us-ascii?Q?6Bk+8MmVK+o1QJ/Gufx8nQvx0JZe9dyDmFUk2nQWtyJgltYVwrnLVgSZ0ke7?= =?us-ascii?Q?ScnT7UsCtilww3kGI+3ccnX5eLCIDbyenFGWOmEMnr4A3GfBsAzCgIkyF6YH?= =?us-ascii?Q?gJMZnGtbXPjSvzV8O8hOHzGdYVuy1Du4y6hFsHmI9KPaSdhgU5JC87/I01cZ?= =?us-ascii?Q?W/M56cXodfbJB3IaYp5vtOYPscF7y0fFRFHNHK2JjzUnRApmAX8uFtvHPgt5?= =?us-ascii?Q?KZBl1PtlfFjNNokcr5tKjg67hBSw9pg0RhTxMmGsijYN7xhzKoUlpuQ4r0a/?= =?us-ascii?Q?Dbgboa4q2EHSdw/hRDSz4R3myq5/MpvxDeFsgxfjf3TN2g9zxyY8WJ9Ty6j9?= =?us-ascii?Q?1ve7liBHnFedvizsEeLoX9Kg2qVHe23f1yw6HfWev+6mtF/QETTpwbSnLOrd?= =?us-ascii?Q?+l5cnrB+D8xTtk9Dn9N/6PogC1DYT2zy5p3xTWsfVuSMpCn6O2P6D3NZZYHm?= =?us-ascii?Q?xY X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 7ydGgYbaeKLLgONeZtXBWL905qEeYEZhYqYEeuGhtmvGHeHCxBSIOLBJjgEfrYM4hL4DNCAO0zggJ45A0PoZPRwfbh81BqcYNeUIgn1RTr6iocKVV85GCGcl/0jZn4HKvgAqNrweijJPR/LDLl1Jv8EHfpSEMlv940HCqHisYcNcP+ykj+p25RQBTrsSPDpShOVdTnsktwWm/hq0SNmp8O4e8xR5WwZF+xlXjRrc97pASB062iBdud1sW2IAt7K+daw6CEvU1Tn0LZupTBEQ8geJtPAkfLLMjwiddX+bsNvhGBcJ1BKJ7rIg9V+YsYQwX4Gn6SmtzFdor3SFKK1dple+OlffSX6IvF1ypcBlcKyrCuPscBxuh5PiIBZnVYRWhMX9bRPNfqZFOpXn38jhgwHuRyl8pWa4+wuXWxkWuyyX+XKC6z1kYCTWf9ITd5NmlfSPdJiLIiexuiacxHRBKOXUaMA1vgHQY+7/qJ990NUOgehN9pBzuddp5fc/F9EFXTdbc9YbCMNfooEqOaBxRERKmCm5Dc3di3KL7E9PTjT+oQ61HalIEQvPwf0BxTzpezJmAXTE8+4Gv/k1t3YC3/OGysWcANwU30byVXOkFXE= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0253f807-307d-4ec0-8274-08dc742a4925 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 May 2024 15:26:54.4392 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sHdID9yDqu7UH64B+TcP54MbavL10OryCKRA/6zVFn7DS0KZgjEHzYt6v0coX5GSsHKjZ4kV1yOWTMcNS901ww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5664 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-14_08,2024-05-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 suspectscore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2405140108 X-Proofpoint-GUID: 9oW0bqMmOqoFXHpw-OhLlKNtCfnbnsSv X-Proofpoint-ORIG-GUID: 9oW0bqMmOqoFXHpw-OhLlKNtCfnbnsSv Received-SPF: pass client-ip=205.220.177.32; envelope-from=drew.adams@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319225 Archived-At: > Here is a new variable that helps to disambiguate completions with > the same name but different annotations by using text properties: > (defcustom completion-allow-text-properties nil > "Non-nil means `choose-completion' should not > discard text properties. > This also affects `completing-read' and any of the > functions that do > minibuffer input with completion." > :type 'boolean :version "30.1" :group 'completion) ___ FWIW, since 2008 Icicles has had this feature. I tried several times, unsuccessfully, to persuade vanilla Emacs to add it, i.e., to allow the result of completion to keep text properties, unless a user option says to strip them. IOW, the default behavior in Icicles is to _keep_, not to remove, text properties. Emacs should do the same, in order to, as you say, let code "disambiguate completions with the same name". Hard to believe this hasn't even been possible till now, let alone been done by default. ___ `icicle-unpropertize-completion-result-flag' is a variable defined in `icicles-opt.el'. Its value is nil Documentation: Non-nil means strip text properties from the completion result. Set or bind this option to non-nil only if you need to ensure, for some other library, that the string returned by `completing-read' and `read-file-name' has no text properties. Typically, you will not use a non-nil value. Internal text properties added by Icicles are always removed anyway. A non-nil value lets you also remove properties such as `face'. ___ As for whether a user option is appropriate: yes. But I don't take the view that no code should ever bind a user option.