From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: [External] : Re: master 1b71c995da: Avoid binding mouse-1 in xref when mouse-1 doesn't follow links Date: Fri, 29 Apr 2022 15:34:15 +0000 Message-ID: References: <165123369667.6415.4605821518748112960@vcs2.savannah.gnu.org> <20220429120137.0F053C06322@vcs2.savannah.gnu.org> <87fslwdo88.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4653"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "emacs-devel@gnu.org" To: Lars Ingebrigtsen , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 29 17:40:36 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nkSjU-0000wZ-Du for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 17:40:36 +0200 Original-Received: from localhost ([::1]:37798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkSjT-000271-2H for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 11:40:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkSdY-0003uV-Dn for emacs-devel@gnu.org; Fri, 29 Apr 2022 11:34:29 -0400 Original-Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:7494) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkSdU-0007ox-Rp for emacs-devel@gnu.org; Fri, 29 Apr 2022 11:34:27 -0400 Original-Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 23TEMn4Y015535; Fri, 29 Apr 2022 15:34:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=OsNxpJDvW5ofJ+yhzSr0b62cjXLQoOLZ1GTwzlsggyE=; b=LcCcMYIstdB2QRVwjtREmlrKbU6qnRD045hEClVhYdD181B0HyKGUFjZThp3JdWit/1+ xb9f/1VVsu4M6Bp6IP0TfDTAT2sq1eDgxDmV/mrOfQTLru6YyIHErFrrtgQP0BE+j6Y2 PD5rP9T/Wq4oQxoIYpEstepegvYNLrzz6ivMUtRNweUeK8UEHpcLIDqhkjbcswWFK+M9 ZzWFbycaCWRwDHacJv+9NJtSxcSZUp+Yl9oNMkIWwrSlno4GvO99hzM7VJ8AVswnigxq Ojw7A3sEJ4jVhmhyel5wTTS5fMpCJZCy3qIhha+anNa1BvvKr+w/b9jCdCJF6P0g6GDx og== Original-Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3fmb9ay1u4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 29 Apr 2022 15:34:21 +0000 Original-Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 23TFBFDe007924; Fri, 29 Apr 2022 15:34:18 GMT Original-Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2177.outbound.protection.outlook.com [104.47.56.177]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3fm7w86nfc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 29 Apr 2022 15:34:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AgcL2JJUsQwuYNKszn0+/HUpMwauKbqAagFWu9NMLgO7KkDMWaQiIssGbSM88k4K7397BImTYzTaw0QOBQJ1+wac3K0UflqeC3c7AJCk6UMckvEE7XdkoM0ldy4pJrWB/Ak3EMWbKtuWYPsTbqZCjH7kaIuUpSSzBOjpApNG3THXIprWQ4IN/2J8bv+wwgRxK3Acy++FS9BGO/69yP0LkBHJUC9ee1sYFPg+FyEvN3Oi+QsjOdda/8eWE+IdSMDqO9TrUtjguhD4F1v2U6xjnPKWuVe1fkVkO7Zvg3PJ/6U8BCafg95v9qMOFxlvnMxaS4e1hG3HRcQf9SYbhjGPzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OsNxpJDvW5ofJ+yhzSr0b62cjXLQoOLZ1GTwzlsggyE=; b=bNWDaVC7m3r389TJBQEaNUYFyHccmqmKGyzMwE2CRau0/BxIdu86Vm73FBxzxy1ArgwOwYXQXMvxBauqnQ6fYfZCLxZS4wOE1aIvDSU9qgab+lxqgNm0r3nKQdRDjz60cDfC4gecW6KM/RiotSJwd+tEyFiKJ2wfJ4kvG9Vi9zsjBb6fEJ0Yn3z4Ph5MhRsM5PQ2K4fa6GMkhMN7jj5jfdLKCKY7kCsJn1bYZWgtJobWXjWUxj2gnaGzbeLgepyym0D0+Hml4Ci5gEY3DW4YlGbfwEmZhVzdR1MZK6wrlTJiqhmn0yr8OYak0khIVv0A+WbLPxd2y7pefG8P5snY2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OsNxpJDvW5ofJ+yhzSr0b62cjXLQoOLZ1GTwzlsggyE=; b=b9oHNkcwLL7ZJX/eUNC8EEnHBayDRgLODNe4+wwfvL+iBxBajV8S5cW526B5nw9Z8b9szJuups6NUJyhqJgrWhqiO/Bs5aboB7qO0F00U2fEIxpyRpx57DOPmsOal7T9BsT1iVu0xXwSZG0C/nwn5yZsyo2RZUiA5QRubKHJgTI= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BN6PR10MB2004.namprd10.prod.outlook.com (2603:10b6:404:fa::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 29 Apr 2022 15:34:16 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::a0e7:5f38:ab50:5123]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::a0e7:5f38:ab50:5123%9]) with mapi id 15.20.5206.013; Fri, 29 Apr 2022 15:34:16 +0000 Thread-Topic: [External] : Re: master 1b71c995da: Avoid binding mouse-1 in xref when mouse-1 doesn't follow links Thread-Index: AQHYW8t0mQ/mjwj1SUG3mJ+yzMfGCa0HAsXw In-Reply-To: <87fslwdo88.fsf@gnus.org> Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6dd53229-daf1-47a5-aa58-08da29f5b82a x-ms-traffictypediagnostic: BN6PR10MB2004:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iSmdU1ILs5hj9DaOXz0UGgryql9qIPIh+qhuQfDIUUSpOIuLp39B/MIx8wGYToFGPWdC4plI9g0M87pU00neX9MxUsBVnvJ4oJa+K9gqV13lp9NKlCs7UwSn571grUvpG+Jh43ph7PwnlvHAuPx2iefsmaa2FUseK3wjr0tisZHjxRvFCFyUKDI9pyvyWIPqDPbGIlHjXpuBV9MRMeD6aNBHjPb55ZdkICowxjxvzMtpV/J00Z5DoMECpI3v14UOmO2MvZJ6G4vymxsiLk7OUfxB7hpS1IQPyyUdkK4wf/ltzVltC0y4pUOhYBHTQXo6g5S3ZwZ6juWj4hgFwt9jRnL2cEklL098kaRkqlkaz3kh+SjaBIgiWiHrtjyYcPpNd4djePsJRIX/CdRD3Sk+Uvh2GwTm8GCIqMB1E+z/xsTWP5TX2VbigNUVmJwiwKxKwUuji/KfoiYQSAtcOVJfmni7yAdlndNFQ/gvcBmNVDOXEKelIWO9shwhssx3OvqLgI7EhlgJf5kDn63307ecvpd2khD06C3vP1bllLZ+/2sUvty1TmYJo3gKYsH2zgArt6qtnLkglFfIylV8kK+46ZL57EilgNPIjSviRRNGcAUEU3VHaPy6MQ5tl/RTgFJpR8YGt1repCAEc00hePw4yfmHfaHmegUhE+6QRzgyT2VnycwgTFUGV6NYUL9ImFPuYFom6zpm8XeYEABCJJLREQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(52536014)(5660300002)(6506007)(8936002)(44832011)(9686003)(55016003)(83380400001)(122000001)(33656002)(186003)(86362001)(26005)(38070700005)(38100700002)(7696005)(71200400001)(8676002)(508600001)(66556008)(66446008)(64756008)(66946007)(66476007)(2906002)(76116006)(4326008)(316002)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5feATFbpEfN+N6LUSLMEWZGrGwRLhVqIIG177QTJtO/fHqCbPxhNJ81sisDg?= =?us-ascii?Q?7pECpZzRRhI8Vjo1YCbyzq3KP3vbHS8xcGqhUe0Rlwp8Qs1yYSaWaymzpGvD?= =?us-ascii?Q?dyVGjiuF3cgCkfA4A5oMhaCsOkNVjX/oSpgvD1vhEy14TZB84FVWQAYO5uW0?= =?us-ascii?Q?b2cvcRK121VIx3H/8UnTVVyoiSRWWy6MQn5gkMyyMpR1qqPGkSKqJ4Lr1p6r?= =?us-ascii?Q?2c1qkCf/TpwiLaEnZ1n+qlYM/FxBALM7w5qex+5qPmc1LfBJ6zsccMKzZZwG?= =?us-ascii?Q?5QJQwewJe4uWdN05DjaDTz4PDkFr4J6KbRPoVApxaIEVjwz4lUKpcsT4tUJq?= =?us-ascii?Q?gz96vtnk3mwUJ4MNkGr6vgcB5Vwk4xlF3siScpGOvfWF7OBr5rpdDfgvAf0m?= =?us-ascii?Q?9x9k8u7qgdupl72OCfp7aAYnFk9+8RP5ZDf7WP3a+qsrDilsITFVxdjwcnzl?= =?us-ascii?Q?1S6VsalO6GQsmZSvN87dHKUpubn+mYja/CVFRMCdWehFnTrNPov1VcnSVFdS?= =?us-ascii?Q?OTnL2uRoTkF7TK7uQAbjnOKA6tbY0PUweliUQP6uI6QPfeIBxkybN6c7ySHH?= =?us-ascii?Q?yfSr8SZyF9S+R98IyZTPYATAP8PhHPhzv6uk1DB1hLaPBA/BZy9lROCG14kL?= =?us-ascii?Q?Jf X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6dd53229-daf1-47a5-aa58-08da29f5b82a X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2022 15:34:15.9251 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GBXnkmylMfSKAQxYCjYklp3F5KhsJ7MEvazCO0dvUK1lPPikOM0qk5e/vNz+KbhEI/oZcUIX0km3GgQaa8lcQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB2004 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486, 18.0.858 definitions=2022-04-29_05:2022-04-28, 2022-04-29 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 adultscore=0 mlxscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxlogscore=962 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204290083 X-Proofpoint-ORIG-GUID: OdTaLlpPD1ik0s-9szLECjOWJ1rxfRic X-Proofpoint-GUID: OdTaLlpPD1ik0s-9szLECjOWJ1rxfRic Received-SPF: pass client-ip=205.220.165.32; envelope-from=drew.adams@oracle.com; helo=mx0a-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288999 Archived-At: > > Hmm... this won't adjust if `mouse-1-click-follows-link` is changed > > later on. Why do we need this `mouse-1` binding? >=20 > Dmitry seems to like the two different actions (which only differ in > whether the other buffer is selected or not). I'd be fine with > removing the mouse-1 binding. Bug #35353: I use `mouse-1-click-follows-link' =3D nil. (I use `mouse-2', not `mouse-1', to follow clicked links, buttons, etc.) But this setting seems to have no effect in buffer `*xref*'. Except by clicking on a file line (it seems), I find it impossible to click `mouse-1' without having Emacs follow a link; impossible to set point in the buffer using `mouse-1'; no way to just click buffer text to select its frame. What's that all about? For which you've said: Lars>> we don't honor mouse-1-click-follows-link. Eli> FWIW, I don't see that as a serious issue in this case. Feel free to close as wontfix, if you want. But you said today that you fixed (this part of) the reported bug, for Emacs 29. I hope so.