From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: [External] : Re: [PATCH] When deleting in bookmark menu, prompt for confirmation. Date: Mon, 3 May 2021 17:43:26 +0000 Message-ID: References: <87a6pcqy7s.fsf@red-bean.com> <83czu86o46.fsf@gnu.org> <835z006jpl.fsf@gnu.org> <87im3z3f8f.fsf@red-bean.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27501"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , "emacs-devel@gnu.org" To: Karl Fogel , Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 03 19:57:34 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldcp4-00073i-Ff for ged-emacs-devel@m.gmane-mx.org; Mon, 03 May 2021 19:57:34 +0200 Original-Received: from localhost ([::1]:43020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldcp3-0006nD-Hm for ged-emacs-devel@m.gmane-mx.org; Mon, 03 May 2021 13:57:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldcba-0007Wk-Ph for emacs-devel@gnu.org; Mon, 03 May 2021 13:43:38 -0400 Original-Received: from userp2130.oracle.com ([156.151.31.86]:44036) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldcbU-0003t3-SZ; Mon, 03 May 2021 13:43:38 -0400 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 143HZhrT002122; Mon, 3 May 2021 17:43:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=tOyWC4P/OTyOQVWgFclbEHp1pvfixqB/ur9O1mQtlQg=; b=Vz8PPgdOITUfRfw9c8XtB3M45vmdPDs86A0r/YKUT6jq2pfzACawlpKFdkDpl7Ag9LhV aHw2Ba2JVQ4gZoqzcStvCjhpTu8kmc0OqdumUwxWkbcLBUB54vsFgWrien5O7uE4I9Oc d88tURlydWlGm0NeNsas5QcTWRzl94d3Yn9bzIzhcMppWzg0Rp105BwBE0G3oX15/R5e k3MVtfNu9Ilkmm3LXxsyBNCSPkhOqGFWSMnEpic0ujxWq6L0bC2qtfbtYwdQT9Rnm/Ba OF+L4MOzVKLkZ/fBmbEkLgsYZdjiiytbfw+PwrN1A/IydoPBgRTLlQysRz0ZOv6mYYsZ sw== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 388xdrvf50-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 03 May 2021 17:43:29 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 143HZHDn025460; Mon, 3 May 2021 17:43:29 GMT Original-Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2170.outbound.protection.outlook.com [104.47.55.170]) by userp3020.oracle.com with ESMTP id 389grr0bnd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 03 May 2021 17:43:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GwclcjbZIBe/5t9td7NpY2w1Ly/wQ6xOxkFzDneeSYx5+mLbWcsJVdc8xiwbCQF2WnSr6ehXDZnTNHzfsbRmfd9VNMYAOrtzL54ybbIp0XNKN7JNpg2GPmbI0FCfdOHCpzycBfJL6wopwElzaLnVUXM1AHGtlR9HGRYu7WRkI7nVMHSZCaoBJeBbuUQIEHcU79Gs13HiWof9sbzZCcaSyYVviAxitxJrcc5o8QwEacPUeZWmQARx8qRPWUSBVN6svcCdFr7ddufF7S0ssUcEMILBvoUjGliGQfejy8a7loTNKssRF50V2i8OPbPOl+cbbX4SfmPnl1xTu42/echCuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tOyWC4P/OTyOQVWgFclbEHp1pvfixqB/ur9O1mQtlQg=; b=VLV/nF1xJYiTCR3njGygEjrA2DMUY0XYXN02c/JnhMgoABmoTTUVmXJYhO89T8rYYckUhzdN5FgY/WKc+fjwob8AedIX8Bc2UcpQmTgn4H8Jy8h5IWwQzXLAavDqjF025l0+1tpqfQGtebZE/wcZYb0ykZyxSFVc/bHS5fS8wEktgmpxPjHSk2W6OeT9mRAX37EuhwvNa5ojB8HhnXdQ5usL4tRh4w0jqv6Dn+sesMe4JCBtPvFz0k1yF1PH/0Y9cBnRU6yC2mJ6Wb4hoZP+H/VSbOwzp6VwjIanyJNRLi1DSwqN+1yuUYOkz1J97hYBLhz+/M72Nca0Uyskn1lLVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tOyWC4P/OTyOQVWgFclbEHp1pvfixqB/ur9O1mQtlQg=; b=MxZXOYFZoweB5+Js8oqslIxq3QrpgYCACZCgNZUZpjhLMllFQbcwA7n2JprnZHWLtNSoqyTwtVf2MBRoLXGSEE3cLn9EsJFWqCrUrBlfJdHp45WQincaa5SxfedyylwA/KXUpsgACLgsrFZiMUAJ9fiLdZfw+FtI8saGenUFdrs= Original-Received: from SA2PR10MB4474.namprd10.prod.outlook.com (2603:10b6:806:11b::15) by SN6PR10MB2736.namprd10.prod.outlook.com (2603:10b6:805:44::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.23; Mon, 3 May 2021 17:43:27 +0000 Original-Received: from SA2PR10MB4474.namprd10.prod.outlook.com ([fe80::2109:9725:fd4a:6494]) by SA2PR10MB4474.namprd10.prod.outlook.com ([fe80::2109:9725:fd4a:6494%6]) with mapi id 15.20.4087.044; Mon, 3 May 2021 17:43:27 +0000 Thread-Topic: [External] : Re: [PATCH] When deleting in bookmark menu, prompt for confirmation. Thread-Index: AQHXQEJr5dIWnDnxW0e/B4mvNjaWLKrSBRcA In-Reply-To: <87im3z3f8f.fsf@red-bean.com> Accept-Language: en-US Content-Language: en-US authentication-results: red-bean.com; dkim=none (message not signed) header.d=none;red-bean.com; dmarc=none action=none header.from=oracle.com; x-originating-ip: [73.170.83.28] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b4198547-9df8-40ad-f250-08d90e5af508 x-ms-traffictypediagnostic: SN6PR10MB2736: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: v+aOCredNw3A32PNm5emWKfqkk0jESCW/Vsuy/0u0UdO1P2748yDOUDCM6u0HdaswhnHi0qEFGpTPy2A7wXNHKWLLGzt8EUXL9Ycp41PK0UweBptl7X0QEzJzMIXtpE7OtO0ZTcRvP1YFoMCVqZRxUYqeDM/3PxBxj6rhW6RrB2EKyNGIhnqs/BgGE/J0xI8Rc4OXZiMlEXcwURpkzw9x7EZEzoLYcvxhKu8N4xtmdYLRNy7Zzqspqf6GH1Mjz1z6ZYJ1pE8t5uZjLZbh4a3TZnR3gKmQbMz61xuIvr1386k4mg2ngZErATT1oYCwX3npUhu13w80AY8Cg11NP2lRXsnUfTiHLjxKCRqbMmqaMWM2syoJ1tlvxZ+VZQiqpC1tKdasazyxoVBZxKFfFkrQKTgkuB66aQVLyulNgI2OCXdXXA1KQ2ceegR1nC9KKWjKVNUS1H5qrwSVl6cIUdLblqFpumdoSZRHwn51Ls/pbaZFg5gzr10Q0hb6ahnmhbIUBQpotbFB5NBpJqxOTIY3e++vr1myt21NB3lTO5V1zbCuZNgGM+AiIgtAX9LLwXGLlBPrMXjFI2uEYZByjNGIpAdgDKociCx3tOYSCP1Lfw= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR10MB4474.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(346002)(136003)(376002)(366004)(396003)(122000001)(8936002)(44832011)(33656002)(4326008)(55016002)(26005)(6506007)(54906003)(7696005)(2906002)(66556008)(52536014)(38100700002)(66446008)(71200400001)(76116006)(186003)(83380400001)(66946007)(9686003)(5660300002)(8676002)(110136005)(478600001)(4744005)(316002)(86362001)(66476007)(64756008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?UJriqY2aKXhP5OQYHoksTlE61s4MsmRvFhFIwwmse8cg6oIvXaMPkh0+E88c?= =?us-ascii?Q?rLnt5IK8XwsGO0RWuYOwpJ9bHgRAtUy7hhSSJyH1Y8NBGlORDYzUCKHBG88C?= =?us-ascii?Q?ApD4GuEpLg9iIyqHdFmP2iVUAlf0lRD0bOu/GHT/2x/gNjM2n42hVtb9+n56?= =?us-ascii?Q?bBcvfRp6yhOORc61SN0/hNp4hLr9vsmM25aXqV/bMSJO6nSlRJjWHc3nNLGY?= =?us-ascii?Q?f4wlIF535W+DczpJoBAmoa6xfrNWUm3EXFDz+lzDoNR3PWdDcf+lIGMCnurL?= =?us-ascii?Q?DeLh6VaJF9B5rW/THXhZom64lidjH7ZI1PKmqij1rwUr7OKZXry5WafO+qmT?= =?us-ascii?Q?N9Aq1AQ3TWiwDqO5r+QPl508bKv7LOaPPPQ14SyaAPV/VRULzyYb1REQySOC?= =?us-ascii?Q?15EDH0qBI7FqnHuc8d+5LBSCo0E5SbZbSavPsTyrKbAb8n61Kj1JdgtmB6x4?= =?us-ascii?Q?4529kdWeT8Lqxdo5VNoRQ5Ur+N+1XJmaXWK5wn3Zqw+B5NOp8kL7iZ+UCDCT?= =?us-ascii?Q?UT5c21Dx9tSO32QXzPHnG3RnjHei+VpfrSE2xJxAii7iK2VDsE5ZqYicFJUR?= =?us-ascii?Q?dYdjlJ9xNEL2qI2IODPjgZUEVeZ+GRnQILAbp9dY8Fb1/zRtUQgE28HZKBzb?= =?us-ascii?Q?3tAD x-ms-exchange-transport-forked: True X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4474.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4198547-9df8-40ad-f250-08d90e5af508 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2021 17:43:26.9430 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2m8xzdrCc6yj9K5VVRfeen4qM6H8iRpXYmdGk7WvpfFayfKttqCWKG2rM4sb9C7j/v/mq8IaQEXrB9PqHdPCkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2736 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9973 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 phishscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2105030116 X-Proofpoint-ORIG-GUID: P9603lox9aDzeYjSTS7gkJ24CJn5Y73m X-Proofpoint-GUID: P9603lox9aDzeYjSTS7gkJ24CJn5Y73m X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9973 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 clxscore=1011 lowpriorityscore=0 adultscore=0 spamscore=0 priorityscore=1501 mlxlogscore=999 bulkscore=0 mlxscore=0 suspectscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2105030116 Received-SPF: pass client-ip=156.151.31.86; envelope-from=drew.adams@oracle.com; helo=userp2130.oracle.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268830 Archived-At: FWIW, I agree with Karl (and others). The strongest arguments are: (1) Dired asks for confirmation, and (2) it's easy to accidentally hit `x' with flags (`D') present but not visible (e.g. scrolled off window). I haven't done this (yet) in Bookmark+, but it's a good idea to do it. If you add this option then I'll update my code to respect it. ___ I'm not even sure that we should bother having an option for _not_ prompting to confirm. (And that's rare for me. ;-))