From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: [External] : How about making `set-minibuffer-window' obsolete? Date: Tue, 16 Mar 2021 19:42:11 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16093"; mail-complaints-to="usenet@ciao.gmane.io" To: Alan Mackenzie , "emacs-devel@gnu.org" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 16 21:02:33 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMFth-00047B-Ri for ged-emacs-devel@m.gmane-mx.org; Tue, 16 Mar 2021 21:02:33 +0100 Original-Received: from localhost ([::1]:54116 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMFtg-0004MF-Fg for ged-emacs-devel@m.gmane-mx.org; Tue, 16 Mar 2021 16:02:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55644) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMFaD-00044I-J2 for emacs-devel@gnu.org; Tue, 16 Mar 2021 15:42:27 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:36688) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMFa6-0001uq-FY for emacs-devel@gnu.org; Tue, 16 Mar 2021 15:42:24 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12GJa1Bm102878; Tue, 16 Mar 2021 19:42:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=P08vKvLi5JrrqafvwBY3VXBdOIqUZN+P9LK7XhIBMDk=; b=Q7Yk2saLIVzl4EPFRj5TqU9itPffmVyFjRlrAGGMrKIQtfnzHRCNSSwIu3v4ketDQx73 vnZ2l19t+o4Kn8ZDa1xOv9JccQ1NMkUoTjGGuj8uQk+ipTmZIT7LBP+0l905jUqm0Wld M+rU6/YzP4VrmULL2fHUOxaKYV5b0cLQi8EhfR01LdT/o7EG6Cp7xK7WOOKD4qvHThy4 YDS2EqTh42QR1e7oPfHGhRScwkviQTUj9ZuR7Qvr3MJaVIQwYfmzehP2Rvk0FaMaXmqr 1ESsKKLm615Q/FCynTvT7h0E8yzRiMrRblzlv3AHjN8To93uBNYS1EMckNqmy2e/Z6+9 jg== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 378p1nsrnk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Mar 2021 19:42:14 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12GJagtZ085300; Tue, 16 Mar 2021 19:42:13 GMT Original-Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2104.outbound.protection.outlook.com [104.47.70.104]) by aserp3030.oracle.com with ESMTP id 3796ytwf0s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Mar 2021 19:42:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iibYK4Md3G9RIep5PoAGTSdECjOlC7eqtODijf5G+EEdNrhj5HRNIGhBjTpak5AFdls32AnCOWj3pfuT8DkL8Q+0/4kyuiRa7uOGELQD8evS1PLPxt5dt/eMxc1WJY6Ikb60nvHbrhM64nzT4q+A7b5gJfiKS2SEDJd+0rnGPeRXFvXMLrBhKXEy1UhWwadtDgEmV6e9J3gLoclfHpfsi+OU4wIx5c++rmQLO20KwWWEGFDZ0NllqDViYXBkTfDxI549kW25sGmwLxl6zKREEdNwWjJeReNQKtczvlCz3IuIHiEa6y3XktkLUB1yTOLOxsnqVaUE5GAssxLAxF6jcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P08vKvLi5JrrqafvwBY3VXBdOIqUZN+P9LK7XhIBMDk=; b=cZIG01/rezOBmFj//MvrDOJnhKNt9yiWGKIEYpp6/IaA/aDw3SsjIoiPCTTRr7Qh5TcHnTXarLvRrfQaEEkJnusEeJPfc5pqJYR1/d9BWR2FXmryOWzIUwTE6FMZRg5IJEJG/AC9F1nNja3Y0NmxS9x6X/LDT26Vycqd9tzRdTfKc8UQgCbq3GZ5+TZiuasbF4qDYNN00DPwXaEesLpkMiGL45jXfTqtYw76uhK2wXzm339K4MRU7cRnWwqomnSgDSZBL8YWvcaa6KmQcfcynihUM7rYEo0M0Q2poMzP07t17JaVG8cVq3t2Qd9ydwYiCjX3CdEUePbsrGiosPlkPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P08vKvLi5JrrqafvwBY3VXBdOIqUZN+P9LK7XhIBMDk=; b=KSt7Sgt8J1No4pmFIvMekV6yJsgNl7vcXVfpnZsxcYDmGgl+mglTylkL0PoXWSuQj2UCScgP3P716BzLkPNMi/VCU7VHCSQ/e98fIsrB5h1LNWGdsidM1S9ZscyFkwbnkD1Ky2w7SCi6muTlV1DMXBnRy4W4t2JDXnUYhgCznJQ= Original-Received: from SA2PR10MB4474.namprd10.prod.outlook.com (2603:10b6:806:11b::15) by SA2PR10MB4507.namprd10.prod.outlook.com (2603:10b6:806:119::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Tue, 16 Mar 2021 19:42:11 +0000 Original-Received: from SA2PR10MB4474.namprd10.prod.outlook.com ([fe80::b8d2:db6d:3e4b:d315]) by SA2PR10MB4474.namprd10.prod.outlook.com ([fe80::b8d2:db6d:3e4b:d315%5]) with mapi id 15.20.3933.032; Tue, 16 Mar 2021 19:42:11 +0000 Thread-Topic: [External] : How about making `set-minibuffer-window' obsolete? Thread-Index: AQHXGpLg3bLfbq57rEKbPamXiUbOVKqHAnfA In-Reply-To: Accept-Language: en-US Content-Language: en-US authentication-results: muc.de; dkim=none (message not signed) header.d=none;muc.de; dmarc=none action=none header.from=oracle.com; x-originating-ip: [73.170.83.28] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6b1a8264-61de-4a7e-a2d1-08d8e8b397a8 x-ms-traffictypediagnostic: SA2PR10MB4507: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UgG3i4N73X47MSFz2UjHAYZbNYdy/TJRwGoLqTePQGeoevQzwPkHJsCoWt9MsgA+7GvIrSrIkcA48dk7jYBwKJf2uy6qfXlFtsKxtoZDLyQINTyLNkkfv7malyq0uR6Lj3vzmCfLDS+BAvMe/Qt/KdUIm+6TN/1d6zoXsR/s+Z89uvqhrqqobDIYz+BMaKDwl9Nlsrx4xFC4BpyWlRY9WTz3RF0cPFrsRExrTmjdgjcMxamuin6NmK0g4p3ouN6kYXEZix/Ma9Sc46Nl3MpCsE0xW6Ch1uvNFGWEnu6Ai9Yd0s5DAvOnIUeY5LYTyNEhxdFkvuL9hegkByffejYTNy1xJeM/gjbdYbF/UzyCA1X3Pst6/GxMzFkxA2XfrBysPYUtlTXKaj4JPCAQO5TEBG4g+GlVWdvwgZ6j+zFjFrH7XehYPin04mtv38cnWoDEsg6cDt2GuWfTShk5PU57cN2wNE4kZb0f8Ietx7fCpy88It+3E0ri6oLkfXWnCRnvMoMGeJe56ZzewnTgiAMhM3ybviVLzvwBA6cdLWv7ld+Yd/tdLkGlCbGOZ9TTGapfyE5U4vN8CFrhSThZuD3zxJun/OpKdrFBU5aIludMeK0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR10MB4474.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(136003)(366004)(396003)(346002)(39860400002)(9686003)(55016002)(71200400001)(66556008)(44832011)(2906002)(64756008)(66446008)(26005)(6506007)(52536014)(478600001)(7696005)(110136005)(33656002)(316002)(8676002)(66946007)(76116006)(8936002)(186003)(66476007)(5660300002)(86362001)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?2hF0XrJiTEBcENO3WIyQO2BltQnoHDQ4pBvHzDwDjFQlyk00KAcpjJN3+7cQ?= =?us-ascii?Q?J9E4qeBFJbaWJpaYuP27NmY9OUpTE2Yv8KOorfy/Ci16dQkKMvM9tKrMgX+O?= =?us-ascii?Q?mkqZrjAyBMMRA4arwCEZam22mgic2RPj2PYIaj7RW1c8T6q02fw3zypq+cQn?= =?us-ascii?Q?KMQg17MRbX0GgJdN6CYk5/ZMq7K0JhWm9WLCSIyotOQq97pbwxLoL7QanQmg?= =?us-ascii?Q?gVUC8d2xJ5+HnNYq1PjdqC0eT2iQuQLeOkENgNo4VW8ijKIteiQwHH0OFmof?= =?us-ascii?Q?rKvf1+wPT4Hs7MJbVThnssvwM7rRWmC/dNs8UDR/BUjrgWrSX800Gh1krq+s?= =?us-ascii?Q?SnnHYoaezF7SrOYzI0yyYZJ+w5ZQVseT//A+fOI/zijEnjbS13q6L1gmUbHJ?= =?us-ascii?Q?ipIYCN4jlrQvz1aEh5RCEZfQMEuJv7AOuCZaO56o8gWQ2zXxbR2T0aUKy03P?= =?us-ascii?Q?vpg4stoCLFBRysafg4Bs1B0k6FptuJqTHOjMkff8vct9ZkMxiXPVVNGPIOQm?= =?us-ascii?Q?Ih5/RWolWVGEhiiX4XVHESAHd2FSCL//kqdM+HXaMU1CRUCuXA50/kz0kcVb?= =?us-ascii?Q?h/qINWyzQcL/gyM7l6uK6NvyWROKRoTUjdZBdfaofqryik0vppKxFrjX3igd?= =?us-ascii?Q?0BmO x-ms-exchange-transport-forked: True X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4474.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b1a8264-61de-4a7e-a2d1-08d8e8b397a8 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2021 19:42:11.3529 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nToMuhzM/UAI5cIg1aRg4XKcM6TZ2dK8rZ6wPYQy7H00lqR8FRewfc3i8bMCRDOUBoSafBRNJZiKG/CrCQI1nw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4507 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9925 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 spamscore=0 bulkscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103160122 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9925 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 adultscore=0 spamscore=0 clxscore=1015 phishscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103160122 Received-SPF: pass client-ip=156.151.31.85; envelope-from=drew.adams@oracle.com; helo=userp2120.oracle.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266505 Archived-At: > Does anybody have any objection to me making set-minibuffer-window > obsolete? >=20 > It's defined in src/minibuf.c, but not used by any C function, and it's > not used by any Lisp in Emacs itself - the nearest to a use is a > commented out occurrence in lisp/textmodes/ispell.el. >=20 > This function just sets the C variable minibuf_window. This variable is > defined (by comment) to be the minibuffer window of the selected frame. > So setting it to a random mini-window will cause nasty problems. >=20 > Actually, I'd prefer just to remove the function entirely - but there's > always the chance it's being used by some external library. >=20 > So, any objections? Thanks for asking. Hope anyone who uses it gets a chance to see the question and respond. (How to know?) I don't use it, so a priori no objection from me wrt my code. But is the _only_ reason to remove it that it's not being used in the vanilla Emacs code? If so, what's the problem with keeping it? If we keep it, maybe you'll want to add a comment saying "setting it to a random mini-window will cause nasty problems" or what you had in mind about that.=20