unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Alan Mackenzie <acm@muc.de>, "emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: RE: [External] : How about making `set-minibuffer-window' obsolete?
Date: Tue, 16 Mar 2021 19:42:11 +0000	[thread overview]
Message-ID: <SA2PR10MB447400B5AF36707494895E2EF36B9@SA2PR10MB4474.namprd10.prod.outlook.com> (raw)
In-Reply-To: <YFD2A3cnEDSa3DM4@ACM>

> Does anybody have any objection to me making set-minibuffer-window
> obsolete?
> 
> It's defined in src/minibuf.c, but not used by any C function, and it's
> not used by any Lisp in Emacs itself - the nearest to a use is a
> commented out occurrence in lisp/textmodes/ispell.el.
> 
> This function just sets the C variable minibuf_window.  This variable is
> defined (by comment) to be the minibuffer window of the selected frame.
> So setting it to a random mini-window will cause nasty problems.
> 
> Actually, I'd prefer just to remove the function entirely - but there's
> always the chance it's being used by some external library.
> 
> So, any objections?

Thanks for asking.  Hope anyone who uses it gets a
chance to see the question and respond.  (How to know?)

I don't use it, so a priori no objection from me wrt
my code.

But is the _only_ reason to remove it that it's not
being used in the vanilla Emacs code?  If so, what's
the problem with keeping it?

If we keep it, maybe you'll want to add a comment
saying "setting it to a random mini-window will cause
nasty problems" or what you had in mind about that. 



  parent reply	other threads:[~2021-03-16 19:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-16 18:16 How about making `set-minibuffer-window' obsolete? Alan Mackenzie
2021-03-16 18:42 ` Eli Zaretskii
2021-03-16 20:50   ` Alan Mackenzie
2021-03-17 12:57     ` Eli Zaretskii
2021-03-18 11:46       ` Alan Mackenzie
2021-03-18 12:01         ` Eli Zaretskii
2021-03-16 19:42 ` Drew Adams [this message]
2021-03-16 23:04   ` [External] : " Alan Mackenzie
2021-03-16 23:00 ` Stefan Monnier
2021-03-16 23:24   ` Alan Mackenzie
2021-03-17  3:31   ` Eli Zaretskii
2021-03-17  8:44     ` martin rudalics
2021-03-16 23:17 ` Dmitry Gutov
2021-03-16 23:28 ` Stefan Monnier
2021-03-17  8:44 ` martin rudalics
2021-03-17 13:17   ` Eli Zaretskii
2021-03-17 15:36     ` martin rudalics
2021-03-17 15:45       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SA2PR10MB447400B5AF36707494895E2EF36B9@SA2PR10MB4474.namprd10.prod.outlook.com \
    --to=drew.adams@oracle.com \
    --cc=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).