From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Shynur Xie Newsgroups: gmane.emacs.devel Subject: Re: Bug? Date: Thu, 4 May 2023 08:35:40 +0000 Message-ID: References: <875y9aciir.fsf.ref@yahoo.com> <875y9aciir.fsf@yahoo.com> <9DC42D1F-2061-48ED-932B-9704538356C8@acm.org> <380B9B5B-9FB9-4A99-830B-117A33519D3A@acm.org> <838re5mzcu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25789"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "emacs-devel@gnu.org" , "luangruo@yahoo.com" To: Eli Zaretskii , =?iso-8859-1?Q?Mattias_Engdeg=E5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 04 10:36:35 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puUS1-0006WT-48 for ged-emacs-devel@m.gmane-mx.org; Thu, 04 May 2023 10:36:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puURH-0006yD-Uu; Thu, 04 May 2023 04:35:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puURF-0006xx-QC for emacs-devel@gnu.org; Thu, 04 May 2023 04:35:45 -0400 Original-Received: from mail-bn7nam10olkn2108.outbound.protection.outlook.com ([40.92.40.108] helo=NAM10-BN7-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puURD-00088G-PI; Thu, 04 May 2023 04:35:45 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qe1Kumh3SbE6sTiElWFVNlLjZfhy8HJ7+F+nYmHbJtQty6pkJW/qb6T+TUrl0ROgdYH1xcBhg4Hpahseu5kJ7hRXXW2LW/CpdrsSmc3iRufG8Bw/1lThJsgiHkZKdYm0B2oatlkPts0J3UTjXFP96nln03BRcMQtNZxrrBr0Z0RzfnsIPVeuzFeC9vDKBiGIkz4fDrzax+IfjnCOvrg38bzTXGMj694XCp0bPOWPfYrK5SDsPLHYTTjLGzwKARNNkZnbHgukHlWoEv9WqNPtasZ5NrfF90CbISnEzTFjduxybVP8x4L+wH3H++wC59kEvYcRdXtzDPPo465h9UydLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gQb5fa+YmXO95BW0rKrjvgLDk/oSz3GlH5asiNKlGK4=; b=I+aAwJ1WPDYzMSGSm+lOt8McSQzQe+F+WLX1u0E2yB89ZU0Z+53+Mhhhai6R65n9pjA7IUR/XRs+dZR1VU64yNDYI1ovGiREkn2w1DurfhtPNGppk59wkM6JFCdjMPbE/rBsBw0XIrhOWJDn7pn12Z7DLuaKseNxdf/8R/jp77inMxZrGAsgEaKN0lJzuqeqLPdn/S5IY4Rcabk5Me2UN77t5nZAVhyDkeqFboeJhH8PvZxe7X8C5Wo0dEvsrjs1jtJsIGFzUaW6IYBYKKtogmaAEtzfG4XE2N+DD+BhirlrMFc6Ghq5sobxZw3hZY3bVHNpU4ncP9u+MLpO1lsj3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gQb5fa+YmXO95BW0rKrjvgLDk/oSz3GlH5asiNKlGK4=; b=RSydTLKs/3QmST7j6hKwXJHqY5ppA7e4knubYPa0dSP+98ksiBIyrYEKOcgGAo6oSdtccBK3YQ/0E8nYcNBYrMQUqIKeg2hNY/qFhdmjMXXAWGCR57CqJK7kctKMJx3KSUL9h3/iwUkCUpwEHYapXkb5ZsHWOPwWl4/DBk5xWAosbEowqovQwGH+JObOPSVwo9EnfzV2px4NdLHf9YJ3KgTXW4BAmf40B7fBtntQIKLiGthFd63s8P/yfwfnWhZfW6fMT53tLRVacqnEsf/o4wn0qW9Q45B7/mxAKFWsYDpyteNdY9rWkfRduUpwr9EMYo6IdYDYtwSMLrgGT8RUeQ== Original-Received: from SA0PR04MB7433.namprd04.prod.outlook.com (2603:10b6:806:e2::8) by CH0PR04MB8049.namprd04.prod.outlook.com (2603:10b6:610:f5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 08:35:41 +0000 Original-Received: from SA0PR04MB7433.namprd04.prod.outlook.com ([fe80::9fe0:ce70:5b47:8989]) by SA0PR04MB7433.namprd04.prod.outlook.com ([fe80::9fe0:ce70:5b47:8989%7]) with mapi id 15.20.6363.026; Thu, 4 May 2023 08:35:41 +0000 Thread-Topic: Bug? Thread-Index: AQHZfaNGszu99UqFS0ucz7esmA6Jfq9IVCqAgAAUGTSAAWMdlQ== In-Reply-To: <838re5mzcu.fsf@gnu.org> Accept-Language: en-US, zh-CN Content-Language: en-US x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [KbT5SxKk7PBKCRWZKvsZ4wupAifyzEbr] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA0PR04MB7433:EE_|CH0PR04MB8049:EE_ x-ms-office365-filtering-correlation-id: f8f0785f-83f4-4904-9480-08db4c7a8b18 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: s6JEAopzQOr3OccMcEAN3VU+hR94z/g7oTx2AVuE65d7JwQ99O3A6oM3+VhU5qaQyj4i/4qLp6eSLhdnVadUJ0VlQAevJPxM0126T08OvfgSKQsIxNyeqsg4xIwq5nNd8qKHanUgdVYID1N7MFLUsZaICMzU6Ziph6q6Cd1eUFmMBeMXR45Ut7P8XP9b0wPEq7jmrEV04IBCaNMBUvgZUzwI7ihk5vvmQ9tcLGbYgPCH/vEondxdbrcZST/o06fTWUVjkGCUZ+2UDuGExZhLGnrOPcz5xJjFU7EBeq/Wx7d/+sSuEpSKOu+5iYYmgTu+ftdpztJ936ZoveraaNdgTuy/uihO8hzZYah0V/ViBVMBJza44SAU04L4F/m12sxYMbaUk7/8fdWdytr6O98D68kFyh/atkaC2P8mlpBz7+lMv9ASeUI9QzZq1KbSXQnmfaC1014tK/T28f7WIo7TJY71t2ALtMM8By2zap7fMbpdWh1OeCSUvLfy9hfO9tPC6x9614o+9olU85oROVWDcBrT88g92neeigik4LTqeUrtYoJMFUYs0N927GKYZcwEG9O4dKniUoJXWuFfDuadGLD5Ry0Wx6F930kTXn+85VelGfZ/3iCvgkdZguc+rd95 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?zn+JwLvUXTf8TKGjt/5NU1+Ls3CQ9igMbsZdYsnd8sKTwXakoelulA31qr?= =?iso-8859-1?Q?3mNAOEc6UvdBejm5Y7h3SYoGNS6FDxIfV6eMe/tCI1SrMqgkC8enjAr1QI?= =?iso-8859-1?Q?HDvcBhGL17CnrHIK5Hj/mzwfCPXV5b5EHGYtZ7oyBSKkMJ9TCwPAuW9oUL?= =?iso-8859-1?Q?eJCVU2FANXqfFNUEJpCsbEg90f1aJuy31iiKS5zGzagXLsar43T1ClO6UJ?= =?iso-8859-1?Q?CFQEQOMfdY26b6kRARKKn8Y5T2KQKQznH1xUV91CPSvimgLJgBsW2vUcwO?= =?iso-8859-1?Q?e+ktTX5KDoVegkCz1grRq6kc/phDj1WBbwcB1PgsP6FQoLUSJyKiWlZZeb?= =?iso-8859-1?Q?ySMnSxoQXOP478tjIi79qxn6zqkoA0YOp5qTlZwPxn+31YQPTp4qwp7req?= =?iso-8859-1?Q?mMC/p44OmROZFiTdrMmCP6Kw63//HwSZrT5zZmi9CtQljMkN2wKx51dU3l?= =?iso-8859-1?Q?qQWhNrVAmMPL/MGxOIp1LNt+GExfvV0TheUR9a646Ih7ETT3Gj/CCLsLlf?= =?iso-8859-1?Q?5nVzRxHfR9vitOHd0ZjrsZZ0zC+G33zG0XRRkPip73xYIZ/jzYdtomY5vF?= =?iso-8859-1?Q?tt9w6YtInlq39qnIYQPn8GSGdWoxUEF+7172KAlYVBURuTNEnCYLLZigHz?= =?iso-8859-1?Q? X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA0PR04MB7433.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: f8f0785f-83f4-4904-9480-08db4c7a8b18 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2023 08:35:40.5971 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR04MB8049 Received-SPF: pass client-ip=40.92.40.108; envelope-from=one.last.kiss@outlook.com; helo=NAM10-BN7-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305827 Archived-At: Hi, Eli.=0A= =0A= In my last email, I mentioned that highlighting only 1 character is=0A= the original behavior of the function `blink-matching-open':=0A= =0A= > From: Shynur Xie =0A= > To: Mattias Engdeg=E5rd=0A= > Cc: emacs-devel; Po Lu=0A= >=0A= >> I also noticed that when the closing bracket is comprised of=0A= >> multiple characters, only the first character is high-lit using=0A= >> that face.=0A= >=0A= > That is the original behavior of `blink-matching-open' -- it only=0A= > highlights the first character. (What you expected is provided by=0A= > `show-paren-mode'.) It uses `forward-sexp' to move point to the=0A= > first character (in your example, it's `c`), but `forward-sexp'=0A= > doesn't report the length of this keyword (i.e., `case`).=0A= =0A= I also find that, the mode `show-paren-mode' (which highlights an=0A= entire matched keyword) also emits a message "Matches %s" which will=0A= override what `blink-matching-open' does, when that mode's own option=0A= `show-paren-context-when-offscreen' is t.=0A= =0A= In conclusion, before my patch was installed, by default,=0A= `blink-matching-open' highlighted only 1 matched character when that=0A= character is on-screen; `show-paren-mode' highlighted the entire=0A= keyword. But both of them didn't highlight the matched off-screen=0A= openparen shown in the echo area. After my patch was installed,=0A= `blink-matching-open' highlights the 1st character when that character=0A= is off-screen, as well as how it does originally when the character is=0A= on-screen.=0A= =0A= So I'm now wondering, would it be better to write the functionality=0A= (highlighting an entire matched keyword when it is shown in the echo=0A= area) into instead of (and make it a=0A= part of `show-paren-mode')? My opinion is, if `blink-matching-open'=0A= highlights the entire matched keyword in the echo area, why doesn't it=0A= also highlight an entire keyword that is on-screen? But if it does,=0A= `blink-matching-open' and `show-paren-mode' will conflict/duplicate in=0A= function/code. If we make that functionality a part of=0A= `show-paren-mode', not only is behavioral consistency guaranteed in=0A= all respects, but that functionality can simply reuse the logic/code=0A= of `show-paren-mode'.=0A= =0A= Any suggstion? Thanks.=0A= =0A= --=0A= shynur=0A=