From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Shynur Xie Newsgroups: gmane.emacs.devel Subject: Re: Bug? Date: Wed, 3 May 2023 11:24:13 +0000 Message-ID: References: <875y9aciir.fsf.ref@yahoo.com> <875y9aciir.fsf@yahoo.com> <9DC42D1F-2061-48ED-932B-9704538356C8@acm.org> <380B9B5B-9FB9-4A99-830B-117A33519D3A@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9179"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel , Po Lu To: =?iso-8859-1?Q?Mattias_Engdeg=E5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 03 13:29:42 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puAg2-0002Hb-0A for ged-emacs-devel@m.gmane-mx.org; Wed, 03 May 2023 13:29:42 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puAfh-0004yp-Dp; Wed, 03 May 2023 07:29:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puAfg-0004yh-Kn for emacs-devel@gnu.org; Wed, 03 May 2023 07:29:20 -0400 Original-Received: from mail-mw2nam10olkn20825.outbound.protection.outlook.com ([2a01:111:f400:7e89::825] helo=NAM10-MW2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puAff-0004kN-0v for emacs-devel@gnu.org; Wed, 03 May 2023 07:29:20 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CX1jKesq6d1H1FKTOpcKLA43TuDELXc40flnwXtT35zRKaF5XoDhvOZ/hr5ruBTynUjUVrPnuo32Ut2QIzt1iIffU9L2uzefUA2PcqiP+Wi0IVZMXBx+TH/BbsJphQIyKahUH1Pez/G0FhSI9xtZz66WBQ4YtCDI+aOW9s+VMjO5qTC6nb3JC1XF4mTDIsYFFJPhzya2H57j60rwXHo65syauWzYx7zMOzYi9JQrrrIdJ0IoiYX4ye+yDMJTt3RS1NYAOWlqes86JOs20igIQzpuCwWabWNZucMESCI2ez6FPl9Y2KwBhejd1VbKV4+3QVkEeHzAnkJeDg8xE6StCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zSdFDGEx6Z1v5w2B2bMTJ6Z/o7ms1P5PFrSRBs4iUmU=; b=Dj7Dgow97d5K4xN2tMpPjDUvqAQbtnhBx8ryxF9Kr3et6Ok5LKfTEBtTvNOqoYAPj3rrgR5tbGEMvSsIVrqoVg/UQDkyfOuLTHKxaCV+p6+qQ+cDNqR1XaGo2/KhAIq1dbS+i3uCNP2sdd5IMbqmZFhc5aczDT2keJNnqS9lWOGaVJbiP/BMRC45QNv2a2DOBOAFF+gKDhnRra4enUpsXa1xpkv0Jn0HkiVNuC7rD03xLJ3Cip+KMMKZcQwPP3YxcwatPvpcv3UpGvVDeyAilv16AO2op8G2ije15BX7uXahPbtecsAjUogzPkezohbs/+d+zgDufzuto7JazsVeWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zSdFDGEx6Z1v5w2B2bMTJ6Z/o7ms1P5PFrSRBs4iUmU=; b=XEiuqRUvt+m9GaONDX/dPhMo05qBGuIGz9M/MXwkBgjXNZig2Zx0ue31/WRplxt1L2hoF4YifKaoTgN4MrVeFEEWVxLNnRb2mBqfr4fWMXs/nqc2JLf7B29Fzh+bKhojTFIBvUTmy8n5cuIibkoDA08MpuV7rMH7yMAEDHHB3ue9kvZrX/Z8TgPIpIwhEMNvx7esz5VxWQB9yK0VEHM0qCv2taVfP5Tfw/tqARJeHCnlECX8/4pDEvw2U/W0jJoyz041zxgGRTWrg9cTSQR7Bi+voON4zM+VKhnqHMeM+eTaZZJuyq0bGEZo8q9DT0iAUzCp/bFXZ0D8s1ViFiwhSQ== Original-Received: from SA0PR04MB7433.namprd04.prod.outlook.com (2603:10b6:806:e2::8) by BY5PR04MB7025.namprd04.prod.outlook.com (2603:10b6:a03:22f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Wed, 3 May 2023 11:24:13 +0000 Original-Received: from SA0PR04MB7433.namprd04.prod.outlook.com ([fe80::9fe0:ce70:5b47:8989]) by SA0PR04MB7433.namprd04.prod.outlook.com ([fe80::9fe0:ce70:5b47:8989%7]) with mapi id 15.20.6363.020; Wed, 3 May 2023 11:24:13 +0000 Thread-Topic: Bug? Thread-Index: AQHZfaNGszu99UqFS0ucz7esmA6Jfq9IVCqAgAAUDp8= In-Reply-To: <380B9B5B-9FB9-4A99-830B-117A33519D3A@acm.org> Accept-Language: en-US, zh-CN Content-Language: en-US x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [vvnTrWTjCluSagoL0akGvQlR9yO0B+I8] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA0PR04MB7433:EE_|BY5PR04MB7025:EE_ x-ms-office365-filtering-correlation-id: 62635f89-6d4e-4723-d5a3-08db4bc8ec2f x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4MDRny0zyvk1qlK2I+apW+Qe9DrOGCAUFhloo080Aet3ytiwd91Gc3VPFmNSfNs0kW+ylVKRYF55pijTTgUMl97TAoG2E2YnlnGpcA7wpTmm80A8hhR1dBPQ3EDg6zLBss/xsFkiLjx4C0pj1RpDrr0vODVcdXRY7Putvf0G4RgKue4ENuZb5lN6F0T4cod7UuVFAH3FZAcsbrSiQM7Im7U9J9DDDlGh8kti3GxisAMCiTY1kbnc8oSFC2VUObTzEIDE0Jn5VbV8VydGGgRo3DV8XiPn6GjPyy9GzOhIMMiw711aHlcN8HlYEYf4bTDIspi61xA2bsGSrJOYkRq4CGw2o4KpOvO1AUTcHPvrTB3vGlgkjGhQeyFXvUmz0J52aWy8srH4nfMyEPgDXFu1NBMT6pG025r+kDfbKXzuAN/O7sgLCgvH5MkvLQGplIKBgr0nGf0xmQqNxqXNgtziz3g2djrxeD9Z40pNnC02p62Qv0B6SoTV0QDW1lA/kFMa/DDfdexmLRhG+ceKqlc4vTK/KdMWzeWUZwsRkXZrrkR55HODFhHt+v42arikvcl6Sai4gi1lfvC/4VKAID/vrJW0qJmIMPvTvnggDWMFmQIKKAffCWBHGU5PBQFudq1c x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?1G593jMOmV4ZAhag6t7BM74TiCUoeN7OcBQeTd4IhgSzK7ZRiAaCA1E93J?= =?iso-8859-1?Q?Z+0JN/9sCSKaJMl+6ZmkUKIdcS7g4DUHth8xJqAs8tRWiY0aHt4yfT4OPc?= =?iso-8859-1?Q?ZQrlZRqtDlif70R0doeA5eJuMbt2M0FNEzYlclhXj1IY5r3bkCCzzLKFkb?= =?iso-8859-1?Q?Telv03H5MYQpLlKyvIP07rhZlnBGecgfI4jhnbAOG6MnNRpGNOUWbn2u3S?= =?iso-8859-1?Q?fMQsJg6SSPUv7IFYYMaoonsDGD4HfcXiMPmxT9Z3x4aHWz5Q7bso3A9tM6?= =?iso-8859-1?Q?iZCQYNg5hexO0d7NCIA0NKItPk8HhfHK1oWj+EOjdwozoaTBCm3MBQwZ27?= =?iso-8859-1?Q?gPMX5I6awg3hRywRecen2zlJ0Ii/CcHOrQOuNGTZnNv3TVNmDDl+XVkPn2?= =?iso-8859-1?Q?lV1wwIAR1jaNSkAAonQ5/OmEhbpgwGba84E4+DlHWdOrFX50xKQk5/L9FE?= =?iso-8859-1?Q?nI0oHGQT5/PnCUIdXzQSEM3Qg/Eci/pgSSZcsA4TL8c4ZHqNzAGwZL5vB0?= =?iso-8859-1?Q?JQBIyXHzvzTvlTX8zgw6a4tVh83s1r6XGesHr61oOuKyzDSA8Y5mp5K/Nw?= =?iso-8859-1?Q?MLeiF5t23qPQbEHnSO8LIcMpjQjcHyMI+lUZYBS7ggOcn+tU6ZgDryPJ8s?= =?iso-8859-1?Q? X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA0PR04MB7433.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 62635f89-6d4e-4723-d5a3-08db4bc8ec2f X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2023 11:24:13.0926 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR04MB7025 Received-SPF: pass client-ip=2a01:111:f400:7e89::825; envelope-from=one.last.kiss@outlook.com; helo=NAM10-MW2-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305776 Archived-At: > From: Po Lu=0A= > Subject: Bug?=0A= > Date: Wed, 03 May 2023 09:26:20 +0800=0A= >=0A= > Is this not a subtle bug?=0A= =0A= Thanks.=0A= =0A= > From: Mattias Engdeg=E5rd=0A= > Subject: Re: Bug?=0A= > Date: Wed, 3 May 2023 11:40:04 +0200=0A= >=0A= > Good catch, should work a little better now.=0A= =0A= Thanks for fixing it.=0A= =0A= > is terrible on a white background=0A= =0A= Sorry for that.=0A= =0A= > Don't we have an existing suitable face to inherit from?=0A= =0A= Do you mean to inherit from those faces that set colors separately for=0A= light and dark backgrounds? I hadn't thought about it before; it's a=0A= good idea, I think.=0A= =0A= > I also noticed that when the closing bracket is comprised of=0A= > multiple characters, only the first character is high-lit using that=0A= > face.=0A= =0A= That is the original behavior of `blink-matching-open' -- it only=0A= highlights the first character. (What you expected is provided by=0A= `show-paren-mode'.) It uses `forward-sexp' to move point to the first=0A= character (in your example, it's `c`), but `forward-sexp' doesn't=0A= report the length of this keyword (i.e., `case`). I have no idea how=0A= to implement highlighting for the entire matched keyword without=0A= making many modifications.=0A= =0A= BTW, if you want to give the function `blink-matching-open' the=0A= semantic of highlighting the entire matched keyword, please change the=0A= name of the function `blink-paren-open-paren-line-string' called by=0A= `blink-matching-open', since `case` is not a parenthesis. Thanks.=0A= =0A= --=0A= shynur=0A=