unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@is.elta.co.il>
Cc: emacs-devel@gnu.org
Subject: Re: gratuitous changes
Date: Sun, 2 Feb 2003 07:56:18 +0200 (IST)	[thread overview]
Message-ID: <Pine.SUN.3.91.1030202075258.18963D-100000@is> (raw)
In-Reply-To: <200301312148.h0VLmG128712@rum.cs.yale.edu>


On Fri, 31 Jan 2003, Stefan Monnier wrote:

> I am responsible for a fair bit of spurious changes in that I often
> remove trailing whitespace when I come across it and thus end
> up comitting changes to more than the places where I've actually
> modified the code.
> 
> But I still think that what happened with keyboard.c is bad:
> turning every whitespace-only line into an empty line.

I generally dislike unnecessary whitespace changes as well: for one 
thing, they make diffs much harder to grasp.

However, I must say that when I brought up this issue in the past in the 
context of Emacs development, most of other developers didn't feel it was 
that bad.  So, as extreme as this particular case is, at least in 
principle, Emacs development does not seem to discourage such gratuitous 
changes.  At least it didn't until now.

  parent reply	other threads:[~2003-02-02  5:56 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-31 21:48 gratuitous changes Stefan Monnier
2003-01-31 22:16 ` Andreas Schwab
2003-01-31 22:51   ` John Wiegley
2003-01-31 23:01 ` Juanma Barranquero
2003-02-01  0:00   ` Stefan Monnier
2003-02-01  6:51     ` Robert Anderson
2003-02-03 15:09       ` Stefan Monnier
2003-02-03 16:20         ` Robert Anderson
2003-02-01  9:54     ` Juanma Barranquero
2003-02-01  2:11 ` Miles Bader
2003-02-01 18:44   ` Bill Wohler
2003-02-01 22:11 ` Richard Stallman
2003-02-01 23:28   ` Martin Stjernholm
2003-02-02  5:52     ` Eli Zaretskii
2003-02-02  6:14       ` Miles Bader
2003-02-06 16:34         ` Martin Stjernholm
2003-02-06 17:22           ` Miles Bader
2003-02-10  0:29             ` Martin Stjernholm
2003-02-03 14:57     ` Stefan Monnier
2003-02-02  5:56 ` Eli Zaretskii [this message]
2003-02-02 12:56   ` Juanma Barranquero
2003-02-02 13:59   ` Kim F. Storm
2003-02-03 13:01     ` Richard Stallman
2003-02-03 14:11       ` Juanma Barranquero
2003-02-03 14:54         ` Stefan Monnier
2003-02-03 15:01           ` Juanma Barranquero
2003-02-04 14:59       ` Juanma Barranquero
2003-02-04 16:09         ` Robert Anderson
2003-02-04 16:44           ` Juanma Barranquero
2003-02-04 17:14             ` Robert Anderson
2003-02-04 17:22               ` Juanma Barranquero
2003-02-04 19:46         ` Eli Zaretskii
2003-02-04 20:16           ` Juanma Barranquero
2003-02-04 20:22             ` Stefan Monnier
2003-02-04 20:44               ` Nick Roberts
2003-02-04 22:59                 ` Edward O'Connor
2003-02-04 23:19                   ` Juanma Barranquero
2003-02-05  0:32                   ` Kim F. Storm
2003-02-05  0:39                     ` Kim F. Storm
2003-02-05  0:49                       ` Kenichi Handa
2003-02-05  4:24                     ` Luc Teirlinck
2003-02-05  4:51                       ` Miles Bader
2003-02-06  2:42                   ` Richard Stallman
2003-02-06  4:09                     ` Luc Teirlinck
2003-02-07  9:18                       ` Richard Stallman
2003-02-04 23:18                 ` Juanma Barranquero
2003-02-05  0:42                   ` Stefan Monnier
2003-02-05  6:03                 ` Eli Zaretskii
2003-02-06  2:42                 ` Richard Stallman
2003-02-06  2:54                   ` Luc Teirlinck
2003-02-04 23:14               ` Juanma Barranquero
2003-02-05  6:01             ` Eli Zaretskii
2003-02-05  8:18               ` Juanma Barranquero
2003-02-05 15:30                 ` Eli Zaretskii
2003-02-14 22:56                   ` Thien-Thi Nguyen
2003-02-05  0:14         ` Richard Stallman
2003-02-07 14:02 ` Francesco Potorti`
2003-02-10  1:47   ` Miles Bader
2003-02-10 10:09     ` Francesco Potorti`

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.SUN.3.91.1030202075258.18963D-100000@is \
    --to=eliz@is.elta.co.il \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).