From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@is.elta.co.il>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCHES] 21.3.50 for Cygwin: patch 5
Date: Wed, 25 Dec 2002 08:12:45 +0200 (IST)
Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Message-ID: <Pine.SUN.3.91.1021225080757.7483D-100000@is>
References: <asqqnl$797$3@main.gmane.org>
NNTP-Posting-Host: main.gmane.org
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Trace: main.gmane.org 1040796799 18874 80.91.224.249 (25 Dec 2002 06:13:19 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Wed, 25 Dec 2002 06:13:19 +0000 (UTC)
Cc: emacs-devel@gnu.org
Return-path: <emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 18R4n8-0004uI-00
	for <emacs-devel@main.gmane.org>; Wed, 25 Dec 2002 07:13:18 +0100
Original-Received: from monty-python.gnu.org ([199.232.76.173])
	by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian))
	id 18R4r2-0007B9-00
	for <emacs-devel@quimby.gnus.org>; Wed, 25 Dec 2002 07:17:20 +0100
Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.10.13)
	id 18R4nC-0003cu-05
	for emacs-devel@quimby.gnus.org; Wed, 25 Dec 2002 01:13:22 -0500
Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13)
	id 18R4mu-0003cP-00
	for emacs-devel@gnu.org; Wed, 25 Dec 2002 01:13:04 -0500
Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13)
	id 18R4mq-0003bY-00
	for emacs-devel@gnu.org; Wed, 25 Dec 2002 01:13:04 -0500
Original-Received: from is.elta.co.il ([199.203.121.2])
	by monty-python.gnu.org with esmtp (Exim 4.10.13)
	id 18R4mp-0003XN-00
	for emacs-devel@gnu.org; Wed, 25 Dec 2002 01:13:00 -0500
Original-Received: from is (is [199.203.121.2])
	by is.elta.co.il (8.9.3/8.8.8) with SMTP id IAA07744;
	Wed, 25 Dec 2002 08:12:45 +0200 (IST)
X-Sender: eliz@is
Original-To: Joe Buehler <jbuehler@hekimian.com>
In-Reply-To: <asqqnl$797$3@main.gmane.org>
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1b5
Precedence: list
List-Id: Emacs development discussions. <emacs-devel.gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Post: <mailto:emacs-devel@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Xref: main.gmane.org gmane.emacs.devel:10338
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:10338


On Fri, 6 Dec 2002, Joe Buehler wrote:

> --- lib-src/pop.c	17 May 2002 11:24:02 -0000	1.31
> +++ lib-src/pop.c	6 Dec 2002 16:34:43 -0000
> @@ -119,6 +119,9 @@
>   #endif
>   #endif
> 
> +#ifdef _P
> +#undef _P
> +#endif
>   #ifndef _P
>   # ifdef __STDC__
>   #  define _P(a) a

This might be dangerous: other platforms could define _P in their system 
header, and this patch then causes them to use the definition supplied by 
pop.c.  If that definition somehow doesn't work on some of those 
platforms, pop.c is now broken on them.

In other words, this change has effect much beyond the Cygwin port, and 
should IMHO be avoided if possible.

Why isn't the original #ifndef guard enough to solve the problem on 
Cygwin?  Could you please show how does the original code fail, and 
explain why?

> --- src/mem-limits.h	19 Aug 2002 17:45:50 -0000	1.31
> +++ src/mem-limits.h	6 Dec 2002 16:35:33 -0000
> @@ -46,6 +46,10 @@
>   #define BSD4_2
>   #endif
> 
> +#ifdef CYGWIN
> +#define BSD4_2
> +#endif

Can't this be done in src/s/cygwin.h?