From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: GTK patches part 2 Date: Thu, 12 Dec 2002 08:05:13 +0200 (IST) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <1167.1039637070@remus.pretzelnet.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Trace: main.gmane.org 1039673461 24119 80.91.224.249 (12 Dec 2002 06:11:01 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Thu, 12 Dec 2002 06:11:01 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18MMYf-0006GN-00 for ; Thu, 12 Dec 2002 07:10:53 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18MMk3-0005IX-00 for ; Thu, 12 Dec 2002 07:22:39 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18MMTs-0005S0-0A for emacs-devel@quimby.gnus.org; Thu, 12 Dec 2002 01:05:56 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18MMTZ-0005R5-00 for emacs-devel@gnu.org; Thu, 12 Dec 2002 01:05:37 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18MMTX-0005Pw-00 for emacs-devel@gnu.org; Thu, 12 Dec 2002 01:05:36 -0500 Original-Received: from is.elta.co.il ([199.203.121.2]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18MMTV-0005OD-00 for emacs-devel@gnu.org; Thu, 12 Dec 2002 01:05:34 -0500 Original-Received: from is (is [199.203.121.2]) by is.elta.co.il (8.9.3/8.8.8) with SMTP id IAA15906; Thu, 12 Dec 2002 08:05:14 +0200 (IST) X-Sender: eliz@is Original-To: Eric Gillespie In-Reply-To: <1167.1039637070@remus.pretzelnet.org> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:10081 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:10081 On Wed, 11 Dec 2002, Eric Gillespie wrote: > In another post, Jan reveals why the stdio.h problem was not > obvious until i tried to build: s/gnu-linux.h includes stdio.h. > This sort of thing is bound to happen again in the future, which > is why i suggest that it is better to include the headers you > need, rather than relying on system-dependent header files to do > it for you. FWIW, I agree. I didn't check in this particular case, but I'm guessing that s/gnu-linux.h included stdio.h because it used something from that header. Other system-dependent headers might not do that. Including stdio.h in each of the *.c files that use stdio will thus prevent compilation problems on some platforms.