unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* patch for broken cp866 in codepage.el (21.2 and 21.2,92)
@ 2002-11-14 11:04 Ivan Zakharyaschev
  2002-11-17  5:47 ` Eli Zaretskii
  0 siblings, 1 reply; 2+ messages in thread
From: Ivan Zakharyaschev @ 2002-11-14 11:04 UTC (permalink / raw)


[-- Attachment #1: Type: TEXT/PLAIN, Size: 686 bytes --]

	Hello!

I'd like to point out the fact that the coversion table for cp866
(defined in international/codepage.el) is broken in 21.2 and the
prestest 21.2.92.

The attched patch is supposed to fix it. I think this is a mere
simple bugfix, and is worth being applied to the most stable branches of
Emacs (RC, pretest, etc.)

I have not looked into the other deevlopment branches of emacs source,
hope those who hack on this piece of source will cope with this problem
completely.

cp866 is generally the same as cyrillic-alternativnyj.

Regards,
-- 
Ivan Zakharyaschev
ALT Linux Team member
I'm a Sisyphus developer: it's core is GNU/Linux
http://www.altlinux.ru, http://www.altlinux.com

[-- Attachment #2: correct the conversion table --]
[-- Type: TEXT/PLAIN, Size: 970 bytes --]

There is an error in the table for CP866.
This seems to be a fix for it (it worked fine on large amounts
of CP866-encoded text -- the result was the same as of iconv), but
I haven't checked it thoroghly according to some specification.

imz@altlinux.ru, Februray 2002.

--- emacs-21.1.orig/lisp/international/codepage.el	Thu Feb  7 00:39:13 2002
+++ emacs-21.1/lisp/international/codepage.el	Thu Feb  7 00:42:51 2002
@@ -384,7 +384,7 @@
    128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143
    144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159
    160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175
-   223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238
+   224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239
    252 241 nil nil 243 nil nil 245 nil nil nil nil nil nil 247 nil]
   "Table for converting ISO-8859-5 characters into codepage 866 glyphs.")
 (setplist 'cp866-decode-table

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: patch for broken cp866 in codepage.el (21.2 and 21.2,92)
  2002-11-14 11:04 patch for broken cp866 in codepage.el (21.2 and 21.2,92) Ivan Zakharyaschev
@ 2002-11-17  5:47 ` Eli Zaretskii
  0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2002-11-17  5:47 UTC (permalink / raw)
  Cc: emacs-devel


On Thu, 14 Nov 2002, Ivan Zakharyaschev wrote:

> I'd like to point out the fact that the coversion table for cp866
> (defined in international/codepage.el) is broken in 21.2 and the
> prestest 21.2.92.
> 
> The attched patch is supposed to fix it. I think this is a mere
> simple bugfix, and is worth being applied to the most stable branches of
> Emacs (RC, pretest, etc.)

Thanks, I installed your fixes in both branch and HEAD.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2002-11-17  5:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-11-14 11:04 patch for broken cp866 in codepage.el (21.2 and 21.2,92) Ivan Zakharyaschev
2002-11-17  5:47 ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).