From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Angelo Graziosi Newsgroups: gmane.emacs.devel Subject: Re: Failure in building Emacs 23.0.50 on Cygwin (fwd) Date: Tue, 4 Sep 2007 22:53:47 +0200 (MET DST) Message-ID: References: <20070903075037.2652@blackhawk> <20070903092334.2296@blackhawk> <200709041620.l84GKRKJ026897@oogie-boogie.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Trace: sea.gmane.org 1188939252 20800 80.91.229.12 (4 Sep 2007 20:54:12 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 4 Sep 2007 20:54:12 +0000 (UTC) Cc: Eli Zaretskii , "d.henman" , emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 04 22:54:09 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ISfPR-0008RN-B1 for ged-emacs-devel@m.gmane.org; Tue, 04 Sep 2007 22:54:05 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ISfPN-0001sF-7b for ged-emacs-devel@m.gmane.org; Tue, 04 Sep 2007 16:54:01 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ISfPJ-0001rU-DG for emacs-devel@gnu.org; Tue, 04 Sep 2007 16:53:57 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ISfPI-0001qu-D9 for emacs-devel@gnu.org; Tue, 04 Sep 2007 16:53:56 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ISfPI-0001qd-3d for emacs-devel@gnu.org; Tue, 04 Sep 2007 16:53:56 -0400 Original-Received: from postino2.roma1.infn.it ([141.108.26.25]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1ISfPC-0006ig-OG; Tue, 04 Sep 2007 16:53:51 -0400 Original-Received: from ax0rm1.roma1.infn.it (ax0rm1.roma1.infn.it [141.108.26.19]) by postino2.roma1.infn.it (8.12.11/8.12.11) with ESMTP id l84Krluk021345 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Tue, 4 Sep 2007 22:53:47 +0200 X-X-Sender: graziosi@ax0rm1.roma1.infn.it In-Reply-To: <200709041620.l84GKRKJ026897@oogie-boogie.ics.uci.edu> X-PMX-Version: 4.7.1.128075, Antispam-Engine: 2.5.2.311128, Antispam-Data: 2007.9.4.132325 X-PerlMx-Spam: Gauge=IIIIIII, Probability=7%, Report='SUPERLONG_LINE 0.05, __CP_URI_IN_BODY 0, __CT 0, __CT_TEXT_PLAIN 0, __HAS_MSGID 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __SANE_MSGID 0' X-Detected-Kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:77766 Archived-At: On Tue, 4 Sep 2007, Dan Nicolaescu wrote: > "d.henman" writes: > > > Angelo, > > > > content wise it looks good to me, but I think that changing it to the following > > format, same content as your patch (see modifed patch below ), but this format makes it easier to understand and would give it more robustness for future mainenance and any possible changes and extensions for CYGWIN specific issues. > > > > Also I would like to wait and get a response from the cygwin developers, before any commit is made. > > > > Regards, > > Darel Henman > > > > ---------------------------------------------------------------- > > --- term.c 2007-08-30 06:46:50.000000000 +0900 > > +++ /tmp/term.c.fixed 2007-09-03 09:15:22.915209300 +0900 > > @@ -3131,6 +3131,10 @@ > > setpgrp (); > > no_controlling_tty = 1; > > #else > > +#ifdef CYGWIN > > + setsid (); > > + no_controlling_tty = 1; > > +#else > > #ifdef TIOCNOTTY /* Try BSD ioctls. */ > > sigblock (sigmask (SIGTTOU)); > > fd = emacs_open ("/dev/tty", O_RDWR, 0); > > @@ -3145,6 +3149,7 @@ > > /* Unknown system. */ > > croak (); > > #endif /* ! TIOCNOTTY */ > > +#endif /* ! CYGWIN */ > > #endif /* ! USG */ > > } > > #endif > > > Just my curiosity, does this patch make emacs work on cygwin? > If it doesn't, is this function called before things go bad? IF 'setpgrp' is similar to 'setsid' (http://www.opengroup.org/onlinepubs/009695399/functions/setsid.html) AND IF Cygwin list suggests to use 'setsid' to dissociate TTY (http://cygwin.com/ml/cygwin/2007-09/msg00026.html) THEN the above patch is quite natural... OR NOT? Angelo.